Changeset 158290 in webkit

Timestamp:

Oct 30, 2013, 11:04:41 AM (12 years ago)

Author:

ap@apple.com

Message:

Mavericks: 128 tests are failing due to pixel differences
​https://bugs.webkit.org/show_bug.cgi?id=123488

Reviewed by Simon Fraser.

Apple font preferences cannot be fully reset after they've been read, so we
need to set them using CFPreferences before initializing NSApplication.

In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
appear to be. I guess we can figure out the reasons for this difference when/if
any observable problems start to occur.

• DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
to prepareConsistentTestingEnvironment().
(main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
(which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
useful to keep in case we change out approach to defaults again).

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/mac/DumpRenderTree.mm (modified) (4 diffs)

trunk/Tools/ChangeLog ¶

@@ +1 @@
+2013-10-30  Alexey Proskuryakov  <ap@apple.com>
+
+        Mavericks: 128 tests are failing due to pixel differences
+        https://bugs.webkit.org/show_bug.cgi?id=123488
+
+        Reviewed by Simon Fraser.
+
+        Apple font preferences cannot be fully reset after they've been read, so we
+        need to set them using CFPreferences before initializing NSApplication.
+
+        In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
+        appear to be. I guess we can figure out the reasons for this difference when/if
+        any observable problems start to occur.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
+        to prepareConsistentTestingEnvironment().
+        (main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
+        (which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
+        useful to keep in case we change out approach to defaults again).
+
 2013-10-29  Andy Estes  <aestes@apple.com>
 

trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm ¶

@@ -677 +677 @@
 static void setDefaultsToConsistentValuesForTesting()
 {
-    // FIXME: We'd like to start with a clean state for every test, but this function can't be used more than once yet.
-    [WebPreferences _switchNetworkLoaderToNewTestingSession];
-
     static const int NoFontSmoothing = 0;
     static const int BlueTintedAppearance = 1;
+
+    // These defaults are read at NSApplication initialization time, and there is no way to fully reset them afterwards.
+    // We have to use CFPreferences, because [NSUserDefaults standardUserDefaults] indirectly initializes NSApplication.
+    CFPreferencesSetAppValue(CFSTR("AppleFontSmoothing"), (CFNumberRef)@(NoFontSmoothing), kCFPreferencesCurrentApplication);
+    CFPreferencesSetAppValue(CFSTR("AppleAntiAliasingThreshold"), (CFNumberRef)@4, kCFPreferencesCurrentApplication);
+    CFPreferencesSetAppValue(CFSTR("AppleLanguages"), (CFArrayRef)@[ @"en" ], kCFPreferencesCurrentApplication);
 
     NSString *libraryPath = libraryPathForDumpRenderTree();
@@ -715 +718 @@
 
     [[NSUserDefaults standardUserDefaults] setVolatileDomain:dict forName:NSArgumentDomain];
-
-    // Underlying frameworks have already read AppleAntiAliasingThreshold default before we changed it.
-    // A distributed notification is delivered to all applications, but it should be harmless, and it's the only way to update all underlying frameworks anyway.
-    [[NSDistributedNotificationCenter defaultCenter] postNotificationName:@"AppleAquaAntiAliasingChanged" object:nil userInfo:nil deliverImmediately:YES];
-
-    NSURLCache *sharedCache =
-        [[NSURLCache alloc] initWithMemoryCapacity:1024 * 1024
-                                      diskCapacity:0
-                                          diskPath:[libraryPath stringByAppendingPathComponent:@"URLCache"]];
-    [NSURLCache setSharedURLCache:sharedCache];
-    [sharedCache release];
 }
 
@@ -849 +841 @@
     poseAsClass("DumpRenderTreeEvent", "NSEvent");
 
-    setDefaultsToConsistentValuesForTesting();
+    // FIXME: We'd like to start with a clean state for every test, but this function can't be used more than once yet.
+    [WebPreferences _switchNetworkLoaderToNewTestingSession];
+
+    NSURLCache *sharedCache =
+        [[NSURLCache alloc] initWithMemoryCapacity:1024 * 1024
+                                      diskCapacity:0
+                                          diskPath:[libraryPathForDumpRenderTree() stringByAppendingPathComponent:@"URLCache"]];
+    [NSURLCache setSharedURLCache:sharedCache];
+    [sharedCache release];
+
     adjustFonts();
     registerMockScrollbars();
@@ -931 +932 @@
 {
     NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+
+    setDefaultsToConsistentValuesForTesting(); // Must be called before NSApplication initialization.
+
     [DumpRenderTreeApplication sharedApplication]; // Force AppKit to init itself