Changeset 158652 in webkit
- Timestamp:
- Nov 4, 2013 11:05:59 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/mac/ChangeLog
r158599 r158652 1 2013-11-04 Alexey Proskuryakov <ap@apple.com> 2 3 DumpRenderTree should reset its preferences file on launch 4 https://bugs.webkit.org/show_bug.cgi?id=29751 5 6 Reviewed by Dan Bernstein. 7 8 * WebView/WebView.mm: 9 (-[WebView _retrieveKeyboardUIModeFromPreferences:]): 10 Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication 11 domain meant that current application's domain was explcitly ignored, and the only 12 way to override the setting in DRT was through argument domain. 13 1 14 2013-11-01 Jer Noble <jer.noble@apple.com> 2 15 -
trunk/Source/WebKit/mac/WebView/WebView.mm
r158599 r158652 6524 6524 - (void)_retrieveKeyboardUIModeFromPreferences:(NSNotification *)notification 6525 6525 { 6526 CFPreferencesAppSynchronize(kCFPreferences AnyApplication);6526 CFPreferencesAppSynchronize(kCFPreferencesCurrentApplication); 6527 6527 6528 6528 Boolean keyExistsAndHasValidFormat; 6529 int mode = CFPreferencesGetAppIntegerValue(AppleKeyboardUIMode, kCFPreferences AnyApplication, &keyExistsAndHasValidFormat);6529 int mode = CFPreferencesGetAppIntegerValue(AppleKeyboardUIMode, kCFPreferencesCurrentApplication, &keyExistsAndHasValidFormat); 6530 6530 6531 6531 // The keyboard access mode has two bits: -
trunk/Source/WebKit2/ChangeLog
r158647 r158652 1 2013-11-04 Alexey Proskuryakov <ap@apple.com> 2 3 DumpRenderTree should reset its preferences file on launch 4 https://bugs.webkit.org/show_bug.cgi?id=29751 5 6 Reviewed by Dan Bernstein. 7 8 * UIProcess/mac/WKFullKeyboardAccessWatcher.mm: 9 (-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]): 10 Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication 11 domain meant that current application's domain was explcitly ignored, and the only 12 way to override the setting in WTR was through argument domain. 13 1 14 2013-11-04 Tim Horton <timothy_horton@apple.com> 2 15 -
trunk/Source/WebKit2/UIProcess/mac/WKFullKeyboardAccessWatcher.mm
r158256 r158652 47 47 BOOL oldValue = fullKeyboardAccessEnabled; 48 48 49 CFPreferencesAppSynchronize(kCFPreferences AnyApplication);49 CFPreferencesAppSynchronize(kCFPreferencesCurrentApplication); 50 50 51 51 Boolean keyExistsAndHasValidFormat; 52 int mode = CFPreferencesGetAppIntegerValue(AppleKeyboardUIMode, kCFPreferences AnyApplication, &keyExistsAndHasValidFormat);52 int mode = CFPreferencesGetAppIntegerValue(AppleKeyboardUIMode, kCFPreferencesCurrentApplication, &keyExistsAndHasValidFormat); 53 53 if (keyExistsAndHasValidFormat) { 54 54 // The keyboard access mode has two bits: -
trunk/Tools/ChangeLog
r158643 r158652 1 2013-11-04 Alexey Proskuryakov <ap@apple.com> 2 3 DumpRenderTree should reset its preferences file on launch 4 https://bugs.webkit.org/show_bug.cgi?id=29751 5 6 Reviewed by Dan Bernstein. 7 8 Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults 9 and CFPreferencesCopyAppValue family of functions, it doesn't work with 10 CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...). 11 12 So, now we'll just set defaults in the current application. 13 14 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): 15 - Delete the defaults. 16 - Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same. 17 - The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect. 18 19 * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): 20 Switched to -setValuesForKeysWithDictionary for consistency. 21 1 22 2013-11-04 Filip Pizlo <fpizlo@apple.com> 2 23 -
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
r158290 r158652 680 680 static const int BlueTintedAppearance = 1; 681 681 682 // These defaults are read at NSApplication initialization time, and there is no way to fully reset them afterwards. 683 // We have to use CFPreferences, because [NSUserDefaults standardUserDefaults] indirectly initializes NSApplication. 684 CFPreferencesSetAppValue(CFSTR("AppleFontSmoothing"), (CFNumberRef)@(NoFontSmoothing), kCFPreferencesCurrentApplication); 685 CFPreferencesSetAppValue(CFSTR("AppleAntiAliasingThreshold"), (CFNumberRef)@4, kCFPreferencesCurrentApplication); 686 CFPreferencesSetAppValue(CFSTR("AppleLanguages"), (CFArrayRef)@[ @"en" ], kCFPreferencesCurrentApplication); 682 [[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"DumpRenderTree"]; 687 683 688 684 NSString *libraryPath = libraryPathForDumpRenderTree(); … … 717 713 }; 718 714 719 [[NSUserDefaults standardUserDefaults] setV olatileDomain:dict forName:NSArgumentDomain];715 [[NSUserDefaults standardUserDefaults] setValuesForKeysWithDictionary:dict]; 720 716 } 721 717 -
trunk/Tools/WebKitTestRunner/mac/main.mm
r158326 r158652 41 41 }; 42 42 43 [[NSUserDefaults standardUserDefaults] setV olatileDomain:dict forName:NSArgumentDomain];43 [[NSUserDefaults standardUserDefaults] setValuesForKeysWithDictionary:dict]; 44 44 } 45 45
Note: See TracChangeset
for help on using the changeset viewer.