Changeset 159104 in webkit

Timestamp:

Nov 12, 2013 6:40:29 AM (10 years ago)

Author:

akling@apple.com

Message:

Elements with class names automatically get unique ElementData.
<​https://webkit.org/b/124184>

We were calling Element::ensureUniqueElementData() for all Elements
with a non-empty list of class names. Doing that on parser-fresh
Elements caused us to upgrade them to UniqueElementData despite not
needing it (ElementData::setClass() is a const function for caching
the "cooked" class and can be called on ShareableElementData.)

1.09 MB progression on HTML5 spec at <​http://whatwg.org/c>

Reviewed by Antti Koivisto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-11-11  Andreas Kling  <akling@apple.com>
+
+        Elements with class names automatically get unique ElementData.
+        <https://webkit.org/b/124184>
+
+        We were calling Element::ensureUniqueElementData() for all Elements
+        with a non-empty list of class names. Doing that on parser-fresh
+        Elements caused us to upgrade them to UniqueElementData despite not
+        needing it (ElementData::setClass() is a const function for caching
+        the "cooked" class and can be called on ShareableElementData.)
+
+        1.09 MB progression on HTML5 spec at <http://whatwg.org/c>
+
+        Reviewed by Antti Koivisto.
+
 2013-11-12  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -1198 +1198 @@
     if (classStringHasClassName(newClassString)) {
         const bool shouldFoldCase = document().inQuirksMode();
-        const SpaceSplitString oldClasses = ensureUniqueElementData().classNames();
+        // Note: We'll need ElementData, but it doesn't have to be UniqueElementData.
+        if (!elementData())
+            ensureUniqueElementData();
+        const SpaceSplitString oldClasses = elementData()->classNames();
         elementData()->setClass(newClassString, shouldFoldCase);
         const SpaceSplitString& newClasses = elementData()->classNames();