Changeset 161025 in webkit

Timestamp:

Dec 23, 2013, 3:04:13 PM (11 years ago)

Author:

mark.lam@apple.com

Message:

CStack: Cosmetic: rename reservationEnd() to reservationTop().
​https://bugs.webkit.org/show_bug.cgi?id=126181.

Not yet reviewed.

reservationEnd() computes the end of the stack at the top. The value
is computed as:

char* reservationEnd = static_cast<char*>(m_reservation.base());
return reinterpret_cast_ptr<Register*>(reservationEnd);

Since m_reservation.base() points at a slot of memory that is within the
allocatable range of the stack, naming this function reservationEnd() is
inappropriate. Per Geoff's input, "end" usually refers to the slot past
the end of a buffer. Calling it "top" is more appropriate. Hence, I'm
renaming it to reservationTop().

• interpreter/JSStack.cpp:

(JSC::JSStack::enableErrorStackReserve):
(JSC::JSStack::disableErrorStackReserve):

• interpreter/JSStack.h:

(JSC::JSStack::reservationTop):

Location:

branches/jsCStack/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• interpreter/JSStack.cpp (modified) (1 diff)
• interpreter/JSStack.h (modified) (1 diff)

branches/jsCStack/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-12-23  Mark Lam  <mark.lam@apple.com>
+
+        CStack: Cosmetic: rename reservationEnd() to reservationTop().
+        https://bugs.webkit.org/show_bug.cgi?id=126181.
+
+        Not yet reviewed.
+
+        reservationEnd() computes the end of the stack at the top. The value
+        is computed as:
+
+            char* reservationEnd = static_cast<char*>(m_reservation.base());
+            return reinterpret_cast_ptr<Register*>(reservationEnd);
+
+        Since m_reservation.base() points at a slot of memory that is within the
+        allocatable range of the stack, naming this function reservationEnd() is
+        inappropriate.  Per Geoff's input, "end" usually refers to the slot past
+        the end of a buffer. Calling it "top" is more appropriate. Hence, I'm
+        renaming it to reservationTop().
+
+        * interpreter/JSStack.cpp:
+        (JSC::JSStack::enableErrorStackReserve):
+        (JSC::JSStack::disableErrorStackReserve):
+        * interpreter/JSStack.h:
+        (JSC::JSStack::reservationTop):
+
 2013-12-23  Filip Pizlo  <fpizlo@apple.com>
 

branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.cpp

@@ -148 +148 @@
 void JSStack::enableErrorStackReserve()
 {
-    m_useableEnd = reservationEnd();
+    m_useableEnd = reservationTop();
 }
 
 void JSStack::disableErrorStackReserve()
 {
-    char* useableEnd = reinterpret_cast<char*>(reservationEnd()) + commitSize;
+    char* useableEnd = reinterpret_cast<char*>(reservationTop()) + commitSize;
     m_useableEnd = reinterpret_cast_ptr<Register*>(useableEnd);
 

branches/jsCStack/Source/JavaScriptCore/interpreter/JSStack.h

@@ -147 +147 @@
 
 #if ENABLE(LLINT_C_LOOP)
-        Register* reservationEnd() const
+        Register* reservationTop() const
         {
-            char* reservationEnd = static_cast<char*>(m_reservation.base());
-            return reinterpret_cast_ptr<Register*>(reservationEnd);
+            char* reservationTop = static_cast<char*>(m_reservation.base());
+            return reinterpret_cast_ptr<Register*>(reservationTop);
         }