Changeset 161131 in webkit

Timestamp:

Dec 29, 2013, 4:27:51 PM (11 years ago)

Author:

ap@apple.com

Message:

Pending revision popover is slightly misplaced at build.webkit.org/dashboard
​https://bugs.webkit.org/show_bug.cgi?id=126278

Reviewed by Timothy Hatcher.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
as StatusLineView message element has extra padding, and doesn't fit the text snugly.
(BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:

(StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js ¶

@@ -92 +92 @@
             if (internalRevisionsBehind < 0)
                 internalRevisionsBehind = 0;
-            if (openSourceRevisionsBehind || internalRevisionsBehind) {
-                var message = openSourceRevisionsBehind + " \uff0b " + internalRevisionsBehind + " revisions behind";
-                var status = new StatusLineView(message, StatusLineView.Status.NoBubble);
-                this.element.appendChild(status.element);
-            }
-        } else if (openSourceRevisionsBehind) {
-            var message = openSourceRevisionsBehind + " " + (openSourceRevisionsBehind === 1 ? "revision behind" : "revisions behind");
-            var status = new StatusLineView(message, StatusLineView.Status.NoBubble);
-            this.element.appendChild(status.element);
-        }
-
-        if (status)
-            new PopoverTracker(status.messageElement, this._presentPopoverForPendingCommits.bind(this), queue);
+            if (openSourceRevisionsBehind || internalRevisionsBehind)
+                var messageText = openSourceRevisionsBehind + " \uff0b " + internalRevisionsBehind + " revisions behind";
+        } else if (openSourceRevisionsBehind)
+            var messageText = openSourceRevisionsBehind + " " + (openSourceRevisionsBehind === 1 ? "revision behind" : "revisions behind");
+
+        if (!messageText)
+            return;
+
+        var messageElement = document.createElement("span"); // We can't just pass text to StatusLineView here, because we need an element that perfectly fits the text for popover positioning.
+        messageElement.textContent = messageText;
+        var status = new StatusLineView(messageElement, StatusLineView.Status.NoBubble);
+        this.element.appendChild(status.element);
+
+        new PopoverTracker(messageElement, this._presentPopoverForPendingCommits.bind(this), queue);
     },
 

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js ¶

@@ -161 +161 @@
             this._messageElement.textContent = x;
         }
-    },
-
-    get messageElement()
-    {
-        return this._messageElement;
     }
 };

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css ¶

@@ -114 +114 @@
 }
 
-.status-line.no-bubble .message {
-    display: inline-block; /* Fit block to content, so that popovers are positioned correctly. */
-}
-
 .status-line.neutral .label,
 .status-line.neutral .message,

trunk/Tools/ChangeLog ¶

@@ +1 @@
+2013-12-29  Alexey Proskuryakov  <ap@apple.com>
+
+        Pending revision popover is slightly misplaced at build.webkit.org/dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=126278
+
+        Reviewed by Timothy Hatcher.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+        (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
+        as StatusLineView message element has extra padding, and doesn't fit the text snugly.
+        (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
+        (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
+        Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
+
 2013-12-29  Alexey Proskuryakov  <ap@apple.com>