Changeset 161363 in webkit


Ignore:
Timestamp:
Jan 6, 2014, 12:35:58 PM (11 years ago)
Author:
ap@apple.com
Message:

Gtk and Efl API test results confuse the dashboard
​https://bugs.webkit.org/show_bug.cgi?id=126535

Reviewed by Tim Horton.

Added "API tests" step as "platform api tests".

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.platformAPITestResultsURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration):
(BuildbotIteration.prototype.update):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):

Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js

    r161273 r161363  
    7272    },
    7373
     74    platformAPITestResultsURLForIteration: function(iteration)
     75    {
     76        return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/API%20tests/logs/stdio";
     77    },
     78
    7479    webkitpyTestResultsURLForIteration: function(iteration)
    7580    {

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js

    r161290 r161363  
    4040    this.layoutTestResults = null;
    4141    this.javascriptTestResults = null;
     42    this.apiTestResults = null;
     43    this.platformAPITestResults = null;
    4244    this.pythonTestResults = null;
    4345    this.perlTestResults = null;
    … …  
    175177            var apiTestResults = collectTestResults.call(this, data, "run-api-tests");
    176178            this.apiTestResults = apiTestResults ? new BuildbotTestResults(this, apiTestResults) : null;
     179
     180            var platformAPITestResults = collectTestResults.call(this, data, "API tests");
     181            this.platformAPITestResults = platformAPITestResults ? new BuildbotTestResults(this, platformAPITestResults) : null;
    177182
    178183            var pythonTestResults = collectTestResults.call(this, data, "webkitpy-test");

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js

    r161273 r161363  
    6262                var javascriptTestResults = iteration.javascriptTestResults || {failureCount: 0};
    6363                var apiTestResults = iteration.apiTestResults || {failureCount: 0};
     64                var platformAPITestResults = iteration.platformAPITestResults || {failureCount: 0};
    6465                var pythonTestResults = iteration.pythonTestResults || {failureCount: 0};
    6566                var perlTestResults = iteration.perlTestResults || {failureCount: 0};
    … …  
    7273                    var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
    7374                    var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
    74                 } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
     75                } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
    7576                    // Something wrong happened, but it was not a test failure.
    7677                    var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
    7778                    var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
    78                 } else if (layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
     79                } else if (layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
    7980                    var url = iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration);
    8081                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, layoutTestResults.failureCount === 1 ? "layout test failure" : "layout test failures", layoutTestResults.tooManyFailures ? layoutTestResults.failureCount + "\uff0b" : layoutTestResults.failureCount, url);
    8182                    new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
    82                 } else if (!layoutTestResults.failureCount && javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
     83                } else if (!layoutTestResults.failureCount && javascriptTestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
    8384                    var url = iteration.queue.buildbot.javascriptTestResultsURLForIteration(iteration);
    8485                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, javascriptTestResults.failureCount === 1 ? "javascript test failure" : "javascript test failures", javascriptTestResults.failureCount, url);
    85                 } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
     86                } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
    8687                    var url = iteration.queue.buildbot.apiTestResultsURLForIteration(iteration);
    8788                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, apiTestResults.failureCount === 1 ? "api test failure" : "api test failures", apiTestResults.failureCount, url);
    88                 } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
     89                } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
     90                    var url = iteration.queue.buildbot.platformAPITestResultsURLForIteration(iteration);
     91                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, platformAPITestResults.failureCount === 1 ? "platform api test failure" : "api test failures", platformAPITestResults.failureCount, url);
     92                } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
    8993                    var url = iteration.queue.buildbot.webkitpyTestResultsURLForIteration(iteration);
    9094                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, pythonTestResults.failureCount === 1 ? "webkitpy test failure" : "webkitpy test failures", pythonTestResults.failureCount, url);
    91                 } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
     95                } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && perlTestResults.failureCount && !bindingTestResults.errorOccurred) {
    9296                    var url = iteration.queue.buildbot.webkitperlTestResultsURLForIteration(iteration);
    9397                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, perlTestResults.failureCount === 1 ? "webkitperl test failure" : "webkitperl test failures", perlTestResults.failureCount, url);
    94                 } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
     98                } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !platformAPITestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
    9599                    var url = iteration.queue.buildbot.bindingsTestResultsURLForIteration(iteration);
    96100                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, "bindings tests failed", undefined, url);
    97101                } else {
    98102                    var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
    99                     var totalFailures = layoutTestResults.failureCount + javascriptTestResults.failureCount + apiTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
     103                    var totalFailures = layoutTestResults.failureCount + javascriptTestResults.failureCount + apiTestResults.failureCount + platformAPITestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
    100104                    var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures, url);
    101105                    new PopoverTracker(status.statusBubbleElement, this._presentPopoverForMultipleFailureKinds.bind(this), iteration);
    … …  
    225229        var javascriptTestResults = iteration.javascriptTestResults || {failureCount: 0};
    226230        var apiTestResults = iteration.apiTestResults || {failureCount: 0};
     231        var platformAPITestResults = iteration.platformAPITestResults || {failureCount: 0};
    227232        var pythonTestResults = iteration.pythonTestResults || {failureCount: 0};
    228233        var perlTestResults = iteration.perlTestResults || {failureCount: 0};
    … …  
    246251            var message = apiTestResults.failureCount + "\u00a0" + (apiTestResults.failureCount === 1 ? "api test failure" : "api test failures");
    247252            addResultKind(message, iteration.queue.buildbot.apiTestResultsURLForIteration(iteration));
     253        }
     254
     255        if (platformAPITestResults.failureCount) {
     256            var message = platformAPITestResults.failureCount + "\u00a0" + (platformAPITestResults.failureCount === 1 ? "platform api test failure" : "platform api test failures");
     257            addResultKind(message, iteration.queue.buildbot.platformAPITestResultsURLForIteration(iteration));
    248258        }
    249259

  • trunk/Tools/ChangeLog

    r161360 r161363  
     12014-01-06  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Gtk and Efl API test results confuse the dashboard
     4        https://bugs.webkit.org/show_bug.cgi?id=126535
     5
     6        Reviewed by Tim Horton.
     7
     8        Added "API tests" step as "platform api tests".
     9
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
     11        (Buildbot.prototype.platformAPITestResultsURLForIteration):
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
     13        (BuildbotIteration):
     14        (BuildbotIteration.prototype.update):
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
     16        (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
     17        (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
     18
    1192014-01-06  Tim Horton  <timothy_horton@apple.com>
    220
Note: See TracChangeset for help on using the changeset viewer.