Changeset 161566 in webkit


Ignore:
Timestamp:
Jan 9, 2014, 11:38:41 AM (12 years ago)
Author:
mitz@apple.com
Message:

[Cocoa] Promote WKBackForwardList{,Item}.h to public
​https://bugs.webkit.org/show_bug.cgi?id=126707

Reviewed by Sam Weinig.

Source/WebKit2:

  • UIProcess/API/Cocoa/WKBackForwardList.h: Stopped including the C API header.
  • UIProcess/API/Cocoa/WKBackForwardListItem.h: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Made the headers public.

Tools:

  • Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers

left behind in the build products directory after a private header is made public.

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r161561 r161566  
     12014-01-09  Dan Bernstein  <mitz@apple.com>
     2
     3        [Cocoa] Promote WKBackForwardList{,Item}.h to public
     4        https://bugs.webkit.org/show_bug.cgi?id=126707
     5
     6        Reviewed by Sam Weinig.
     7
     8        * UIProcess/API/Cocoa/WKBackForwardList.h: Stopped including the C API header.
     9        * UIProcess/API/Cocoa/WKBackForwardListItem.h: Ditto.
     10        * WebKit2.xcodeproj/project.pbxproj: Made the headers public.
     11
    1122014-01-09  Zan Dobersek  <zdobersek@igalia.com>
    213

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h

    r157951 r161566  
    2424 */
    2525
    26 #include <WebKit2/WKBackForwardListRef.h>
    27 
    28 #ifdef __OBJC__
    29 
    30 #import <WebKit2/WKBackForwardListItem.h>
    3126#import <WebKit2/WKFoundation.h>
    3227
    3328#if WK_API_ENABLED
     29
     30#import <WebKit2/WKBackForwardListItem.h>
    3431
    3532WK_API_CLASS
    … …  
    5148
    5249#endif // WK_API_ENABLED
    53 
    54 #endif // defined(__OBJC__)

  • trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListItem.h

    r159788 r161566  
    2424 */
    2525
    26 #include <WebKit2/WKBackForwardListItemRef.h>
    27 
    28 #ifdef __OBJC__
    29 
    3026#import <WebKit2/WKFoundation.h>
    3127
    … …  
    4440
    4541#endif // WK_API_ENABLED
    46 
    47 #endif // defined(__OBJC__)

  • trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj

    r161542 r161566  
    516516                37948409150C4B9700E52CE9 /* WKRenderLayer.h in Headers */ = {isa = PBXBuildFile; fileRef = 37948407150C4B9600E52CE9 /* WKRenderLayer.h */; settings = {ATTRIBUTES = (Private, ); }; };
    517517                37C4C08618149C5B003688B9 /* WKBackForwardListItem.mm in Sources */ = {isa = PBXBuildFile; fileRef = 37C4C08418149C5B003688B9 /* WKBackForwardListItem.mm */; };
    518                 37C4C08718149C5B003688B9 /* WKBackForwardListItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 37C4C08518149C5B003688B9 /* WKBackForwardListItem.h */; settings = {ATTRIBUTES = (Private, ); }; };
     518                37C4C08718149C5B003688B9 /* WKBackForwardListItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 37C4C08518149C5B003688B9 /* WKBackForwardListItem.h */; settings = {ATTRIBUTES = (Public, ); }; };
    519519                37C4C08918149F23003688B9 /* WKBackForwardListItemInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 37C4C08818149F23003688B9 /* WKBackForwardListItemInternal.h */; };
    520520                37C4C08C1814AC5C003688B9 /* WKBackForwardList.mm in Sources */ = {isa = PBXBuildFile; fileRef = 37C4C08A1814AC5C003688B9 /* WKBackForwardList.mm */; };
    521                 37C4C08D1814AC5C003688B9 /* WKBackForwardList.h in Headers */ = {isa = PBXBuildFile; fileRef = 37C4C08B1814AC5C003688B9 /* WKBackForwardList.h */; settings = {ATTRIBUTES = (Private, ); }; };
     521                37C4C08D1814AC5C003688B9 /* WKBackForwardList.h in Headers */ = {isa = PBXBuildFile; fileRef = 37C4C08B1814AC5C003688B9 /* WKBackForwardList.h */; settings = {ATTRIBUTES = (Public, ); }; };
    522522                37C4C0931814B3AF003688B9 /* WKNSArray.mm in Sources */ = {isa = PBXBuildFile; fileRef = 37C4C0911814B3AF003688B9 /* WKNSArray.mm */; };
    523523                37C4C0941814B3AF003688B9 /* WKNSArray.h in Headers */ = {isa = PBXBuildFile; fileRef = 37C4C0921814B3AF003688B9 /* WKNSArray.h */; };

  • trunk/Tools/ChangeLog

    r161555 r161566  
     12014-01-09  Dan Bernstein  <mitz@apple.com>
     2
     3        [Cocoa] Promote WKBackForwardList{,Item}.h to public
     4        https://bugs.webkit.org/show_bug.cgi?id=126707
     5
     6        Reviewed by Sam Weinig.
     7
     8        * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
     9        left behind in the build products directory after a private header is made public.
     10
    1112014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
    212

  • trunk/Tools/Scripts/check-for-webkit-framework-include-consistency

    r158458 r161566  
    4949      $HEADERS_BY_TYPE[:public] << header
    5050    elsif /\/PrivateHeaders\/(.*)/.match(header)
    51       $HEADER_NAMES_TO_TYPE[$1] = :private
     51      # If the same header exists both as a public header and as a private header, assume that it
     52      # has been promoted to public, and the private instance is stale.
     53      # FIXME: This can be improved by checking time stamps.
     54      $HEADER_NAMES_TO_TYPE[$1] = :private if !$HEADER_NAMES_TO_TYPE[$1]
    5255      $HEADERS_BY_TYPE[:private] << header
    5356    else
    … …  
    6669  return unless framework =~ /^Web/
    6770 
    68   # Ignore iOS headers that were mistakenly made Private on Mac builds in
    69   # http://trac.webkit.org/r158443. Even though this issue was resolved in
    70   # http://trac.webkit.org/r158454, stale copies might still exist in the build
    71   # directory.
    72   # FIXME: Remove this after some reasonable amount of time.
    73   return if ['MemoryMeasure.h', 'WebGeolocationCoreLocationProvider.h', 'WebGeolocationProviderIOS.h', 'WebNSStringDrawing.h', 'WebNSStringExtrasIOS.h', 'WebNSStringExtrasIPhone.h', 'WebUIKitSupport.h', 'WebCaretChangeListener.h', 'WebFixedPositionContent.h', 'WebFrameIOS.h', 'WebFrameIPhone.h', 'WebGeolocationPrivate.h', 'WebMIMETypeRegistry.h', 'WebSelectionRect.h', 'WebVisiblePosition.h', 'WebUIKitDelegate.h', 'WebPDFViewIOS.h', 'WebPDFViewIPhone.h', 'WebPDFViewPlaceholder.h'].include?(File.basename(header))
    74 
    7571  # A header of any type including a WebCore header is a recipe for disaster.
    7672  if framework == "WebCore"
Note: See TracChangeset for help on using the changeset viewer.