Changeset 162191 in webkit


Ignore:
Timestamp:
Jan 16, 2014, 11:59:58 PM (11 years ago)
Author:
ap@apple.com
Message:

Test results popovers at ​http://build.webkit.org/dashboard should link to stderr
​https://bugs.webkit.org/show_bug.cgi?id=126929

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
(Buildbot.prototype.layoutTestStderrURLForIteration): Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
Add a link to stderr output if present.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:

(.test-results-popover .additional-link): Style with light grey (will use the same style
for diff links).

Location:
trunk/Tools
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js

    r161363 r162191  
    102102    },
    103103
    104     layoutTestCrashLogForIteration: function(iteration, testPath)
     104    layoutTestCrashLogURLForIteration: function(iteration, testPath)
    105105    {
    106106        var crashLogPath = testPath.replace(/^(.*)\.(?:.*)$/, "$1-crash-log.txt");
    107107        return this.layoutTestResultsDirectoryURLForIteration(iteration) + "/" + crashLogPath;
     108    },
     109
     110    layoutTestStderrURLForIteration: function(iteration, testPath)
     111    {
     112        var crashLogPath = testPath.replace(/^(.*)\.(?:.*)$/, "$1-stderr.txt");
     113        return this.layoutTestResultsDirectoryURLForIteration(iteration) + "/" + crashLogPath;
    108114    }
    109115};

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js

    r161440 r162191  
    279279                        if (value.actual.contains("TIMEOUT"))
    280280                            item.timeout = true;
     281                        if (value.has_stderr)
     282                            item.has_stderr = true;
    281283                        result.push(item);
    282284                    }

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js

    r161454 r162191  
    168168                failureKindElement.className = "failure-kind-indicator"
    169169                failureKindElement.textContent = "crash";
    170                 failureKindElement.href = iteration.queue.buildbot.layoutTestCrashLogForIteration(iteration, test.path);
     170                failureKindElement.href = iteration.queue.buildbot.layoutTestCrashLogURLForIteration(iteration, test.path);
    171171                failureKindElement.target = "_blank";
    172172                rowElement.appendChild(failureKindElement);
    … …  
    178178                failureKindElement.textContent = "timeout";
    179179                rowElement.appendChild(failureKindElement);
     180            }
     181
     182            if (test.has_stderr) {
     183                var stderrElement = document.createElement("a");
     184                stderrElement.className = "additional-link"
     185                stderrElement.textContent = "stderr";
     186                stderrElement.href = iteration.queue.buildbot.layoutTestStderrURLForIteration(iteration, test.path);
     187                stderrElement.target = "_blank";
     188                rowElement.appendChild(stderrElement);
    180189            }
    181190

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css

    r161454 r162191  
    123123    padding: 0px 0px 0px 7px;
    124124}
     125
     126.test-results-popover .additional-link {
     127    color: rgb(145, 135, 95);
     128    padding: 0px 0px 0px 7px;
     129}

  • trunk/Tools/ChangeLog

    r162183 r162191  
     12014-01-16  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Test results popovers at http://build.webkit.org/dashboard should link to stderr
     4        https://bugs.webkit.org/show_bug.cgi?id=126929
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
     9        (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
     10        (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
     11
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
     13        (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
     14
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
     16        (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
     17        Add a link to stderr output if present.
     18
     19        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
     20        (.test-results-popover .additional-link): Style with light grey (will use the same style
     21        for diff links).
     22
    1232014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
    224
Note: See TracChangeset for help on using the changeset viewer.