Changeset 163247 in webkit


Ignore:
Timestamp:
Feb 1, 2014 12:29:23 PM (10 years ago)
Author:
mark.lam@apple.com
Message:

Saying "jitType() == JITCode::DFGJIT" is almost never correct.
<http://webkit.org/b/128045>

Reviewed by Filip Pizlo.

JITCode::isOptimizingJIT(jitType()) is the right way to say it.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::addBreakpoint):
(JSC::CodeBlock::setSteppingMode):

  • runtime/VM.cpp:

(JSC::SetEnabledProfilerFunctor::operator()):

Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r163241 r163247  
     12014-02-01  Mark Lam  <mark.lam@apple.com>
     2
     3        Saying "jitType() == JITCode::DFGJIT" is almost never correct.
     4        <http://webkit.org/b/128045>
     5
     6        Reviewed by Filip Pizlo.
     7
     8        JITCode::isOptimizingJIT(jitType()) is the right way to say it.
     9
     10        * bytecode/CodeBlock.cpp:
     11        (JSC::CodeBlock::addBreakpoint):
     12        (JSC::CodeBlock::setSteppingMode):
     13        * runtime/VM.cpp:
     14        (JSC::SetEnabledProfilerFunctor::operator()):
     15
    1162014-02-01  Michael Saboff  <msaboff@apple.com>
    217
  • trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

    r163241 r163247  
    35593559    m_numBreakpoints += numBreakpoints;
    35603560    ASSERT(m_numBreakpoints);
    3561     if (jitType() == JITCode::DFGJIT)
     3561    if (JITCode::isOptimizingJIT(jitType()))
    35623562        jettison();
    35633563}
     
    35663566{
    35673567    m_steppingMode = mode;
    3568     if (mode == SteppingModeEnabled && jitType() == JITCode::DFGJIT)
     3568    if (mode == SteppingModeEnabled && JITCode::isOptimizingJIT(jitType()))
    35693569        jettison();
    35703570}
  • trunk/Source/JavaScriptCore/runtime/VM.cpp

    r163225 r163247  
    836836    bool operator()(CodeBlock* codeBlock)
    837837    {
    838         if (codeBlock->jitType() == JITCode::DFGJIT)
     838        if (JITCode::isOptimizingJIT(codeBlock->jitType()))
    839839            codeBlock->jettison();
    840840        return false;
Note: See TracChangeset for help on using the changeset viewer.