Changeset 164145 in webkit


Ignore:
Timestamp:
Feb 14, 2014, 4:59:56 PM (11 years ago)
Author:
mitz@apple.com
Message:

REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
​https://bugs.webkit.org/show_bug.cgi?id=126295

Reviewed by Ryosuke Niwa.

Source/WebCore:

Reverted r157443 and improved comment.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isControlStyled):

LayoutTests:

Reverted r157443.

  • fast/forms/search/search-field-background-color-expected.txt: Removed.
  • fast/forms/search/search-field-background-color.html: Removed.
  • platform/efl/fast/forms/search: Removed.
  • platform/efl/fast/forms/search/search-field-background-color-expected.png: Removed.
  • platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Removed.
  • platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Removed.
  • platform/mac/fast/forms/search-styled-expected.txt:
Location:
trunk
Files:
3 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r164143 r164145  
     12014-02-14  Dan Bernstein  <mitz@apple.com>
     2
     3        REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
     4        https://bugs.webkit.org/show_bug.cgi?id=126295
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Reverted r157443.
     9
     10        * fast/forms/search/search-field-background-color-expected.txt: Removed.
     11        * fast/forms/search/search-field-background-color.html: Removed.
     12        * platform/efl/fast/forms/search: Removed.
     13        * platform/efl/fast/forms/search/search-field-background-color-expected.png: Removed.
     14        * platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Removed.
     15        * platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Removed.
     16        * platform/mac/fast/forms/search-styled-expected.txt:
     17
    1182014-02-14  Brent Fulgham  <bfulgham@apple.com>
    219

  • trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt

    r157443 r164145  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x41
    4   RenderBlock {HTML} at (0,0) size 800x41
    5     RenderBody {BODY} at (8,8) size 784x25
    6       RenderTextControl {INPUT} at (2,2) size 220x21 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
    7         RenderFlexibleBox {DIV} at (18,4) size 198x13
     3layer at (0,0) size 800x39
     4  RenderBlock {HTML} at (0,0) size 800x39
     5    RenderBody {BODY} at (8,8) size 784x23
     6      RenderTextControl {INPUT} at (2,2) size 158x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
     7        RenderFlexibleBox {DIV} at (3,3) size 152x13
    88          RenderBlock {DIV} at (0,1) size 22x11
    9           RenderBlock {DIV} at (22,0) size 163x13
    10           RenderBlock {DIV} at (185,1) size 13x11
     9          RenderBlock {DIV} at (22,0) size 117x13
     10          RenderBlock {DIV} at (139,1) size 13x11
    1111      RenderText {#text} at (0,0) size 0x0
    12 layer at (50,14) size 163x13
    13   RenderBlock {DIV} at (40,4) size 163x13 [color=#A9A9A9]
     12layer at (35,13) size 117x13
     13  RenderBlock {DIV} at (25,3) size 117x13 [color=#A9A9A9]
    1414    RenderText {#text} at (0,0) size 92x13
    1515      text run at (0,0) width 92: "Search for Events"
    16 layer at (50,14) size 163x13
    17   RenderBlock {DIV} at (0,0) size 163x13
     16layer at (35,13) size 117x13
     17  RenderBlock {DIV} at (0,0) size 117x13

  • trunk/Source/WebCore/ChangeLog

    r164144 r164145  
     12014-02-14  Dan Bernstein  <mitz@apple.com>
     2
     3        REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
     4        https://bugs.webkit.org/show_bug.cgi?id=126295
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Reverted r157443 and improved comment.
     9
     10        * rendering/RenderTheme.cpp:
     11        (WebCore::RenderTheme::isControlStyled):
     12
    1132014-02-14  Brian Burg  <bburg@apple.com>
    214

  • trunk/Source/WebCore/rendering/RenderTheme.cpp

    r163560 r164145  
    685685    case DiscreteCapacityLevelIndicatorPart:
    686686    case RatingLevelIndicatorPart:
    687     case SearchFieldPart:
     687    // FIXME: SearchFieldPart should be included here when making search fields style-able.
    688688    case TextFieldPart:
    689689    case TextAreaPart:
Note: See TracChangeset for help on using the changeset viewer.