Changeset 165719 in webkit

Timestamp:

Mar 16, 2014 11:15:51 PM (10 years ago)

Author:

akling@apple.com

Message:

REGRESSION(r165703): JSC tests crashing in StringImpl::destroy().
<​https://webkit.org/b/130304>

Reviewed by Anders Carlsson.

Unreviewed, restoring the old behavior of OpaqueJSString::identifier()
that doesn't put a potentially unwanted string into the Identifier table.

• API/OpaqueJSString.cpp:

(OpaqueJSString::identifier):

Location:

trunk/Source/JavaScriptCore

Files:

• API/OpaqueJSString.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

@@ -72 +72 @@
         return Identifier(Identifier::EmptyIdentifier);
 
-    return Identifier(vm, m_string);
+    if (m_string.is8Bit())
+        return Identifier(vm, m_string.characters8(), m_string.length());
+
+    return Identifier(vm, m_string.characters16(), m_string.length());
 }
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-03-16  Andreas Kling  <akling@apple.com>
+
+        REGRESSION(r165703): JSC tests crashing in StringImpl::destroy().
+        <https://webkit.org/b/130304>
+
+        Reviewed by Anders Carlsson.
+
+        Unreviewed, restoring the old behavior of OpaqueJSString::identifier()
+        that doesn't put a potentially unwanted string into the Identifier table.
+
+        * API/OpaqueJSString.cpp:
+        (OpaqueJSString::identifier):
+
 2014-03-16  Brian Burg  <bburg@apple.com>