Changeset 166105 in webkit

Timestamp:

Mar 21, 2014, 3:58:31 PM (11 years ago)

Author:

ap@apple.com

Message:

REGRESSION (r165356): Predictive Chinese input is broken
​https://bugs.webkit.org/show_bug.cgi?id=130619

Reviewed by Enrica Casucci.

• UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::executeKeypressCommands):

Like after insertText, we are no longer in an intermediate state after executeKeypressCommands.
Make sure that we don't call -discardMarkedText the next time we get a non-intermediate
state with closed composition.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/WebPageProxyMac.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-03-21  Alexey Proskuryakov  <ap@apple.com>
+
+        REGRESSION (r165356): Predictive Chinese input is broken
+        https://bugs.webkit.org/show_bug.cgi?id=130619
+
+        Reviewed by Enrica Casucci.
+
+        * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::executeKeypressCommands):
+        Like after insertText, we are no longer in an intermediate state after executeKeypressCommands.
+        Make sure that we don't call -discardMarkedText the next time we get a non-intermediate
+        state with closed composition.
+
 2014-03-21  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm

@@ -271 +271 @@
     bool result = false;
     process().sendSync(Messages::WebPage::ExecuteKeypressCommands(commands), Messages::WebPage::ExecuteKeypressCommands::Reply(result, m_editorState), m_pageID);
+    m_temporarilyClosedComposition = false;
     return result;
 }