Changeset 166946 in webkit

Timestamp:

Apr 8, 2014, 12:42:08 PM (11 years ago)

Author:

ap@apple.com

Message:

FlagsChanged events are not delivered to input methods when using async text input
​https://bugs.webkit.org/show_bug.cgi?id=131383

Reviewed by Anders Carlsson.

• UIProcess/API/mac/WKView.mm: (-[WKView _interpretKeyEvent:completionHandler:]):

The early return is no longer needed.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/WKView.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-04-08  Alexey Proskuryakov  <ap@apple.com>
+
+        FlagsChanged events are not delivered to input methods when using async text input
+        https://bugs.webkit.org/show_bug.cgi?id=131383
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/mac/WKView.mm: (-[WKView _interpretKeyEvent:completionHandler:]):
+        The early return is no longer needed.
+
 2014-04-08  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

@@ -1350 +1350 @@
     }
 
-    // FIXME: Remove the special case for NSFlagsChanged once <rdar://16393434> is fixed.
-    if ([event type] == NSFlagsChanged)
-        return;
-
     LOG(TextInput, "-> handleEventByInputMethod:%p %@", event, event);
     [[self inputContext] handleEventByInputMethod:event completionHandler:^(BOOL handled) {