Changeset 167113 in webkit

Timestamp:

Apr 10, 2014 10:23:42 PM (10 years ago)

Author:

mitz@apple.com

Message:

BundlePageDiagnosticLoggingClient leaks every string passing through it.
​https://bugs.webkit.org/show_bug.cgi?id=130140

Reviewed by Brent Fulgham.

• WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:

(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage): Don’t copy the
strings passed into the bundle client.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-04-10  Dan Bernstein  <mitz@apple.com>
+
+        BundlePageDiagnosticLoggingClient leaks every string passing through it.
+        https://bugs.webkit.org/show_bug.cgi?id=130140
+
+        Reviewed by Brent Fulgham.
+
+        * WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
+        (WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage): Don’t copy the
+        strings passed into the bundle client.
+
 2014-04-10  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp

@@ -36 +36 @@
     if (!m_client.logDiagnosticMessage)
         return;
-    m_client.logDiagnosticMessage(toAPI(page), toCopiedAPI(message), toCopiedAPI(description), toCopiedAPI(success), m_client.base.clientInfo);
+    m_client.logDiagnosticMessage(toAPI(page), toAPI(message.impl()), toAPI(description.impl()), toAPI(success.impl()), m_client.base.clientInfo);
 }