Changeset 167537 in webkit

Timestamp:

Apr 19, 2014 10:46:07 AM (10 years ago)

Author:

mitz@apple.com

Message:

[Cocoa] Crash in -[WKWebProcessPlugInHitTestResult nodeHandle] when nodeHandle() is null
​https://bugs.webkit.org/show_bug.cgi?id=131888

Reviewed by Jon Honeycutt.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm:

(-[WKWebProcessPlugInHitTestResult nodeHandle]): Added a null check.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-04-19  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] Crash in -[WKWebProcessPlugInHitTestResult nodeHandle] when nodeHandle() is null
+        https://bugs.webkit.org/show_bug.cgi?id=131888
+
+        Reviewed by Jon Honeycutt.
+
+        * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm:
+        (-[WKWebProcessPlugInHitTestResult nodeHandle]): Added a null check.
+
 2014-04-19  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm

@@ -46 +46 @@
 {
     RefPtr<InjectedBundleNodeHandle> nodeHandle = _hitTestResult->nodeHandle();
-    return [wrapper(*nodeHandle.release().leakRef()) autorelease];
+    return nodeHandle ? [wrapper(*nodeHandle.release().leakRef()) autorelease] : nil;
 }