Changeset 167643 in webkit

Timestamp:

Apr 21, 2014 6:56:04 PM (10 years ago)

Author:

Martin Robinson

Message:

[GTK] Should have the ability to output composited contents during layout testing
​https://bugs.webkit.org/show_bug.cgi?id=131864

Reviewed by Philippe Normand.

• WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.

• WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/cairo/TestInvocationCairo.cpp (modified) (1 diff)
• WebKitTestRunner/gtk/PlatformWebViewGtk.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-04-21  Martin Robinson  <mrobinson@igalia.com>
+
+        [GTK] Should have the ability to output composited contents during layout testing
+        https://bugs.webkit.org/show_bug.cgi?id=131864
+
+        Reviewed by Philippe Normand.
+
+        * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
+        (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
+        to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
+        * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+        (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
+
 2014-04-21  Sam Weinig  <sam@webkit.org>
 

trunk/Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp

@@ -109 +109 @@
 void TestInvocation::dumpPixelsAndCompareWithExpected(WKImageRef wkImage, WKArrayRef repaintRects)
 {
-#if PLATFORM(EFL)
+#if PLATFORM(EFL) || PLATFORM(GTK)
     UNUSED_PARAM(wkImage);
     cairo_surface_t* surface = WKImageCreateCairoSurface(TestController::shared().mainWebView()->windowSnapshotImage().get());

trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp

@@ -29 +29 @@
 #include "PlatformWebView.h"
 
+#include <WebKit2/WKImageCairo.h>
 #include <WebKit2/WKViewPrivate.h>
 #include <gtk/gtk.h>
@@ -121 +122 @@
 WKRetainPtr<WKImageRef> PlatformWebView::windowSnapshotImage()
 {
-    // FIXME: implement to capture pixels in the UI process,
-    // which may be necessary to capture things like 3D transforms.
-    return 0;
+    int width = gtk_widget_get_allocated_width(GTK_WIDGET(m_view));
+    int height = gtk_widget_get_allocated_height(GTK_WIDGET(m_view));
+
+    while (gtk_events_pending())
+        gtk_main_iteration();
+
+    cairo_surface_t* imageSurface = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, width, height);
+
+    cairo_t* context = cairo_create(imageSurface);
+    gtk_widget_draw(GTK_WIDGET(m_view), context);
+    cairo_destroy(context);
+
+    WKRetainPtr<WKImageRef> wkImage = adoptWK(WKImageCreateFromCairoSurface(imageSurface, 0 /* options */));
+
+    cairo_surface_destroy(imageSurface);
+    return wkImage;
 }