Changeset 167676 in webkit


Ignore:
Timestamp:
Apr 22, 2014 12:58:24 PM (10 years ago)
Author:
mark.lam@apple.com
Message:

WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript() needs to acquire the JSLock before calling into JS.
<https://webkit.org/b/132021>

Reviewed by Mark Hahnenberg.

Covered by existing layout test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r167675 r167676  
     12014-04-22  Mark Lam  <mark.lam@apple.com>
     2
     3        WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript() needs to acquire the JSLock before calling into JS.
     4        <https://webkit.org/b/132021>
     5
     6        Reviewed by Mark Hahnenberg.
     7
     8        Covered by existing layout test.
     9
     10        * html/HTMLMediaElement.cpp:
     11        (WebCore::HTMLMediaElement::parseAttribute):
     12
    1132014-04-22  Manuel Rego Casasnovas  <rego@igalia.com>
    214
  • trunk/Source/WebCore/html/HTMLMediaElement.cpp

    r167632 r167676  
    59365936    JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(scriptController.globalObject(world));
    59375937    JSC::ExecState* exec = globalObject->globalExec();
     5938    JSC::JSLockHolder lock(exec);
    59385939
    59395940    JSC::JSValue functionValue = globalObject->get(exec, JSC::Identifier(exec, "createControls"));
Note: See TracChangeset for help on using the changeset viewer.