Changeset 168573 in webkit

Timestamp:

May 9, 2014 11:48:51 PM (10 years ago)

Author:

mitz@apple.com

Message:

[Cocoa] Remove a deprecated bundle form delegate method now that no one implements it
​https://bugs.webkit.org/show_bug.cgi?id=132769

Reviewed by Sam Weinig.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-05-09  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] Remove a deprecated bundle form delegate method now that no one implements it
+        https://bugs.webkit.org/show_bug.cgi?id=132769
+
+        Reviewed by Sam Weinig.
+
+        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
+        (-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
+
 2014-05-09  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm

@@ -61 +61 @@
 using namespace WebKit;
 
-@protocol WKWebProcessPlugInFormDelegatePrivateDeprecated <NSObject>
-- (NSObject <NSSecureCoding> *)_webProcessPlugInBrowserContextController:(WKWebProcessPlugInBrowserContextController *)controller newWillSubmitForm:(WKWebProcessPlugInNodeHandle *)form toFrame:(WKWebProcessPlugInFrame *)frame fromFrame:(WKWebProcessPlugInFrame *)sourceFrame withValues:(NSDictionary *)values;
-@end
-
 @implementation WKWebProcessPlugInBrowserContextController {
     API::ObjectStorage<WebPage> _page;
@@ -435 +431 @@
             auto formDelegate = m_controller->_formDelegate.get();
 
-            if ([formDelegate respondsToSelector:@selector(_webProcessPlugInBrowserContextController:newWillSubmitForm:toFrame:fromFrame:withValues:)]) {
-                auto valueMap = adoptNS([[NSMutableDictionary alloc] initWithCapacity:values.size()]);
-                for (const auto& pair : values)
-                    [valueMap setObject:pair.second forKey:pair.first];
-
-                NSObject <NSSecureCoding> *userObject = [(id)formDelegate _webProcessPlugInBrowserContextController:m_controller newWillSubmitForm:wrapper(*InjectedBundleNodeHandle::getOrCreate(formElement).get()) toFrame:wrapper(*frame) fromFrame:wrapper(*sourceFrame) withValues:valueMap.get()];
-                encodeUserObject(userObject, userData);
-            } else if ([formDelegate respondsToSelector:@selector(_webProcessPlugInBrowserContextController:willSubmitForm:toFrame:fromFrame:withValues:)]) {
+            if ([formDelegate respondsToSelector:@selector(_webProcessPlugInBrowserContextController:willSubmitForm:toFrame:fromFrame:withValues:)]) {
                 auto valueMap = adoptNS([[NSMutableDictionary alloc] initWithCapacity:values.size()]);
                 for (const auto& pair : values)