Changeset 169427 in webkit

Timestamp:

May 28, 2014, 11:31:28 AM (11 years ago)

Author:

Chris Fleizach

Message:

AX: WebKit does not recognize ARIA 1.1 tables
​https://bugs.webkit.org/show_bug.cgi?id=133163

Reviewed by Darin Adler.

The AXObjectCache code that determines which object to create based on the role needs to be token fallback aware.

Test: accessibility/table-fallback-roles-expose-element-attributes.html

• accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

Location:

trunk

Files:

• LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt (added)
• LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AXObjectCache.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-27  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: WebKit does not recognize ARIA 1.1 tables
+        https://bugs.webkit.org/show_bug.cgi?id=133163
+
+        Reviewed by Darin Adler.
+
+        The AXObjectCache code that determines which object to create based on the role needs to be token fallback aware.
+
+        Test: accessibility/table-fallback-roles-expose-element-attributes.html
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::nodeHasRole):
+
 2014-05-28  Radu Stavila  <stavila@adobe.com>
 

trunk/Source/WebCore/accessibility/AXObjectCache.cpp

@@ -255 +255 @@
         return false;
 
-    return equalIgnoringCase(toElement(node)->fastGetAttribute(roleAttr), role);
+    auto& roleValue = toElement(node)->fastGetAttribute(roleAttr);
+    if (role.isNull())
+        return roleValue.isEmpty();
+    if (roleValue.isEmpty())
+        return false;
+
+    return SpaceSplitString(roleValue, true).contains(role);
 }