Changeset 169689 in webkit


Ignore:
Timestamp:
Jun 9, 2014 9:01:14 AM (10 years ago)
Author:
Alan Bujtas
Message:

[SVG] Subpixel rendering: Mask with transformed text does not render.
https://bugs.webkit.org/show_bug.cgi?id=133626
<rdar://problem/17123070>

Reviewed by Simon Fraser.

Replace IntRect::infiniteRect() with Layout::infiniteRect(). A transformed IntRect::infiniteRect()
overflows and produces invalid repaint rect. -also remove IntRect::infiniteRect() as no one calls
it anymore.

Source/WebCore:
Tests: svg/masking/mask-transformed-text-missing-expected.svg

svg/masking/mask-transformed-text-missing.svg

  • platform/graphics/IntRect.h:

(WebCore::IntRect::infiniteRect): Deleted.

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):

LayoutTests:

  • svg/masking/mask-transformed-text-missing-expected.svg: Added.
  • svg/masking/mask-transformed-text-missing.svg: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r169687 r169689  
     12014-06-09  Zalan Bujtas  <zalan@apple.com>
     2
     3        [SVG] Subpixel rendering: Mask with transformed text does not render.
     4        https://bugs.webkit.org/show_bug.cgi?id=133626
     5        <rdar://problem/17123070>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Replace IntRect::infiniteRect() with Layout::infiniteRect(). A transformed IntRect::infiniteRect()
     10        overflows and produces invalid repaint rect. -also remove IntRect::infiniteRect() as no one calls
     11        it anymore.
     12
     13        * svg/masking/mask-transformed-text-missing-expected.svg: Added.
     14        * svg/masking/mask-transformed-text-missing.svg: Added.
     15
    1162014-06-05  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
    217
  • trunk/Source/WebCore/ChangeLog

    r169685 r169689  
     12014-06-09  Zalan Bujtas  <zalan@apple.com>
     2
     3        [SVG] Subpixel rendering: Mask with transformed text does not render.
     4        https://bugs.webkit.org/show_bug.cgi?id=133626
     5        <rdar://problem/17123070>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Replace IntRect::infiniteRect() with Layout::infiniteRect(). A transformed IntRect::infiniteRect()
     10        overflows and produces invalid repaint rect. -also remove IntRect::infiniteRect() as no one calls
     11        it anymore.
     12
     13        Tests: svg/masking/mask-transformed-text-missing-expected.svg
     14               svg/masking/mask-transformed-text-missing.svg
     15
     16        * platform/graphics/IntRect.h:
     17        (WebCore::IntRect::infiniteRect): Deleted.
     18        * rendering/svg/SVGRenderingContext.cpp:
     19        (WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):
     20
    1212014-06-08  Dean Jackson  <dino@apple.com>
    222
  • trunk/Source/WebCore/platform/graphics/IntRect.h

    r166149 r169689  
    197197    void dump(WTF::PrintStream& out) const;
    198198
    199     static IntRect infiniteRect();
    200     bool isInfinite() const;
    201 
    202199private:
    203200    IntPoint m_location;
     
    229226}
    230227
    231 inline IntRect IntRect::infiniteRect()
    232 {
    233     static IntRect infiniteRect(-LayoutUnit::max() / 2, -LayoutUnit::max() / 2, LayoutUnit::max(), LayoutUnit::max());
    234     return infiniteRect;
    235 }
    236 
    237 inline bool IntRect::isInfinite() const
    238 {
    239     return *this == infiniteRect();
    240 }
    241 
    242228#if USE(CG)
    243229IntRect enclosingIntRect(const CGRect&);
  • trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp

    r169407 r169689  
    299299    ASSERT(image->context());
    300300
    301     PaintInfo info(image->context(), IntRect::infiniteRect(), PaintPhaseForeground, PaintBehaviorNormal);
     301    PaintInfo info(image->context(), LayoutRect::infiniteRect(), PaintPhaseForeground, PaintBehaviorNormal);
    302302
    303303    AffineTransform& contentTransformation = currentContentTransformation();
Note: See TracChangeset for help on using the changeset viewer.