Changeset 170018 in webkit

Timestamp:

Jun 16, 2014 12:00:35 PM (10 years ago)

Author:

mitz@apple.com

Message:

[Cocoa] Remove WKPreferences persistence in user defaults
​https://bugs.webkit.org/show_bug.cgi?id=133945

Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/WKPreferences.h: Removed userDefaultsKeyPrefix property and

initializer with userDefaultsKeyPrefix parameter.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]): Changed to initialize an instance with an empty identifier, which
means that it won’t persist to user defaults.
(-[WKPreferences initWithUserDefaultsKeyPrefix:]): Deleted.
(-[WKPreferences userDefaultsKeyPrefix]): Deleted.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKPreferences.h (modified) (1 diff)
• UIProcess/API/Cocoa/WKPreferences.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-06-16  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] Remove WKPreferences persistence in user defaults
+        https://bugs.webkit.org/show_bug.cgi?id=133945
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/Cocoa/WKPreferences.h: Removed userDefaultsKeyPrefix property and
+        initializer with userDefaultsKeyPrefix parameter.
+        * UIProcess/API/Cocoa/WKPreferences.mm:
+        (-[WKPreferences init]): Changed to initialize an instance with an empty identifier, which
+        means that it won’t persist to user defaults.
+        (-[WKPreferences initWithUserDefaultsKeyPrefix:]): Deleted.
+        (-[WKPreferences userDefaultsKeyPrefix]): Deleted.
+
 2014-06-16  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h

@@ -38 +38 @@
 @interface WKPreferences : NSObject
 
-/*! @abstract Returns an initialized preferences object.
- @param userDefaultsKeyPrefix The user defaults key prefix.
- @result An initialized preferences object.
- @discussion If the userDefaultsKeyPrefix parameter is not nil, it is
- prepended to the keys used to store preferences in the user defaults
- database. If the parameter is nil, the preferences object will not save
- anything to the user defaults database.
- */
-- (instancetype)initWithUserDefaultsKeyPrefix:(NSString *)userDefaultsKeyPrefix WK_DESIGNATED_INITIALIZER;
-
-/*! @abstract The user defaults key prefix.
- */
-@property (nonatomic, readonly) NSString *userDefaultsKeyPrefix;
-
 /*! @abstract The minimum font size in points.
  @discussion The default value is 0.

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm

@@ -33 +33 @@
 
 @implementation WKPreferences
-{
-    RetainPtr<NSString> _userDefaultsKeyPrefix;
-}
 
 - (instancetype)init
-{
-    return [self initWithUserDefaultsKeyPrefix:nil];
-}
-
-- (instancetype)initWithUserDefaultsKeyPrefix:(NSString *)userDefaultsKeyPrefix
 {
     if (!(self = [super init]))
         return nil;
 
-    _userDefaultsKeyPrefix = adoptNS([userDefaultsKeyPrefix copy]);
-
-    _preferences = WebKit::WebPreferences::create(_userDefaultsKeyPrefix.get(), "WebKit");
+    _preferences = WebKit::WebPreferences::create("WebKit", String());
     return self;
-}
-
-- (NSString *)userDefaultsKeyPrefix
-{
-    return _userDefaultsKeyPrefix.get();
 }