Changeset 171050 in webkit

Timestamp:

Jul 13, 2014 10:09:13 AM (10 years ago)

Author:

mitz@apple.com

Message:

[Cocoa] Clean up session state API a little
​https://bugs.webkit.org/show_bug.cgi?id=134871

Reviewed by Darin Adler.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _sessionState]):
(-[WKWebView _restoreFromSessionState:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (2 diffs)
• UIProcess/API/Cocoa/WKWebViewPrivate.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-07-13  Dan Bernstein  <mitz@apple.com>
+
+        [Cocoa] Clean up session state API a little
+        https://bugs.webkit.org/show_bug.cgi?id=134871
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _sessionState]):
+        (-[WKWebView _restoreFromSessionState:]): Deleted.
+        * UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
 2014-07-13  Javier Fernandez  <jfernandez@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

@@ -1635 +1635 @@
 }
 
-// FIXME: This should return a _WKSessionState object.
-- (id)_sessionState
+- (_WKSessionState *)_sessionState
 {
     return adoptNS([[_WKSessionState alloc] _initWithSessionState:_page->sessionState()]).autorelease();
@@ -1652 +1651 @@
         _navigationState->createReloadNavigation(navigationID);
     }
-}
-
-// FIXME: Remove this once nobody is using it.
-- (void)_restoreFromSessionState:(id)sessionState
-{
-    [self _restoreSessionState:sessionState andNavigate:YES];
 }
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h

@@ -89 +89 @@
 - (void)_restoreFromSessionStateData:(NSData *)sessionStateData;
 
-// FIXME: This should return a _WKSessionState object, not an id.
-@property (nonatomic, readonly) id _sessionState;
+@property (nonatomic, readonly) _WKSessionState *_sessionState;
 - (WKNavigation *)_restoreSessionState:(_WKSessionState *)sessionState andNavigate:(BOOL)navigate;
-
-// FIXME: Remove this once nobody is using it.
-- (void)_restoreFromSessionState:(id)sessionState;
 
 @property (nonatomic, setter=_setAllowsRemoteInspection:) BOOL _allowsRemoteInspection;