Changeset 171280 in webkit

Timestamp:

Jul 20, 2014 9:48:35 AM (10 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/17739804> REGRESSION (r171057): Crash in WebPage::getPositionInformation()
​https://bugs.webkit.org/show_bug.cgi?id=135099

Reviewed by David Kilzer.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation): Added a null check.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-07-20  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/17739804> REGRESSION (r171057): Crash in WebPage::getPositionInformation()
+        https://bugs.webkit.org/show_bug.cgi?id=135099
+
+        Reviewed by David Kilzer.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::getPositionInformation): Added a null check.
+
 2014-07-19  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -1860 +1860 @@
             if (elementIsLinkOrImage) {
                 // Ensure that the image contains at most 600K pixels, so that it is not too big.
-                info.image = snapshotNode(*element, SnapshotOptionsShareable, 600 * 1024)->bitmap();
+                if (RefPtr<WebImage> snapshot = snapshotNode(*element, SnapshotOptionsShareable, 600 * 1024))
+                    info.image = snapshot->bitmap();
             }
             if (linkElement)