Changeset 171756 in webkit

Timestamp:

Jul 29, 2014 1:33:53 PM (10 years ago)

Author:

ap@apple.com

Message:

PPT: run-webkit-tests doesn't upload crash logs to bots
​https://bugs.webkit.org/show_bug.cgi?id=135391

Reviewed by Joseph Pecoraro.

• WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):

Not a fix to be proud of, but better than not having it work at all.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-07-29  Alexey Proskuryakov  <ap@apple.com>
+
+        PPT: run-webkit-tests doesn't upload crash logs to bots
+        https://bugs.webkit.org/show_bug.cgi?id=135391
+
+        Reviewed by Joseph Pecoraro.
+
+        * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
+        Not a fix to be proud of, but better than not having it work at all.
+
 2014-07-29  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -1275 +1275 @@
 #if PLATFORM(COCOA)
         pid_t pid = WKPageGetProcessIdentifier(m_mainWebView->page());
-        fprintf(stderr, "#CRASHED - WebProcess (pid %ld)\n", static_cast<long>(pid));
+        // FIXME: Find a way to not hardcode the process name.
+#if PLATFORM(IOS)
+        const char* processName = "com.apple.WebKit.WebContent";
+#elif PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1080
+        const char* processName = "com.apple.WebKit.WebContent.Development";
+#else
+        const char* processName = "WebProcess";
+#endif
+        fprintf(stderr, "#CRASHED - %s (pid %ld)\n", processName, static_cast<long>(pid));
 #else
         fputs("#CRASHED - WebProcess\n", stderr);