Changeset 171802 in webkit
- Timestamp:
- Jul 30, 2014 12:40:25 PM (10 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r171801 r171802 1 2014-07-30 Dan Bernstein <mitz@apple.com> 2 3 <rdar://problem/17199364> [Mac] Popup button arrows appear on the left, underlapping text, when the UI layout direction is right-to-left 4 https://bugs.webkit.org/show_bug.cgi?id=135426 5 6 Reviewed by Dean Jackson. 7 8 No test, because the UI layout direction in the test harness is always left-to-right. 9 10 * rendering/RenderThemeMac.mm: 11 (WebCore::RenderThemeMac::popupButton): Forced the user interface layout direction of the 12 NSPopUpButtonCell to left-to-right. Added a FIXME about how we could make this vary based on 13 the direction of the <select>, though that would require additional changes elsewhere. 14 1 15 2014-07-30 Dan Bernstein <mitz@apple.com> 2 16 -
trunk/Source/WebCore/rendering/RenderThemeMac.mm
r171615 r171802 1935 1935 [m_popupButton.get() setUsesItemFromMenu:NO]; 1936 1936 [m_popupButton.get() setFocusRingType:NSFocusRingTypeExterior]; 1937 // We don't want the app's UI layout direction to affect the appearance of popup buttons in 1938 // web content, which has its own layout direction. 1939 // FIXME: Make this depend on the directionality of the select element, once the rest of the 1940 // rendering code can account for the popup arrows appearing on the other side. 1941 [m_popupButton setUserInterfaceLayoutDirection:NSUserInterfaceLayoutDirectionLeftToRight]; 1937 1942 } 1938 1943
Note: See TracChangeset
for help on using the changeset viewer.