Changeset 171880 in webkit

Timestamp:

Jul 31, 2014 12:21:28 PM (10 years ago)

Author:

ap@apple.com

Message:

media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
​https://bugs.webkit.org/show_bug.cgi?id=135418

Reviewed by Anders Carlsson.

This was only happening in shared web process mode, because WKBundlePostMessage
has different behavior then. When there is no process, the message is dropped on
the floor in multiple process mode, but it's stored to be delivered after launch
in shared process mode.

So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
that was delivered immediately after launch, when there was nothing to reset.

We don't actually need to reset anything at this point, as the previous call has
already reset everything UI process side, and web process is brand new. All we need
is to reattach the page to a process, as invoke() expects one to exist.

• WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/TestController.cpp (modified) (1 diff)
• WebKitTestRunner/TestController.h (modified) (1 diff)
• WebKitTestRunner/TestInvocation.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-07-31  Alexey Proskuryakov  <ap@apple.com>
+
+        media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
+        on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
+        https://bugs.webkit.org/show_bug.cgi?id=135418
+
+        Reviewed by Anders Carlsson.
+
+        This was only happening in shared web process mode, because WKBundlePostMessage
+        has different behavior then. When there is no process, the message is dropped on
+        the floor in multiple process mode, but it's stored to be delivered after launch
+        in shared process mode.
+
+        So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
+        that was delivered immediately after launch, when there was nothing to reset.
+
+        We don't actually need to reset anything at this point, as the previous call has
+        already reset everything UI process side, and web process is brand new. All we need
+        is to reattach the page to a process, as invoke() expects one to exist.
+
+        * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
+        * WebKitTestRunner/TestController.h:
+        * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
+
 2014-07-31  Dan Bernstein  <mitz@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -664 +664 @@
 }
 
+void TestController::reattachPageToWebProcess()
+{
+    // Loading a web page is the only way to reattach an existing page to a process.
+    m_doneResetting = false;
+    WKPageLoadURL(m_mainWebView->page(), blankURL());
+    runUntil(m_doneResetting, LongTimeout);
+}
+
 void TestController::updateWebViewSizeForTest(const TestInvocation& test)
 {

trunk/Tools/WebKitTestRunner/TestController.h

@@ -99 +99 @@
 
     void terminateWebContentProcess();
+    void reattachPageToWebProcess();
 
     WorkQueueManager& workQueueManager() { return m_workQueueManager; }

trunk/Tools/WebKitTestRunner/TestInvocation.cpp

@@ -206 +206 @@
         // It would be nice to report that the previous test froze after dumping results, but we have no way to do that.
         TestController::shared().terminateWebContentProcess();
-        TestController::shared().resetStateToConsistentValues();
+        // Make sure that we have a process, as invoke() will need one to send bundle messages for the next test.
+        TestController::shared().reattachPageToWebProcess();
     }
 }