Changeset 171966 in webkit

Timestamp:

Aug 2, 2014 10:34:34 AM (10 years ago)

Author:

mitz@apple.com

Message:

prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
​https://bugs.webkit.org/show_bug.cgi?id=135542

Reviewed by Tim Horton.

• Scripts/prepare-ChangeLog:

(main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
findChangeLogs.
(findChangeLogs): Don’t require a ChangeLog file to exist if unless the
requireChangeLogToExist argument is true.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/prepare-ChangeLog (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-08-02  Dan Bernstein  <mitz@apple.com>
+
+        prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
+        https://bugs.webkit.org/show_bug.cgi?id=135542
+
+        Reviewed by Tim Horton.
+
+        * Scripts/prepare-ChangeLog:
+        (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
+        findChangeLogs.
+        (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
+        requireChangeLogToExist argument is true.
+
 2014-08-01  Dan Bernstein  <mitz@apple.com>
 

trunk/Tools/Scripts/prepare-ChangeLog

@@ -76 +76 @@
 sub extractLineRangeBeforeChange($);
 sub fetchBugDescriptionFromURL($$);
-sub findChangeLogs($);
+sub findChangeLogs($$);
 sub findOriginalFileFromSvn($);
 sub generateFileList(\%$$$);
@@ -217 +217 @@
     }
 
-    my ($filesInChangeLog, $prefixes) = findChangeLogs($functionLists);
+    my ($filesInChangeLog, $prefixes) = findChangeLogs($functionLists, $writeChangeLogs);
 
     # Get the latest ChangeLog files from svn.
@@ -437 +437 @@
 }
 
-sub findChangeLogs($)
-{
-    my ($functionLists) = @_;
+sub findChangeLogs($$)
+{
+    my ($functionLists, $requireChangeLogToExist) = @_;
 
     # Find the change logs.
@@ -456 +456 @@
             last if $has_log;
         }
-        if (!$has_log) {
+        if (!$has_log && $requireChangeLogToExist) {
             print STDERR "No ChangeLog found for $file.\n";
         } else {