Changeset 174114 in webkit

Timestamp:

Sep 30, 2014 12:43:58 PM (10 years ago)

Author:

ap@apple.com

Message:

EWS doesn't need to show all the bubbles when a patch fails to apply
​https://bugs.webkit.org/show_bug.cgi?id=137256

Reviewed by Ryosuke Niwa.

• QueueStatusServer/app.yaml: Updated app version.

• QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._build_bubbles_for_attachment):
(StatusBubble.get):

• QueueStatusServer/templates/statusbubble.html:

When some queues fail to apply, and no queues had meaningful output (meaning that
they will almost certainly fail to apply later), we can show a single bubble
telling the user just that.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/app.yaml (modified) (1 diff)
• QueueStatusServer/handlers/statusbubble.py (modified) (6 diffs)
• QueueStatusServer/templates/statusbubble.html (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-09-30  Alexey Proskuryakov  <ap@apple.com>
+
+        EWS doesn't need to show all the bubbles when a patch fails to apply
+        https://bugs.webkit.org/show_bug.cgi?id=137256
+
+        Reviewed by Ryosuke Niwa.
+
+        * QueueStatusServer/app.yaml: Updated app version.
+
+        * QueueStatusServer/handlers/statusbubble.py:
+        (StatusBubble._build_bubble):
+        (StatusBubble._build_bubbles_for_attachment):
+        (StatusBubble.get):
+        * QueueStatusServer/templates/statusbubble.html:
+        When some queues fail to apply, and no queues had meaningful output (meaning that
+        they will almost certainly fail to apply later), we can show a single bubble
+        telling the user just that.
+
 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
 

trunk/Tools/QueueStatusServer/app.yaml

@@ -1 +1 @@
 application: webkit-queues
-version: 174192 # Bugzilla bug ID of last major change
+version: 174114 # Bugzilla bug ID of last major change
 runtime: python
 api_version: 1

trunk/Tools/QueueStatusServer/handlers/statusbubble.py

@@ -119 +119 @@
                 bubble["state"] = "started"
                 bubble["details_message"] = "Started processing, no output yet.\n\n" + self._iso_time(queue.active_work_items().time_for_item(attachment.id))
+                bubble["may_fail_to_apply"] = True
             else:
                 real_queue_position = self._real_queue_position(queue, queue_position)
@@ -124 +125 @@
                 bubble["details_message"] = "Waiting in queue, processing has not started yet.\n\nPosition in queue: " + str(real_queue_position)
                 bubble["queue_position"] = real_queue_position
+                bubble["may_fail_to_apply"] = True
         else:
             latest_resultative_status = self._latest_resultative_status(statuses)
@@ -145 +147 @@
                         bubble["details_message"] += " Some messages were logged while the patch was still eligible:\n\n"
                     bubble["details_message"] += "\n".join([status.message for status in statuses[1:]]) + "\n\n" + self._iso_time(statuses[0].date)
+                bubble["may_fail_to_apply"] = True
             elif statuses[0].message == "Error: " + queue.name() + " unable to apply patch.":
                 bubble["state"] = "fail"
                 bubble["details_message"] = statuses[1].message + "\n\n" + self._iso_time(statuses[0].date)
+                bubble["failed_to_apply"] = True
             elif statuses[0].message.startswith("Error: "):
                 bubble["state"] = "error"
@@ -158 +162 @@
                 bubble["details_message"] = ("Internal error. Latest status implies that the patch should be in queue, but it is not. Recent messages:\n\n"
                     + "\n".join([status.message for status in statuses]) + "\n\n" + self._iso_time(statuses[0].date))
+            bubble["may_fail_to_apply"] = True
 
         if "details_message" in bubble:
@@ -185 +190 @@
                 show_submit_to_ews = False
 
-        return (bubbles, show_submit_to_ews)
+        failed_to_apply = any(map(lambda bubble: "failed_to_apply" in bubble, bubbles))
+        had_output = all(map(lambda bubble: not "may_fail_to_apply" in bubble and not "failed_to_apply" in bubble, bubbles))
+
+        return (bubbles, show_submit_to_ews, failed_to_apply and (not had_output) and (not show_submit_to_ews))
 
     def get(self, attachment_id_string):
         attachment_id = int(attachment_id_string)
         attachment = Attachment(attachment_id)
-        bubbles, show_submit_to_ews = self._build_bubbles_for_attachment(attachment)
+        bubbles, show_submit_to_ews, show_failure_to_apply = self._build_bubbles_for_attachment(attachment)
 
         template_values = {
@@ -196 +204 @@
             "attachment_id": attachment_id,
             "show_submit_to_ews": show_submit_to_ews,
+            "show_failure_to_apply": show_failure_to_apply,
         }
         self.response.out.write(template.render("templates/statusbubble.html", template_values))

trunk/Tools/QueueStatusServer/templates/statusbubble.html

@@ -64 +64 @@
 <body>
 <div id="bubbleContainer">
+  {% if show_failure_to_apply %}
+  <a class="status fail" target="_top"
+      href="/patch/{{ attachment_id }}"
+      title="None of the queues could apply the patch"
+  >
+    patch does not apply to trunk of repository
+  </a>
+  {% else %}
   {% for bubble in bubbles %}
   <a class="status {{ bubble.state }}" target="_top"
@@ -77 +85 @@
   </a>
   {% endfor %}
+  {% endif %}
 
 {% if show_submit_to_ews %}