Changeset 174115 in webkit


Ignore:
Timestamp:
Sep 30, 2014, 12:48:09 PM (11 years ago)
Author:
ap@apple.com
Message:

build.webkit.org/dashboard: Switch EWS view to using actual retry count
​https://bugs.webkit.org/show_bug.cgi?id=137240

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:

(EWSQueue.prototype.loadDetailedStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:

(EWSQueueView.prototype._popoverContentForEWSQueue):
Use the new retry_count data member from JSON.

  • QueueStatusServer/app.yaml: Updating the version.
  • QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):

Instead of message_count, produce retry_count.

Location:
trunk/Tools
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js

    r173050 r174115  
    106106                    latestMessageTime: patch.latest_message_time ? new Date(patch.latest_message_time) : null,
    107107                    detailedResultsURLForLatestMessage: patch.latest_results,
    108                     messageCount: patch.message_count,
     108                    retryCount: patch.retry_count,
    109109                    active: patch.active,
    110110                    activeSince: new Date(activeSinceTime),

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js

    r173048 r174115  
    155155            this.addLinkToRow(rowElement, "patch-details-link", patch.attachmentID, patch.statusPageURL);
    156156
    157             if (patch.messageCount)
    158                 this.addTextToRow(rowElement, "failure-count", patch.messageCount + "\xa0" + (patch.messageCount === 1 ? "attempt" : "attempts"));
     157            if (patch.retryCount)
     158                this.addTextToRow(rowElement, "failure-count", patch.retryCount + "\xa0" + (patch.retryCount === 1 ? "attempt" : "attempts"));
    159159
    160160            if (patch.detailedResultsURLForLatestMessage)

  • trunk/Tools/ChangeLog

    r174114 r174115  
     12014-09-30  Alexey Proskuryakov  <ap@apple.com>
     2
     3        build.webkit.org/dashboard: Switch EWS view to using actual retry count
     4        https://bugs.webkit.org/show_bug.cgi?id=137240
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
     9        (EWSQueue.prototype.loadDetailedStatus):
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
     11        (EWSQueueView.prototype._popoverContentForEWSQueue):
     12        Use the new retry_count data member from JSON.
     13
     14        * QueueStatusServer/app.yaml: Updating the version.
     15
     16        * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
     17        Instead of message_count, produce retry_count.
     18
    1192014-09-30  Alexey Proskuryakov  <ap@apple.com>
    220

  • trunk/Tools/QueueStatusServer/app.yaml

    r174114 r174115  
    11application: webkit-queues
    2 version: 174114 # Bugzilla bug ID of last major change
     2version: 174115 # Bugzilla bug ID of last major change
    33runtime: python
    44api_version: 1

  • trunk/Tools/QueueStatusServer/handlers/queuestatusjson.py

    r162358 r174115  
    2727from google.appengine.ext.webapp import template
    2828
     29from model.patchlog import PatchLog
    2930from model.queues import Queue
    3031from model.queuestatus import QueueStatus
    … …  
    5859                results_url = self.request.host_url + "/results/" + str(statuses[0].key().id()) if statuses[0].results_file else None
    5960
    60             rows.append({
     61            row = {
    6162                "attachment_id": item_id,
    6263                "bug_id": bug_id,
    … …  
    6566                "latest_message": message,
    6667                "latest_message_time": message_time,
    67                 "message_count": patchStatusQuery.count(),
    6868                "status_page": self.request.host_url + "/patch/" + str(item_id),
    6969                "latest_results": results_url,
    70             })
     70            }
     71
     72            patch_log = PatchLog.lookup_if_exists(item_id, queue.name())
     73            if patch_log and patch_log.retry_count:
     74                row["retry_count"] = patch_log.retry_count
     75
     76            rows.append(row)
    7177        return rows
    7278

  • trunk/Tools/QueueStatusServer/templates/statusbubble.html

    r174114 r174115  
    3737}
    3838.started {
    39     background-color: #D8FFFA;
     39    background-color: #E1F5FF;
    4040}
    4141.provisional-fail {
Note: See TracChangeset for help on using the changeset viewer.