Changeset 174357 in webkit

Timestamp:

Oct 6, 2014 12:09:55 PM (10 years ago)

Author:

ap@apple.com

Message:

webkit-queues PatchLog is incorrect for patches that took less than a second
​https://bugs.webkit.org/show_bug.cgi?id=137453

Reviewed by Tim Horton.

• QueueStatusServer/app.yaml: Updated app version.

• QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):

Don't bail out for patches that took 0 seconds to process (as frequently happens
when a patch is obsolete).

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/app.yaml (modified) (1 diff)
• QueueStatusServer/loggers/recordpatchevent.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-10-06  Alexey Proskuryakov  <ap@apple.com>
+
+        webkit-queues PatchLog is incorrect for patches that took less than a second
+        https://bugs.webkit.org/show_bug.cgi?id=137453
+
+        Reviewed by Tim Horton.
+
+        * QueueStatusServer/app.yaml: Updated app version.
+
+        * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
+        Don't bail out for patches that took 0 seconds to process (as frequently happens
+        when a patch is obsolete).
+
 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Tools/QueueStatusServer/app.yaml

@@ -1 +1 @@
 application: webkit-queues
-version: 174304 # Bugzilla bug ID of last major change
+version: 174357 # SVN revision of last major change
 runtime: python
 api_version: 1

trunk/Tools/QueueStatusServer/loggers/recordpatchevent.py

@@ -76 +76 @@
             return
 
-        if not patch_log.wait_duration:
+        if patch_log.wait_duration is None:
             WarningLog.record("patchlog wait duration missing", "In stopped event.", attachment_id, queue_name, bot_id)
             return