Changeset 174655 in webkit

Timestamp:

Oct 13, 2014 11:46:30 AM (10 years ago)

Author:

ap@apple.com

Message:

Add more detailed wait time information to EWS metrics
​https://bugs.webkit.org/show_bug.cgi?id=137649

Reviewed by Daniel Bates.

Added average and worst time (we used to only have median), and also a percentage
of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.

There is always some wait due to the polling nature of the queues, which is well understood
and doesn't need to be measured. What needs to be measured is whether there is enough
bot machines to process patches as soon as they are submitted.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:

(Analyzer.prototype._analyzeBubblePerformance):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:

(MetricsBubbleView.prototype._update):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js (modified) (3 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js

@@ -394 +394 @@
 
         var waitTimes = [];
+        var patchesThatWaitedMoreThan3Minutes = [];
         var totalTimes = [];
         var totalTimesForPatchesThatWereNotRetried = [];
@@ -408 +409 @@
             // Wait time is equally interesting for all patches.
             waitTimes.push(patch.wait_duration);
+
+            if (patch.wait_duration > 3 * 60)
+                patchesThatWaitedMoreThan3Minutes.push(patchID);
 
             if (patch.resolution === "not processed")
@@ -450 +454 @@
             medianWaitTimeInSeconds: waitTimes.median(),
             averageWaitTimeInSeconds: waitTimes.average(),
+            maximumWaitTimeInSeconds: Math.max.apply(Math, waitTimes),
+            patchesThatWaitedMoreThan3MinutesCount: patchesThatWaitedMoreThan3Minutes.length,
             patchesThatCausedInternalError: patchesThatCausedInternalError,
         };

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js

@@ -163 +163 @@
 
         addDivider(this.element);
-        addLine(this.element, "Median wait time before processing started: " + pluralizeMinutes(this._results.medianWaitTimeInSeconds) + ".");
+        addLine(this.element, "Wait time before processing started:");
+        addLine(this.element, "- median: " + pluralizeMinutes(this._results.medianWaitTimeInSeconds) + ";");
+        addLine(this.element, "- average: " + pluralizeMinutes(this._results.averageWaitTimeInSeconds) + ".");
+        addLine(this.element, "- worst: " + pluralizeMinutes(this._results.maximumWaitTimeInSeconds) + ".");
+        if (this._results.medianWaitTimeInSeconds < 3 * 60 && this._results.patchesThatWaitedMoreThan3MinutesCount)
+            addLine(this.element, formatPercentage(this._results.patchesThatWaitedMoreThan3MinutesCount / this._results.totalPatches) + " of patches had a wait time of more than 3 minutes.");
 
         if (this._results.patchesThatCausedInternalError.length) {

trunk/Tools/ChangeLog

@@ +1 @@
+2014-10-13  Alexey Proskuryakov  <ap@apple.com>
+
+        Add more detailed wait time information to EWS metrics
+        https://bugs.webkit.org/show_bug.cgi?id=137649
+
+        Reviewed by Daniel Bates.
+
+        Added average and worst time (we used to only have median), and also a percentage
+        of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
+
+        There is always some wait due to the polling nature of the queues, which is well understood
+        and doesn't need to be measured. What needs to be measured is whether there is enough
+        bot machines to process patches as soon as they are submitted.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
+        (Analyzer.prototype._analyzeBubblePerformance):
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
+        (MetricsBubbleView.prototype._update):
+
 2014-10-11  Jer Noble  <jer.noble@apple.com>