Changeset 174864 in webkit

Timestamp:

Oct 18, 2014, 12:04:31 PM (11 years ago)

Author:

mitz@apple.com

Message:

WorkQueue dispatches functions but isn’t a FunctionDispatcher
​https://bugs.webkit.org/show_bug.cgi?id=137853

Reviewed by Anders Carlsson.

Source/WebKit2:

• Platform/WorkQueue.h: Changed to inherit from FunctionDispatcher.

Source/WTF:

• wtf/FunctionDispatcher.h: Added header guards.

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/FunctionDispatcher.h (modified) (2 diffs)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Platform/WorkQueue.h (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2014-10-18  Dan Bernstein  <mitz@apple.com>
+
+        WorkQueue dispatches functions but isn’t a FunctionDispatcher
+        https://bugs.webkit.org/show_bug.cgi?id=137853
+
+        Reviewed by Anders Carlsson.
+
+        * wtf/FunctionDispatcher.h: Added header guards.
+
 2014-10-17  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WTF/wtf/FunctionDispatcher.h

@@ -24 +24 @@
  */
 
+#ifndef FunctionDispatcher_h
+#define FunctionDispatcher_h
+
 #include <functional>
 #include <wtf/ThreadSafeRefCounted.h>
@@ -45 +48 @@
 
 using WTF::FunctionDispatcher;
+
+#endif // FunctionDispatcher_h

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-10-18  Dan Bernstein  <mitz@apple.com>
+
+        WorkQueue dispatches functions but isn’t a FunctionDispatcher
+        https://bugs.webkit.org/show_bug.cgi?id=137853
+
+        Reviewed by Anders Carlsson.
+
+        * Platform/WorkQueue.h: Changed to inherit from FunctionDispatcher.
+
 2014-10-18  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebKit2/Platform/WorkQueue.h

@@ -35 +35 @@
 #include <functional>
 #include <wtf/Forward.h>
+#include <wtf/FunctionDispatcher.h>
 #include <wtf/Functional.h>
 #include <wtf/HashMap.h>
@@ -52 +53 @@
 #endif
 
-class WorkQueue : public ThreadSafeRefCounted<WorkQueue> {
+class WorkQueue final : public FunctionDispatcher {
 public:
     enum class QOS {
@@ -63 +64 @@
     
     static PassRefPtr<WorkQueue> create(const char* name, QOS = QOS::Default);
-    ~WorkQueue();
+    virtual ~WorkQueue();
 
-    void dispatch(std::function<void ()>);
+    virtual void dispatch(std::function<void ()>) override;
     void dispatchAfter(std::chrono::nanoseconds, std::function<void ()>);