Changeset 175175 in webkit

Timestamp:

Oct 24, 2014 1:23:31 PM (10 years ago)

Author:

ap@apple.com

Message:

REGRESSION(r174877): WebProcess sends an empty Cookies HTTP header
​https://bugs.webkit.org/show_bug.cgi?id=138053

Reviewed by Chris Dumez.

Fixes existing tests.

• platform/network/mac/CookieJarMac.mm: (WebCore::cookiesForSession): Restore the

behavior of returning a null string when there are no cookies.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/mac/CookieJarMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-10-24  Alexey Proskuryakov  <ap@apple.com>
+
+        REGRESSION(r174877): WebProcess sends an empty Cookies HTTP header
+        https://bugs.webkit.org/show_bug.cgi?id=138053
+
+        Reviewed by Chris Dumez.
+
+        Fixes existing tests.
+
+        * platform/network/mac/CookieJarMac.mm: (WebCore::cookiesForSession): Restore the 
+        behavior of returning a null string when there are no cookies.
+
 2014-10-24  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/network/mac/CookieJarMac.mm

@@ -77 +77 @@
 
     NSArray *cookies = wkHTTPCookiesForURL(session.cookieStorage().get(), firstParty, url);
+    if (![cookies count])
+        return String(); // Return a null string, not an empty one that StringBuilder would create below.
+
     StringBuilder cookiesBuilder;
     for (NSHTTPCookie *cookie in cookies) {