Changeset 175488 in webkit

Timestamp:

Nov 3, 2014, 1:19:15 PM (11 years ago)

Author:

ap@apple.com

Message:

REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
​https://bugs.webkit.org/show_bug.cgi?id=138323

Reviewed by Zalan Bujtas.

• QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/app.yaml (modified) (1 diff)
• QueueStatusServer/templates/statusbubble.html (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-11-03  Alexey Proskuryakov  <ap@apple.com>
+
+        REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
+        https://bugs.webkit.org/show_bug.cgi?id=138323
+
+        Reviewed by Zalan Bujtas.
+
+        * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
+
 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
 

trunk/Tools/QueueStatusServer/app.yaml

@@ -1 +1 @@
 application: webkit-queues
-version: 174622 # SVN revision of last major change
+version: 175488 # SVN revision of last major change
 runtime: python
 api_version: 1

trunk/Tools/QueueStatusServer/templates/statusbubble.html

@@ -54 +54 @@
 <script>
 window.addEventListener("message", function(e) {
-  if (e.data == 'containerMetrics') {
-    e.source.postMessage({'width': bubbleContainer.offsetWidth, 'height': bubbleContainer.offsetHeight},
-        e.origin);
+  if (e.data === 'containerMetrics') {
+    var clientRect = bubbleContainer.getBoundingClientRect();
+    e.source.postMessage({'width': Math.ceil(clientRect.width), 'height': Math.ceil(clientRect.height)}, e.origin);
   } else
     console.log("Unknown postMessage: " + e.data);