Changeset 176104 in webkit

Timestamp:

Nov 13, 2014, 4:33:03 PM (10 years ago)

Author:

ap@apple.com

Message:

​https://bugs.webkit.org/show_bug.cgi?id=138628
A patch that doesn't apply is stuck in commit queue

Rubber-stamped by David Kilzer.

This also hopefully fixes other issues:

• a patch that has cq+ flag set by a non-committer kills commit queue;
• EWS never reports failing tests, and keeps spinning instead.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
Apply the fix from r174797 to more places.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla/bugzilla.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-11-13  Alexey Proskuryakov  <ap@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=138628
+        A patch that doesn't apply is stuck in commit queue
+
+        Rubber-stamped by David Kilzer.
+
+        This also hopefully fixes other issues:
+        - a patch that has cq+ flag set by a non-committer kills commit queue;
+        - EWS never reports failing tests, and keeps spinning instead.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        (Bugzilla.set_flag_on_attachment):
+        (Bugzilla.obsolete_attachment):
+        Apply the fix from r174797 to more places.
+
 2014-11-13  Dan Bernstein  <mitz@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py

@@ -772 +772 @@
 
         if comment_text:
-            self.browser.set_value(comment_text, name='comment', nr=0)
+            self.browser.set_value(comment_text, name='comment', nr=1)
 
         self._find_select_element_for_flag(flag_name).value = (flag_value,)
@@ -794 +794 @@
             # Bugzilla has two textareas named 'comment', one is somehow
             # hidden.  We want the first.
-            self.browser.set_value(comment_text, name='comment', nr=0)
+            self.browser.set_value(comment_text, name='comment', nr=1)
         self.browser.submit()