Changeset 176104 in webkit


Ignore:
Timestamp:
Nov 13, 2014 4:33:03 PM (9 years ago)
Author:
ap@apple.com
Message:

https://bugs.webkit.org/show_bug.cgi?id=138628
A patch that doesn't apply is stuck in commit queue

Rubber-stamped by David Kilzer.

This also hopefully fixes other issues:

  • a patch that has cq+ flag set by a non-committer kills commit queue;
  • EWS never reports failing tests, and keeps spinning instead.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
Apply the fix from r174797 to more places.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r176096 r176104  
     12014-11-13  Alexey Proskuryakov  <ap@apple.com>
     2
     3        https://bugs.webkit.org/show_bug.cgi?id=138628
     4        A patch that doesn't apply is stuck in commit queue
     5
     6        Rubber-stamped by David Kilzer.
     7
     8        This also hopefully fixes other issues:
     9        - a patch that has cq+ flag set by a non-committer kills commit queue;
     10        - EWS never reports failing tests, and keeps spinning instead.
     11
     12        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
     13        (Bugzilla.set_flag_on_attachment):
     14        (Bugzilla.obsolete_attachment):
     15        Apply the fix from r174797 to more places.
     16
    1172014-11-13  Dan Bernstein  <mitz@apple.com>
    218
  • trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py

    r174800 r176104  
    772772
    773773        if comment_text:
    774             self.browser.set_value(comment_text, name='comment', nr=0)
     774            self.browser.set_value(comment_text, name='comment', nr=1)
    775775
    776776        self._find_select_element_for_flag(flag_name).value = (flag_value,)
     
    794794            # Bugzilla has two textareas named 'comment', one is somehow
    795795            # hidden.  We want the first.
    796             self.browser.set_value(comment_text, name='comment', nr=0)
     796            self.browser.set_value(comment_text, name='comment', nr=1)
    797797        self.browser.submit()
    798798
Note: See TracChangeset for help on using the changeset viewer.