Changeset 176800 in webkit


Ignore:
Timestamp:
Dec 4, 2014, 9:18:14 AM (10 years ago)
Author:
ap@apple.com
Message:

http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
​https://bugs.webkit.org/show_bug.cgi?id=139243

Reviewed by Anders Carlsson.

We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
chance to allow untrusted certificates.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):

Set up more client objects for secondary windows. We may be able to share some of the
code with main view creation function, but it's not exactly the same (notably, we
do not focus a secondary window when it's done loading).

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r176731 r176800  
     12014-12-03  Alexey Proskuryakov  <ap@apple.com>
     2
     3        http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
     4        https://bugs.webkit.org/show_bug.cgi?id=139243
     5
     6        Reviewed by Anders Carlsson.
     7
     8        We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
     9        chance to allow untrusted certificates.
     10
     11        * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
     12        Set up more client objects for secondary windows. We may be able to share some of the
     13        code with main view creation function, but it's not exactly the same (notably, we
     14        do not focus a secondary window when it's done loading).
     15
    1162014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
    217

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r176011 r176800  
    265265    };
    266266    WKPageSetPageUIClient(newPage, &otherPageUIClient.base);
     267
     268    WKPageLoaderClientV5 pageLoaderClient = {
     269        { 5, clientInfo },
     270        0, // didStartProvisionalLoadForFrame
     271        0, // didReceiveServerRedirectForProvisionalLoadForFrame
     272        0, // didFailProvisionalLoadWithErrorForFrame
     273        0, // didCommitLoadForFrame,
     274        0, // didFinishDocumentLoadForFrame
     275        0, // didFinishLoadForFrame,
     276        0, // didFailLoadWithErrorForFrame
     277        0, // didSameDocumentNavigationForFrame
     278        0, // didReceiveTitleForFrame
     279        0, // didFirstLayoutForFrame
     280        0, // didFirstVisuallyNonEmptyLayoutForFrame
     281        0, // didRemoveFrameFromHierarchy
     282        0, // didFailToInitializePlugin
     283        0, // didDisplayInsecureContentForFrame
     284        canAuthenticateAgainstProtectionSpaceInFrame,
     285        didReceiveAuthenticationChallengeInFrame,
     286        0, // didStartProgress
     287        0, // didChangeProgress
     288        0, // didFinishProgress
     289        0, // didBecomeUnresponsive
     290        0, // didBecomeResponsive
     291        processDidCrash,
     292        0, // didChangeBackForwardList
     293        0, // shouldGoToBackForwardListItem
     294        0, // didRunInsecureContentForFrame
     295        0, // didDetectXSSForFrame
     296        0, // didNewFirstVisuallyNonEmptyLayout_unavailable
     297        0, // willGoToBackForwardListItem
     298        0, // interactionOccurredWhileProcessUnresponsive
     299        0, // pluginDidFail_deprecatedForUseWithV1
     300        0, // didReceiveIntentForFrame
     301        0, // registerIntentServiceForFrame
     302        0, // didLayout
     303        0, // pluginLoadPolicy_deprecatedForUseWithV2
     304        0, // pluginDidFail
     305        pluginLoadPolicy, // pluginLoadPolicy
     306        0, // webGLLoadPolicy
     307        0, // resolveWebGLLoadPolicy
     308        0, // shouldKeepCurrentBackForwardListItemInList
     309    };
     310    WKPageSetPageLoaderClient(view->page(), &pageLoaderClient.base);
     311
     312    WKPagePolicyClientV1 pagePolicyClient = {
     313        { 1, clientInfo },
     314        0, // decidePolicyForNavigationAction_deprecatedForUseWithV0
     315        0, // decidePolicyForNewWindowAction
     316        0, // decidePolicyForResponse_deprecatedForUseWithV0
     317        0, // unableToImplementPolicy
     318        decidePolicyForNavigationAction,
     319        decidePolicyForResponse,
     320    };
     321    WKPageSetPagePolicyClient(view->page(), &pagePolicyClient.base);
    267322
    268323    view->didInitializeClients();
Note: See TracChangeset for help on using the changeset viewer.