Changeset 176969 in webkit

Timestamp:

Dec 8, 2014, 1:53:54 PM (10 years ago)

Author:

mitz@apple.com

Message:

<rdar://problem/18046692> [iOS] Safari crashes at -[_NSUndoStack popAndInvoke] when trying to undo typing on closed tab
​https://bugs.webkit.org/show_bug.cgi?id=139408

Reviewed by Anders Carlsson.

• UIProcess/ios/WKContentView.mm:

(-[WKContentView undoManager]): Override to initialize if necessary and return a unique undo
manager for this instance. This ensures that undoable operations for this webview don’t get
put in other undo managers, and matches UIWebView behavior.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentView.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-12-08  Dan Bernstein  <mitz@apple.com>
+
+        <rdar://problem/18046692> [iOS] Safari crashes at -[_NSUndoStack popAndInvoke] when trying to undo typing on closed tab
+        https://bugs.webkit.org/show_bug.cgi?id=139408
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/ios/WKContentView.mm:
+        (-[WKContentView undoManager]): Override to initialize if necessary and return a unique undo
+        manager for this instance. This ensures that undoable operations for this webview don’t get
+        put in other undo managers, and matches UIWebView behavior.
+
 2014-12-08  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm

@@ -179 +179 @@
 
     HistoricalVelocityData _historicalKinematicData;
+
+    RetainPtr<NSUndoManager> _undoManager;
 }
 
@@ -376 +378 @@
 }
 
+- (NSUndoManager *)undoManager
+{
+    if (!_undoManager)
+        _undoManager = adoptNS([[NSUndoManager alloc] init]);
+
+    return _undoManager.get();
+}
+
 #pragma mark Internal