Changeset 177529 in webkit

Timestamp:

Dec 18, 2014 2:51:09 PM (9 years ago)

Author:

ap@apple.com

Message:

Perf tests frequently fail saying "build not up to date"
​https://bugs.webkit.org/show_bug.cgi?id=139786

Reviewed by Ryosuke Niwa.

Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
directory to get rid of stale precompiled headers, and let it rebuild
DumpRenderTree each time, that's fast.

Also, removed unused "build and perf test" code.

• BuildSlaveSupport/build.webkit.org-config/config.json:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/config.json (modified) (4 diffs)
• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

@@ -108 +108 @@
                     {
                       "name": "Apple MountainLion Release (Perf)", "type": "DownloadAndPerfTest", "builddir": "mountainlion-release-perf-tests",
+                      "is_clean": true,
                       "platform": "mac-mountainlion", "configuration": "release", "architectures": ["x86_64"],
                       "slavenames": ["bot141"]
@@ -148 +149 @@
                     {
                       "name": "Apple Mavericks Release (Perf)", "type": "DownloadAndPerfTest", "builddir": "mavericks-release-perf-tests",
+                      "is_clean": true,
                       "platform": "mac-mavericks", "configuration": "release", "architectures": ["x86_64"],
                       "slavenames": ["bot135"]
@@ -188 +190 @@
                     {
                       "name": "Apple Yosemite Release (Perf)", "type": "DownloadAndPerfTest", "builddir": "yosemite-release-perf-tests",
+                      "is_clean": true,
                       "platform": "mac-yosemite", "configuration": "release", "architectures": ["x86_64"],
                       "slavenames": ["bot194"]
@@ -247 +250 @@
                     {
                       "name": "GTK Linux 64-bit Release (Perf)", "type": "DownloadAndPerfTestWebKit2", "builddir": "gtk-linux-64-release-perf-tests",
+                      "is_clean": true,
                       "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
                       "slavenames": ["gtk-linux-slave-8"]

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -908 +908 @@
     LayoutTestClass = RunWebKit2Tests
 
-class BuildAndPerfTestFactory(Factory):
-    def __init__(self, platform, configuration, architectures, additionalArguments=None, SVNMirror=None, **kwargs):
-        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, SVNMirror, **kwargs)
-        self.addStep(CompileWebKit())
-        self.addStep(RunAndUploadPerfTests())
-
-class BuildAndPerfTestWebKit2Factory(Factory):
-    def __init__(self, platform, configuration, architectures, additionalArguments=None, SVNMirror=None, **kwargs):
-        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, SVNMirror, **kwargs)
-        self.addStep(CompileWebKit())
-        self.addStep(RunAndUploadPerfTestsWebKit2())
-
 class DownloadAndPerfTestFactory(Factory):
     def __init__(self, platform, configuration, architectures, additionalArguments=None, SVNMirror=None, **kwargs):

trunk/Tools/ChangeLog

@@ +1 @@
+2014-12-18  Alexey Proskuryakov  <ap@apple.com>
+
+        Perf tests frequently fail saying "build not up to date"
+        https://bugs.webkit.org/show_bug.cgi?id=139786
+
+        Reviewed by Ryosuke Niwa.
+
+        Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
+        directory to get rid of stale precompiled headers, and let it rebuild
+        DumpRenderTree each time, that's fast.
+
+        Also, removed unused "build and perf test" code.
+
+        * BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2014-12-18  Brent Fulgham  <bfulgham@apple.com>