Changeset 177722 in webkit

Timestamp:

Dec 24, 2014 12:34:55 AM (9 years ago)

Author:

ap@apple.com

Message:

DumpRenderTree crashes are mis-reported as timeouts on Yosemite
​https://bugs.webkit.org/show_bug.cgi?id=139933

Reviewed by Daniel Bates.

Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
and there is no way for run-webkit-tests to tell a crashed process from a frozen one
until ReportCrash lets it go.

Reuse existing machinery that tells run-webkit-tests about crashes. The script may
even get the actual crash log eventually - even when it times out waiting for the log, it
makes a second lookup at the very end, after all tests finish. There may be further
improvements needed here, but this small fix addresses most cases that happen in practice.

• DumpRenderTree/mac/DumpRenderTree.mm:

(writeCrashedMessageOnFatalError):
(dumpRenderTree):
Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.

• Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an

unhelpful comment.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/mac/DumpRenderTree.mm (modified) (4 diffs)
• Scripts/webkitpy/port/driver.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-12-23  Alexey Proskuryakov  <ap@apple.com>
+
+        DumpRenderTree crashes are mis-reported as timeouts on Yosemite
+        https://bugs.webkit.org/show_bug.cgi?id=139933
+
+        Reviewed by Daniel Bates.
+
+        Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
+        and there is no way for run-webkit-tests to tell a crashed process from a frozen one
+        until ReportCrash lets it go.
+
+        Reuse existing machinery that tells run-webkit-tests about crashes. The script may
+        even get the actual crash log eventually - even when it times out waiting for the log, it
+        makes a second lookup at the very end, after all tests finish. There may be further
+        improvements needed here, but this small fix addresses most cases that happen in practice.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (writeCrashedMessageOnFatalError):
+        (dumpRenderTree):
+        Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
+
+        * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
+        unhelpful comment.
+
 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm

@@ -1122 +1122 @@
 }
 
-#if PLATFORM(IOS)
 const char crashedMessage[] = "#CRASHED\n";
 
@@ -1135 +1134 @@
     fsync(STDERR_FILENO);
 }
-#endif
 
 void dumpRenderTree(int argc, const char *argv[])
@@ -1151 +1149 @@
     int errfd = open(stderrPath, O_RDWR | O_NONBLOCK);
     dup2(errfd, STDERR_FILENO);
+#endif
 
     signal(SIGILL, &writeCrashedMessageOnFatalError);
@@ -1156 +1155 @@
     signal(SIGBUS, &writeCrashedMessageOnFatalError);
     signal(SIGSEGV, &writeCrashedMessageOnFatalError);
-#endif
 
     initializeGlobalsFromCommandLineOptions(argc, argv);

trunk/Tools/Scripts/webkitpy/port/driver.py

@@ -375 +375 @@
     def _check_for_driver_crash(self, error_line):
         if error_line == "#CRASHED\n":
-            # This is used on Windows and iOS to report that the process has crashed
-            # See http://trac.webkit.org/changeset/65537.
             self._crashed_process_name = self._server_process.name()
             self._crashed_pid = self._server_process.pid()