Changeset 179027 in webkit


Ignore:
Timestamp:
Jan 23, 2015, 2:16:31 PM (10 years ago)
Author:
enrica@apple.com
Message:

Hit test returns incorrect results when performed in paginated content over the page gaps.
​https://bugs.webkit.org/show_bug.cgi?id=140837
rdar://problem/17494390

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/multicol/pagination/LeftToRight-tb-hittest.html

fast/multicol/pagination/RightToLeft-rl-hittest.html

When hittesting reaches the RenderView we need to check if we are
in paginated content and use the correct class to compute hittest results.

  • rendering/RenderView.cpp:

(WebCore::RenderView::updateHitTestResult):

LayoutTests:

  • fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
  • fast/multicol/pagination/LeftToRight-tb-hittest.html: Added.
  • fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
  • fast/multicol/pagination/RightToLeft-rl-hittest.html: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r179026 r179027  
     12015-01-23  Enrica Casucci  <enrica@apple.com>
     2
     3        Hit test returns incorrect results when performed in paginated content over the page gaps.
     4        https://bugs.webkit.org/show_bug.cgi?id=140837
     5        rdar://problem/17494390
     6
     7        Reviewed by Dave Hyatt.
     8
     9        * fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
     10        * fast/multicol/pagination/LeftToRight-tb-hittest.html: Added.
     11        * fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
     12        * fast/multicol/pagination/RightToLeft-rl-hittest.html: Added.
     13
    1142015-01-23  Brent Fulgham  <bfulgham@apple.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r179025 r179027  
     12015-01-23  Enrica Casucci  <enrica@apple.com>
     2
     3        Hit test returns incorrect results when performed in paginated content over the page gaps.
     4        https://bugs.webkit.org/show_bug.cgi?id=140837
     5        rdar://problem/17494390
     6
     7        Reviewed by Dave Hyatt.
     8
     9        Tests: fast/multicol/pagination/LeftToRight-tb-hittest.html
     10               fast/multicol/pagination/RightToLeft-rl-hittest.html
     11
     12        When hittesting reaches the RenderView we need to check if we are
     13        in paginated content and use the correct class to compute hittest results.
     14
     15        * rendering/RenderView.cpp:
     16        (WebCore::RenderView::updateHitTestResult):
     17
    1182015-01-23  Andreas Kling  <akling@apple.com>
    219

  • trunk/Source/WebCore/rendering/RenderView.cpp

    r178689 r179027  
    12171217        return;
    12181218
     1219    if (multiColumnFlowThread() && multiColumnFlowThread()->firstMultiColumnSet())
     1220        return multiColumnFlowThread()->firstMultiColumnSet()->updateHitTestResult(result, point);
     1221
    12191222    Node* node = document().documentElement();
    12201223    if (node) {
Note: See TracChangeset for help on using the changeset viewer.