Changeset 179922 in webkit


Ignore:
Timestamp:
Feb 11, 2015 1:03:06 AM (9 years ago)
Author:
Carlos Garcia Campos
Message:

[GTK] Add default color chooser implementation using GtkColorChooserDialog
​https://bugs.webkit.org/show_bug.cgi?id=141392

Reviewed by Gustavo Noronha Silva.

.:

Enable INPUT_TYPE_COLOR by default for GTK+ port.

  • Source/cmake/OptionsGTK.cmake:

Source/WebKit2:

  • PlatformGTK.cmake: Add new files to compilation.
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createColorPicker): Call WebColorPickerGtk::create().

  • UIProcess/gtk/WebColorPickerGtk.cpp: Added.

(WebKit::WebColorPickerGtk::create):
(WebKit::WebColorPickerGtk::WebColorPickerGtk):
(WebKit::WebColorPickerGtk::~WebColorPickerGtk):
(WebKit::WebColorPickerGtk::cancel): Set initial color.
(WebKit::WebColorPickerGtk::endPicker): Destroy the color chooser dialog.
(WebKit::WebColorPickerGtk::didChooseColor): Notify the client.
(WebKit::WebColorPickerGtk::colorChooserDialogRGBAChangedCallback):
Update the selected color.
(WebKit::WebColorPickerGtk::colorChooserDialogResponseCallback):
Cancel or finish the operation depending on the dialog response.
(WebKit::WebColorPickerGtk::showColorPicker): Create a
GtkColorChooserDialog to handle the color picker operation.

  • UIProcess/gtk/WebColorPickerGtk.h: Added.

(WebKit::WebColorPickerGtk::initialColor):

Tools:

Enable INPUT_TYPE_COLOR by default for GTK+ port.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip input color tests.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/forms/color/input-appearance-color-expected.txt: Added.
Location:
trunk
Files:
4 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r179826 r179922  
     12015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Add default color chooser implementation using GtkColorChooserDialog
     4        https://bugs.webkit.org/show_bug.cgi?id=141392
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Enable INPUT_TYPE_COLOR by default for GTK+ port.
     9
     10        * Source/cmake/OptionsGTK.cmake:
     11
    1122015-02-09  Sergio Villar Senin  <svillar@igalia.com>
    213

  • trunk/LayoutTests/ChangeLog

    r179921 r179922  
     12015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Add default color chooser implementation using GtkColorChooserDialog
     4        https://bugs.webkit.org/show_bug.cgi?id=141392
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Unskip input color tests.
     9
     10        * platform/gtk/TestExpectations:
     11        * platform/gtk/fast/forms/color/input-appearance-color-expected.txt: Added.
     12
    1132015-02-11  ChangSeok Oh  <changseok.oh@collabora.com>
    214

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r179868 r179922  
    160160# Datalist is not yet enabled.
    161161webkit.org/b/98934 fast/forms/datalist [ Skip ]
    162 
    163 # Color input is not yet enabled.
    164 webkit.org/b/98935 fast/forms/color [ Skip ]
    165162
    166163# ENABLE_INPUT_TYPE_* are not enabled.

  • trunk/Source/WebKit2/ChangeLog

    r179919 r179922  
     12015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Add default color chooser implementation using GtkColorChooserDialog
     4        https://bugs.webkit.org/show_bug.cgi?id=141392
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        * PlatformGTK.cmake: Add new files to compilation.
     9        * UIProcess/API/gtk/PageClientImpl.cpp:
     10        (WebKit::PageClientImpl::createColorPicker): Call WebColorPickerGtk::create().
     11        * UIProcess/gtk/WebColorPickerGtk.cpp: Added.
     12        (WebKit::WebColorPickerGtk::create):
     13        (WebKit::WebColorPickerGtk::WebColorPickerGtk):
     14        (WebKit::WebColorPickerGtk::~WebColorPickerGtk):
     15        (WebKit::WebColorPickerGtk::cancel): Set initial color.
     16        (WebKit::WebColorPickerGtk::endPicker): Destroy the color chooser dialog.
     17        (WebKit::WebColorPickerGtk::didChooseColor): Notify the client.
     18        (WebKit::WebColorPickerGtk::colorChooserDialogRGBAChangedCallback):
     19        Update the selected color.
     20        (WebKit::WebColorPickerGtk::colorChooserDialogResponseCallback):
     21        Cancel or finish the operation depending on the dialog response.
     22        (WebKit::WebColorPickerGtk::showColorPicker): Create a
     23        GtkColorChooserDialog to handle the color picker operation.
     24        * UIProcess/gtk/WebColorPickerGtk.h: Added.
     25        (WebKit::WebColorPickerGtk::initialColor):
     26
    1272015-02-11  Commit Queue  <commit-queue@webkit.org>
    228

  • trunk/Source/WebKit2/PlatformGTK.cmake

    r179249 r179922  
    275275    UIProcess/gtk/RedirectedXCompositeWindow.cpp
    276276    UIProcess/gtk/TextCheckerGtk.cpp
     277    UIProcess/gtk/WebColorPickerGtk.cpp
    277278    UIProcess/gtk/WebContextMenuProxyGtk.cpp
    278279    UIProcess/gtk/WebFullScreenClientGtk.cpp

  • trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp

    r179397 r179922  
    3333#include "NativeWebMouseEvent.h"
    3434#include "NotImplemented.h"
     35#include "WebColorPickerGtk.h"
    3536#include "WebContextMenuProxyGtk.h"
    3637#include "WebEventFactory.h"
    … …  
    227228
    228229#if ENABLE(INPUT_TYPE_COLOR)
    229 PassRefPtr<WebColorPicker> PageClientImpl::createColorPicker(WebPageProxy*, const WebCore::Color&, const WebCore::IntRect&)
    230 {
    231     notImplemented();
    232     return 0;
     230PassRefPtr<WebColorPicker> PageClientImpl::createColorPicker(WebPageProxy* page, const WebCore::Color& color, const WebCore::IntRect& rect)
     231{
     232    return WebColorPickerGtk::create(*page, color, rect);
    233233}
    234234#endif

  • trunk/Source/cmake/OptionsGTK.cmake

    r179110 r179922  
    144144WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE OFF)
    145145WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE_IN_WORKERS OFF)
    146 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR OFF)
     146WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR ON)
    147147WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LEGACY_WEB_AUDIO OFF)
    148148WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LINK_PREFETCH OFF)

  • trunk/Tools/ChangeLog

    r179830 r179922  
     12015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Add default color chooser implementation using GtkColorChooserDialog
     4        https://bugs.webkit.org/show_bug.cgi?id=141392
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Enable INPUT_TYPE_COLOR by default for GTK+ port.
     9
     10        * Scripts/webkitperl/FeatureList.pm:
     11
    1122015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
    213

  • trunk/Tools/Scripts/webkitperl/FeatureList.pm

    r179687 r179922  
    258258
    259259    { option => "input-type-color", desc => "Toggle Input Type Color support",
    260       define => "ENABLE_INPUT_TYPE_COLOR", default => isEfl(), value => \$inputTypeColorSupport },
     260      define => "ENABLE_INPUT_TYPE_COLOR", default => (isEfl() || isGtk()), value => \$inputTypeColorSupport },
    261261
    262262    { option => "input-type-date", desc => "Toggle Input Type Date support",
Note: See TracChangeset for help on using the changeset viewer.