Changeset 182619 in webkit

Timestamp:

Apr 9, 2015 5:39:29 PM (9 years ago)

Author:

Chris Dumez

Message:

Regression(r182603): editing/selection/selection-invalid-offset.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=143591

Reviewed by Ryosuke Niwa.

Add missing null-check for m_frame->editor().client() in
FrameSelection::updateAndRevealSelection().

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAndRevealSelection):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/FrameSelection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-09  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r182603): editing/selection/selection-invalid-offset.html is crashing
+        https://bugs.webkit.org/show_bug.cgi?id=143591
+
+        Reviewed by Ryosuke Niwa.
+
+        Add missing null-check for m_frame->editor().client() in
+        FrameSelection::updateAndRevealSelection().
+
+        * editing/FrameSelection.cpp:
+        (WebCore::FrameSelection::updateAndRevealSelection):
+
 2015-04-09  Sungmann Cho  <sungmann.cho@navercorp.com>
 

trunk/Source/WebCore/editing/FrameSelection.cpp

@@ -383 +383 @@
     notifyAccessibilityForSelectionChange();
 
-    m_frame->editor().client()->didChangeSelectionAndUpdateLayout();
+    if (auto* client = m_frame->editor().client())
+        client->didChangeSelectionAndUpdateLayout();
 }