Changeset 184043 in webkit

Timestamp:

May 9, 2015, 8:58:20 PM (9 years ago)

Author:

mitz@apple.com

Message:

Deployment-target NSi_ and NSd_ definitions in WKFoundation.h are redundant
​https://bugs.webkit.org/show_bug.cgi?id=144831

Reviewed by Sam Weinig.

Reverted r182846 and r182904.

• Shared/API/Cocoa/WKFoundation.h:
• WebKit2.xcodeproj/project.pbxproj:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/API/Cocoa/WKFoundation.h (modified) (2 diffs)
• WebKit2.xcodeproj/project.pbxproj (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-05-09  Dan Bernstein  <mitz@apple.com>
+
+        Deployment-target __NSi_ and __NSd_ definitions in WKFoundation.h are redundant
+        https://bugs.webkit.org/show_bug.cgi?id=144831
+
+        Reviewed by Sam Weinig.
+
+        Reverted r182846 and r182904.
+
+        * Shared/API/Cocoa/WKFoundation.h:
+        * WebKit2.xcodeproj/project.pbxproj:
+
 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
 

trunk/Source/WebKit2/Shared/API/Cocoa/WKFoundation.h

@@ -25 +25 @@
 
 #import <Availability.h>
-#import <CoreFoundation/CoreFoundation.h>
 #import <TargetConditionals.h>
 
@@ -40 +39 @@
 #else
 #define WK_EXTERN extern __attribute__((visibility ("default")))
-#endif
-
-#ifdef WK_FRAMEWORK_HEADER_POSTPROCESSING_ENABLED
-// Do not remove or change this comment. POSTPROCESSING_INSERTS_DEPLOYMENT_TARGET_AVAILABILITY_DEFINITION_HERE
 #endif
 

trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj

@@ -9081 +9081 @@
                         runOnlyForDeploymentPostprocessing = 0;
                         shellPath = /bin/sh;
-                        shellScript = "WKFOUNDATION_H=${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}/WKFoundation.h\n\nif [[ \"${WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED}\" == \"YES\" ]]; then\n    UNIFDEF_OPTIONS=\"-UWK_FRAMEWORK_HEADER_POSTPROCESSING_ENABLED\";\nelse\n    UNIFDEF_OPTIONS=\"-DWK_FRAMEWORK_HEADER_POSTPROCESSING_ENABLED\";\nfi\n\nunifdef -B ${UNIFDEF_OPTIONS} -o ${WKFOUNDATION_H}.unifdef ${WKFOUNDATION_H}\n\ncase $? in\n0)\n    rm ${WKFOUNDATION_H}.unifdef\n    ;;\n1)\n    mv ${WKFOUNDATION_H}{.unifdef,}\n    ;;\n*)\n    exit 1\nesac\n\nif [[ \"${WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED}\" != \"YES\" ]]; then\n    eval DEPLOYMENT_TARGET=\\$$DEPLOYMENT_TARGET_SETTING_NAME\n\n    sed -e \"/POSTPROCESSING_INSERTS_DEPLOYMENT_TARGET_AVAILABILITY_DEFINITION_HERE/c\\\\\n        #ifndef __NSi_${DEPLOYMENT_TARGET/\\./_}\\\\\n        #define __NSi_${DEPLOYMENT_TARGET/\\./_} introduced=${DEPLOYMENT_TARGET}\\\\\n        #endif\\\\\n        #ifndef __NSd_${DEPLOYMENT_TARGET/\\./_}\\\\\n        #define __NSd_${DEPLOYMENT_TARGET/\\./_} ,deprecated=${DEPLOYMENT_TARGET}\\\\\n        #endif\" ${WKFOUNDATION_H} > ${WKFOUNDATION_H}.sed\n\n    if ( cmp ${WKFOUNDATION_H} ${WKFOUNDATION_H}.sed > /dev/null ); then\n        rm ${WKFOUNDATION_H}.sed\n    else\n        mv ${WKFOUNDATION_H}{.sed,}\n    fi\nfi";
+                        shellScript = "WKFOUNDATION_H=${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}/WKFoundation.h\n\nif [[ \"${WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED}\" == \"YES\" ]]; then\n    UNIFDEF_OPTIONS=\"-UWK_FRAMEWORK_HEADER_POSTPROCESSING_ENABLED\";\nelse\n    UNIFDEF_OPTIONS=\"-DWK_FRAMEWORK_HEADER_POSTPROCESSING_ENABLED\";\nfi\n\nunifdef -B ${UNIFDEF_OPTIONS} -o ${WKFOUNDATION_H}.unifdef ${WKFOUNDATION_H}\n\ncase $? in\n0)\n    rm ${WKFOUNDATION_H}.unifdef\n    ;;\n1)\n    mv ${WKFOUNDATION_H}{.unifdef,}\n    ;;\n*)\n    exit 1\nesac\n";
                 };
                 1ADAE12C1919A43F00F48E21 /* Migrate Headers to WebKit2 */ = {