Changeset 185166 in webkit
- Timestamp:
- Jun 3, 2015 1:44:56 PM (9 years ago)
- Location:
- trunk
- Files:
-
- 14 added
- 3 edited
- 6 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r185160 r185166 1 2015-06-03 Daniel Bates <dabates@apple.com> 2 3 AutoFill button should not be shown in read-only or disabled field 4 https://bugs.webkit.org/show_bug.cgi?id=145579 5 <rdar://problem/21212494> 6 7 Reviewed by Darin Adler. 8 9 Add tests to ensure that we do no show the AutoFill button in a read-only or disabled field. 10 11 Additionally, create directory LayoutTests/fast/forms/auto-fill-button and move existing test 12 LayoutTests/fast/forms/input-auto-fill-button.html and associated test results into this directory 13 or the platform-specific variant of this directory. 14 15 * fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-disabled-expected.html: Added. 16 * fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-disabled.html: Added. 17 * fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-readonly-expected.html: Added. 18 * fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-readonly.html: Added. 19 * fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Renamed from LayoutTests/fast/forms/input-auto-fill-button-expected.txt. 20 * fast/forms/auto-fill-button/input-auto-fill-button.html: Renamed from LayoutTests/fast/forms/input-auto-fill-button.html. 21 * fast/forms/auto-fill-button/input-disabled-auto-fill-button-expected.html: Added. 22 * fast/forms/auto-fill-button/input-disabled-auto-fill-button.html: Added. 23 * fast/forms/auto-fill-button/input-readonly-auto-fill-button-expected.html: Added. 24 * fast/forms/auto-fill-button/input-readonly-auto-fill-button.html: Added. 25 * fast/forms/auto-fill-button/input-readonly-non-empty-auto-fill-button-expected.html: Added. 26 * fast/forms/auto-fill-button/input-readonly-non-empty-auto-fill-button.html: Added. 27 * platform/ios-simulator/fast/forms/auto-fill-button/input-auto-fill-button-expected.png: Renamed from LayoutTests/platform/ios-simulator/fast/forms/input-auto-fill-button-expected.png. 28 * platform/ios-simulator/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Renamed from LayoutTests/platform/ios-simulator/fast/forms/input-auto-fill-button-expected.txt. 29 * platform/mac-mavericks/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt. 30 * platform/win/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/input-auto-fill-button-expected.txt. 31 1 32 2015-06-02 Filip Pizlo <fpizlo@apple.com> 2 33 -
trunk/LayoutTests/platform/win/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt
r185165 r185166 10 10 RenderTextControl {INPUT} at (2,2) size 149x21 [bgcolor=#FFFFFF] [border: (2px inset #000000)] 11 11 RenderFlexibleBox {DIV} at (2,3) size 145x15 12 RenderBlock {DIV} at (0,0) size 12 5x1512 RenderBlock {DIV} at (0,0) size 129x15 13 13 RenderText {#text} at (153,3) size 4x18 14 14 text run at (153,3) width 4: " " 15 15 RenderTextControl {INPUT} at (159,2) size 149x21 [bgcolor=#FFFFFF] [border: (2px inset #000000)] 16 16 RenderFlexibleBox {DIV} at (2,3) size 145x15 17 RenderBlock {DIV} at (0,0) size 12 5x1517 RenderBlock {DIV} at (0,0) size 129x15 18 18 RenderText {#text} at (310,3) size 4x18 19 19 text run at (310,3) width 4: " " 20 20 RenderTextControl {INPUT} at (316,2) size 149x21 [bgcolor=#FFFFFF] [border: (2px inset #000000)] 21 21 RenderFlexibleBox {DIV} at (2,3) size 145x15 22 RenderBlock {DIV} at (0,0) size 12 5x1522 RenderBlock {DIV} at (0,0) size 129x15 23 23 RenderTextControl {INPUT} at (469,2) size 149x21 [bgcolor=#FFFFFF] [border: (2px inset #000000)] 24 layer at (12,47) size 12 5x1525 RenderBlock {DIV} at (0,0) size 12 5x1526 layer at (169,47) size 12 5x1527 RenderBlock {DIV} at (0,0) size 12 5x1528 layer at (326,47) size 12 5x1529 RenderBlock {DIV} at (0,0) size 12 5x1524 layer at (12,47) size 129x15 25 RenderBlock {DIV} at (0,0) size 129x15 26 layer at (169,47) size 129x15 27 RenderBlock {DIV} at (0,0) size 129x15 28 layer at (326,47) size 129x15 29 RenderBlock {DIV} at (0,0) size 129x15 30 30 layer at (479,47) size 145x15 31 31 RenderBlock {DIV} at (2,3) size 145x15 32 layer at (14 0,49) size 15x1233 Render Block {DIV} at (128,1) size 15x13 [bgcolor=#000000]34 layer at (29 7,49) size 15x1235 Render Block {DIV} at (128,1) size 15x13 [bgcolor=#000000]36 layer at (45 4,49) size 15x1237 Render Block {DIV} at (128,1) size 15x13 [bgcolor=#000000]32 layer at (141,47) size 16x15 33 RenderImage {DIV} at (129,0) size 16x15 34 layer at (298,47) size 16x15 35 RenderImage {DIV} at (129,0) size 16x15 36 layer at (455,47) size 16x15 37 RenderImage {DIV} at (129,0) size 16x15 -
trunk/Source/WebCore/ChangeLog
r185156 r185166 1 2015-06-03 Daniel Bates <dabates@apple.com> 2 3 AutoFill button should not be shown in read-only or disabled field 4 https://bugs.webkit.org/show_bug.cgi?id=145579 5 <rdar://problem/21212494> 6 7 Reviewed by Darin Adler. 8 9 Fixes an issue where the AutoFill button is shown in a read-only or disabled 10 field. We should not show the AutoFill button in such cases. 11 12 Tests: fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-disabled.html 13 fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-readonly.html 14 fast/forms/auto-fill-button/input-auto-fill-button.html 15 fast/forms/auto-fill-button/input-disabled-auto-fill-button.html 16 fast/forms/auto-fill-button/input-readonly-auto-fill-button.html 17 fast/forms/auto-fill-button/input-readonly-non-empty-auto-fill-button.html 18 19 * html/TextFieldInputType.cpp: 20 (WebCore::TextFieldInputType::disabledAttributeChanged): Update AutoFill button state. 21 (WebCore::TextFieldInputType::readonlyAttributeChanged): Ditto. 22 (WebCore::TextFieldInputType::shouldDrawAutoFillButton): Do not draw AutoFill button 23 when the field is disabled or read-only. 24 1 25 2015-06-03 Brent Fulgham <bfulgham@apple.com> 2 26 -
trunk/Source/WebCore/html/TextFieldInputType.cpp
r185089 r185166 359 359 if (m_innerSpinButton) 360 360 m_innerSpinButton->releaseCapture(); 361 updateAutoFillButton(); 361 362 } 362 363 … … 365 366 if (m_innerSpinButton) 366 367 m_innerSpinButton->releaseCapture(); 368 updateAutoFillButton(); 367 369 } 368 370 … … 571 573 bool TextFieldInputType::shouldDrawAutoFillButton() const 572 574 { 573 return element().showAutoFillButton();575 return !element().isDisabledOrReadOnly() && element().showAutoFillButton(); 574 576 } 575 577
Note: See TracChangeset
for help on using the changeset viewer.