Changeset 185303 in webkit

Timestamp:

Jun 7, 2015, 10:37:37 AM (10 years ago)

Author:

mitz@apple.com

Message:

Reverted r185302 because it broke the build

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Assertions.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ -1 @@
-2015-06-07  Dan Bernstein  <mitz@apple.com>
-
-        Unifiy the definition of UNREACHABLE_FOR_PLATFORM
-        https://bugs.webkit.org/show_bug.cgi?id=145737
-
-        Reviewed by Anders Carlsson.
-
-        * wtf/Assertions.h:
-        (UNREACHABLE_FOR_PLATFORM): Use the macro for clang as well. Its expansion includes
-        __attribute((__noreturn__)) so the pragmas are unnecessary.
-
 2015-06-05  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WTF/wtf/Assertions.h

@@ -373 +373 @@
 /* UNREACHABLE_FOR_PLATFORM */
 
+#if COMPILER(CLANG)
+// This would be a macro except that its use of #pragma works best around
+// a function. Hence it uses macro naming convention.
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wmissing-noreturn"
+static inline void UNREACHABLE_FOR_PLATFORM()
+{
+    RELEASE_ASSERT_NOT_REACHED();
+}
+#pragma clang diagnostic pop
+#else
 #define UNREACHABLE_FOR_PLATFORM() RELEASE_ASSERT_NOT_REACHED()
+#endif
+
 
 #endif /* WTF_Assertions_h */