Changeset 189366 in webkit

Timestamp:

Sep 4, 2015, 11:58:22 AM (9 years ago)

Author:

mitz@apple.com

Message:

[iOS] Disable backspace key navigation by default
​https://bugs.webkit.org/show_bug.cgi?id=148808

Reviewed by Tim Horton.

• Shared/WebPreferencesDefinitions.h: Defined DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED as false on iOS, true elsewhere, and made it the default value of the backspaceKeyNavigationEnabled preference key.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferencesDefinitions.h (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-09-04  Dan Bernstein  <mitz@apple.com>
+
+        [iOS] Disable backspace key navigation by default
+        https://bugs.webkit.org/show_bug.cgi?id=148808
+
+        Reviewed by Tim Horton.
+
+        * Shared/WebPreferencesDefinitions.h: Defined DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED as
+          false on iOS, true elsewhere, and made it the default value of the
+          backspaceKeyNavigationEnabled preference key.
+
 2015-09-04  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h

@@ -50 +50 @@
 
 #if PLATFORM(IOS)
+#define DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED false
 #define DEFAULT_FRAME_FLATTENING_ENABLED true
 #define DEFAULT_SHOULD_PRINT_BACKGROUNDS true
@@ -64 +65 @@
 #define DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED false
 #else
+#define DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED true
 #define DEFAULT_FRAME_FLATTENING_ENABLED false
 #define DEFAULT_SHOULD_PRINT_BACKGROUNDS false
@@ -147 +149 @@
     macro(WebAudioEnabled, webAudioEnabled, Bool, bool, true) \
     macro(SuppressesIncrementalRendering, suppressesIncrementalRendering, Bool, bool, false) \
-    macro(BackspaceKeyNavigationEnabled, backspaceKeyNavigationEnabled, Bool, bool, true) \
+    macro(BackspaceKeyNavigationEnabled, backspaceKeyNavigationEnabled, Bool, bool, DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED) \
     macro(CaretBrowsingEnabled, caretBrowsingEnabled, Bool, bool, false) \
     macro(ShouldDisplaySubtitles, shouldDisplaySubtitles, Bool, bool, false) \