Changeset 190699 in webkit

Timestamp:

Oct 7, 2015 5:47:59 PM (9 years ago)

Author:

mark.lam@apple.com

Message:

[Follow up 2] Disable tail calls because it is breaking some sites.
​https://bugs.webkit.org/show_bug.cgi?id=149900

Rubber stamped by Saam Barati.

Also need to surpress JSC tail call tests.

• tests/es6.yaml:
• tests/stress/dfg-tail-calls.js:

(nonInlinedTailCall.callee):

• tests/stress/mutual-tail-call-no-stack-overflow.js:

(shouldThrow):

• tests/stress/tail-call-in-inline-cache.js:

(tail):

• tests/stress/tail-call-no-stack-overflow.js:

(shouldThrow):

• tests/stress/tail-call-recognize.js:

(callerMustBeRun):

• tests/stress/tail-call-varargs-no-stack-overflow.js:

(shouldThrow):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• tests/es6.yaml (modified) (1 diff)
• tests/stress/dfg-tail-calls.js (modified) (1 diff)
• tests/stress/mutual-tail-call-no-stack-overflow.js (modified) (1 diff)
• tests/stress/tail-call-in-inline-cache.js (modified) (1 diff)
• tests/stress/tail-call-no-stack-overflow.js (modified) (1 diff)
• tests/stress/tail-call-recognize.js (modified) (1 diff)
• tests/stress/tail-call-varargs-no-stack-overflow.js (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-10-07  Mark Lam  <mark.lam@apple.com>
+
+        [Follow up 2] Disable tail calls because it is breaking some sites.
+        https://bugs.webkit.org/show_bug.cgi?id=149900
+
+        Rubber stamped by Saam Barati.
+
+        Also need to surpress JSC tail call tests.
+
+        * tests/es6.yaml:
+        * tests/stress/dfg-tail-calls.js:
+        (nonInlinedTailCall.callee):
+        * tests/stress/mutual-tail-call-no-stack-overflow.js:
+        (shouldThrow):
+        * tests/stress/tail-call-in-inline-cache.js:
+        (tail):
+        * tests/stress/tail-call-no-stack-overflow.js:
+        (shouldThrow):
+        * tests/stress/tail-call-recognize.js:
+        (callerMustBeRun):
+        * tests/stress/tail-call-varargs-no-stack-overflow.js:
+        (shouldThrow):
+
 2015-10-07  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/JavaScriptCore/tests/es6.yaml

@@ -878 +878 @@
   cmd: runES6 :fail
 - path: es6/proper_tail_calls_tail_call_optimisation_direct_recursion.js
-  cmd: runES6 :normal
+  cmd: runES6 :fail
 - path: es6/proper_tail_calls_tail_call_optimisation_mutual_recursion.js
-  cmd: runES6 :normal
+  cmd: runES6 :fail
 - path: es6/prototype_of_bound_functions_arrow_functions.js
   cmd: runES6 :fail

trunk/Source/JavaScriptCore/tests/stress/dfg-tail-calls.js

@@ +1 @@
+//@ skip
 (function nonInlinedTailCall() {
     function callee() { if (callee.caller != nonInlinedTailCall) throw new Error(); }

trunk/Source/JavaScriptCore/tests/stress/mutual-tail-call-no-stack-overflow.js

@@ +1 @@
+//@ skip
 function shouldThrow(func, errorMessage) {
     var errorThrown = false;

trunk/Source/JavaScriptCore/tests/stress/tail-call-in-inline-cache.js

@@ +1 @@
+//@ skip
 "use strict";
 

trunk/Source/JavaScriptCore/tests/stress/tail-call-no-stack-overflow.js

@@ +1 @@
+//@ skip
 function shouldThrow(func, errorMessage) {
     var errorThrown = false;

trunk/Source/JavaScriptCore/tests/stress/tail-call-recognize.js

@@ +1 @@
+//@ skip
 function callerMustBeRun() {
     if (!Object.is(callerMustBeRun.caller, runTests))

trunk/Source/JavaScriptCore/tests/stress/tail-call-varargs-no-stack-overflow.js

@@ +1 @@
+//@ skip
 function shouldThrow(func, errorMessage) {
     var errorThrown = false;