Changeset 191058 in webkit
- Timestamp:
- Oct 14, 2015, 11:57:07 AM (10 years ago)
- Location:
- trunk
- Files:
-
- 56 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/API/tests/ExecutionTimeLimitTest.cpp
r189009 r191058 103 103 { 104 104 static const TierOptions tierOptionsList[] = { 105 { "LLINT", 0, "-- enableConcurrentJIT=false --useLLInt=true --useJIT=false" },106 { "Baseline", 0, "-- enableConcurrentJIT=false --useLLInt=true --useJIT=true --useDFGJIT=false" },107 { "DFG", 0, "-- enableConcurrentJIT=false --useLLInt=true --useJIT=true --useDFGJIT=true --useFTLJIT=false" },108 { "FTL", 200, "-- enableConcurrentJIT=false --useLLInt=true --useJIT=true --useDFGJIT=true --useFTLJIT=true" },105 { "LLINT", 0, "--useConcurrentJIT=false --useLLInt=true --useJIT=false" }, 106 { "Baseline", 0, "--useConcurrentJIT=false --useLLInt=true --useJIT=true --useDFGJIT=false" }, 107 { "DFG", 0, "--useConcurrentJIT=false --useLLInt=true --useJIT=true --useDFGJIT=true --useFTLJIT=false" }, 108 { "FTL", 200, "--useConcurrentJIT=false --useLLInt=true --useJIT=true --useDFGJIT=true --useFTLJIT=true" }, 109 109 }; 110 110 -
trunk/Source/JavaScriptCore/ChangeLog
r191046 r191058 1 2015-10-14 Mark Lam <mark.lam@apple.com> 2 3 Rename some JSC option names to be more uniform. 4 https://bugs.webkit.org/show_bug.cgi?id=150127 5 6 Reviewed by Geoffrey Garen. 7 8 Renaming JSC_enableXXX options to JSC_useXXX, and JSC_showXXX options to JSC_dumpXXX. 9 Also will renaming a few other miscellaneous to options, to abide by this scheme. 10 11 Also renaming some functions to match the option names where relevant. 12 13 * API/tests/ExecutionTimeLimitTest.cpp: 14 (testExecutionTimeLimit): 15 * assembler/AbstractMacroAssembler.h: 16 (JSC::optimizeForARMv7IDIVSupported): 17 (JSC::optimizeForARM64): 18 (JSC::optimizeForX86): 19 * assembler/LinkBuffer.cpp: 20 (JSC::shouldDumpDisassemblyFor): 21 (JSC::LinkBuffer::finalizeCodeWithoutDisassembly): 22 (JSC::shouldShowDisassemblyFor): Deleted. 23 * assembler/LinkBuffer.h: 24 * bytecode/CodeBlock.cpp: 25 (JSC::CodeBlock::jettison): 26 * bytecode/CodeBlockJettisoningWatchpoint.cpp: 27 (JSC::CodeBlockJettisoningWatchpoint::fireInternal): 28 * bytecompiler/BytecodeGenerator.cpp: 29 (JSC::BytecodeGenerator::BytecodeGenerator): 30 * dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp: 31 (JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::fire): 32 * dfg/DFGAdaptiveStructureWatchpoint.cpp: 33 (JSC::DFG::AdaptiveStructureWatchpoint::fireInternal): 34 * dfg/DFGByteCodeParser.cpp: 35 (JSC::DFG::ByteCodeParser::handleInlining): 36 (JSC::DFG::ByteCodeParser::handleGetById): 37 (JSC::DFG::ByteCodeParser::handlePutById): 38 (JSC::DFG::ByteCodeParser::parse): 39 * dfg/DFGCommon.h: 40 (JSC::DFG::leastUpperBound): 41 (JSC::DFG::shouldDumpDisassembly): 42 (JSC::DFG::shouldShowDisassembly): Deleted. 43 * dfg/DFGDriver.cpp: 44 (JSC::DFG::compileImpl): 45 * dfg/DFGJITCompiler.cpp: 46 (JSC::DFG::JITCompiler::JITCompiler): 47 (JSC::DFG::JITCompiler::disassemble): 48 * dfg/DFGJumpReplacement.cpp: 49 (JSC::DFG::JumpReplacement::fire): 50 * dfg/DFGOSREntry.cpp: 51 (JSC::DFG::prepareOSREntry): 52 * dfg/DFGOSRExitCompiler.cpp: 53 * dfg/DFGOSRExitFuzz.h: 54 (JSC::DFG::doOSRExitFuzzing): 55 * dfg/DFGPlan.cpp: 56 (JSC::DFG::Plan::compileInThreadImpl): 57 * dfg/DFGSpeculativeJIT.cpp: 58 (JSC::DFG::SpeculativeJIT::compileArithSqrt): 59 * dfg/DFGTierUpCheckInjectionPhase.cpp: 60 (JSC::DFG::TierUpCheckInjectionPhase::run): 61 * ftl/FTLCompile.cpp: 62 (JSC::FTL::mmAllocateDataSection): 63 * ftl/FTLJITCode.cpp: 64 (JSC::FTL::JITCode::~JITCode): 65 * ftl/FTLLowerDFGToLLVM.cpp: 66 (JSC::FTL::DFG::LowerDFGToLLVM::callCheck): 67 * ftl/FTLOSRExitCompiler.cpp: 68 (JSC::FTL::compileStub): 69 (JSC::FTL::compileFTLOSRExit): 70 * ftl/FTLState.h: 71 (JSC::FTL::verboseCompilationEnabled): 72 (JSC::FTL::shouldDumpDisassembly): 73 (JSC::FTL::shouldShowDisassembly): Deleted. 74 * heap/Heap.cpp: 75 (JSC::Heap::addToRememberedSet): 76 (JSC::Heap::didFinishCollection): 77 (JSC::Heap::shouldDoFullCollection): 78 * heap/Heap.h: 79 (JSC::Heap::isDeferred): 80 (JSC::Heap::structureIDTable): 81 * heap/HeapStatistics.cpp: 82 (JSC::StorageStatistics::storageCapacity): 83 (JSC::HeapStatistics::dumpObjectStatistics): 84 (JSC::HeapStatistics::showObjectStatistics): Deleted. 85 * heap/HeapStatistics.h: 86 * interpreter/StackVisitor.cpp: 87 (JSC::StackVisitor::Frame::createArguments): 88 * jit/AssemblyHelpers.cpp: 89 (JSC::AssemblyHelpers::callExceptionFuzz): 90 * jit/ExecutableAllocationFuzz.cpp: 91 (JSC::doExecutableAllocationFuzzing): 92 * jit/ExecutableAllocationFuzz.h: 93 (JSC::doExecutableAllocationFuzzingIfEnabled): 94 * jit/JIT.cpp: 95 (JSC::JIT::privateCompile): 96 * jit/JITCode.cpp: 97 (JSC::JITCodeWithCodeRef::~JITCodeWithCodeRef): 98 * jit/PolymorphicCallStubRoutine.cpp: 99 (JSC::PolymorphicCallNode::unlink): 100 (JSC::PolymorphicCallNode::clearCallLinkInfo): 101 (JSC::PolymorphicCallStubRoutine::PolymorphicCallStubRoutine): 102 * jit/Repatch.cpp: 103 (JSC::linkFor): 104 (JSC::unlinkFor): 105 (JSC::linkVirtualFor): 106 * jsc.cpp: 107 (functionEnableExceptionFuzz): 108 (jscmain): 109 * llvm/InitializeLLVM.cpp: 110 (JSC::initializeLLVMImpl): 111 * runtime/ExceptionFuzz.cpp: 112 (JSC::doExceptionFuzzing): 113 * runtime/ExceptionFuzz.h: 114 (JSC::doExceptionFuzzingIfEnabled): 115 * runtime/JSGlobalObject.cpp: 116 (JSC::JSGlobalObject::init): 117 * runtime/Options.cpp: 118 (JSC::recomputeDependentOptions): 119 (JSC::Options::initialize): 120 (JSC::Options::dumpOptionsIfNeeded): 121 (JSC::Options::setOption): 122 (JSC::Options::dumpAllOptions): 123 (JSC::Options::dumpAllOptionsInALine): 124 (JSC::Options::dumpOption): 125 * runtime/Options.h: 126 * runtime/VM.cpp: 127 (JSC::VM::VM): 128 * runtime/VM.h: 129 (JSC::VM::exceptionFuzzingBuffer): 130 * runtime/WriteBarrierInlines.h: 131 (JSC::WriteBarrierBase<T>::set): 132 (JSC::WriteBarrierBase<Unknown>::set): 133 * tests/executableAllocationFuzz.yaml: 134 * tests/stress/arrowfunction-typeof.js: 135 * tests/stress/disable-function-dot-arguments.js: 136 (foo): 137 * tests/stress/math-sqrt-basics-disable-architecture-specific-optimizations.js: 138 (sqrtOnInteger): 139 * tests/stress/regress-148564.js: 140 1 141 2015-10-14 Mark Lam <mark.lam@apple.com> 2 142 -
trunk/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h
r190860 r191058 70 70 inline bool optimizeForARMv7IDIVSupported() 71 71 { 72 return isARMv7IDIVSupported() && Options:: enableArchitectureSpecificOptimizations();72 return isARMv7IDIVSupported() && Options::useArchitectureSpecificOptimizations(); 73 73 } 74 74 75 75 inline bool optimizeForARM64() 76 76 { 77 return isARM64() && Options:: enableArchitectureSpecificOptimizations();77 return isARM64() && Options::useArchitectureSpecificOptimizations(); 78 78 } 79 79 80 80 inline bool optimizeForX86() 81 81 { 82 return isX86() && Options:: enableArchitectureSpecificOptimizations();82 return isX86() && Options::useArchitectureSpecificOptimizations(); 83 83 } 84 84 -
trunk/Source/JavaScriptCore/assembler/LinkBuffer.cpp
r190860 r191058 38 38 namespace JSC { 39 39 40 bool should ShowDisassemblyFor(CodeBlock* codeBlock)41 { 42 if (JITCode::isOptimizingJIT(codeBlock->jitType()) && Options:: showDFGDisassembly())40 bool shouldDumpDisassemblyFor(CodeBlock* codeBlock) 41 { 42 if (JITCode::isOptimizingJIT(codeBlock->jitType()) && Options::dumpDFGDisassembly()) 43 43 return true; 44 return Options:: showDisassembly();44 return Options::dumpDisassembly(); 45 45 } 46 46 -
trunk/Source/JavaScriptCore/assembler/LinkBuffer.h
r190860 r191058 326 326 : (linkBufferReference).finalizeCodeWithoutDisassembly()) 327 327 328 bool should ShowDisassemblyFor(CodeBlock*);328 bool shouldDumpDisassemblyFor(CodeBlock*); 329 329 330 330 #define FINALIZE_CODE_FOR(codeBlock, linkBufferReference, dataLogFArgumentsForHeading) \ 331 FINALIZE_CODE_IF(should ShowDisassemblyFor(codeBlock) || Options::asyncDisassembly(), linkBufferReference, dataLogFArgumentsForHeading)331 FINALIZE_CODE_IF(shouldDumpDisassemblyFor(codeBlock) || Options::asyncDisassembly(), linkBufferReference, dataLogFArgumentsForHeading) 332 332 333 333 // Use this to finalize code, like so: … … 344 344 // ... and so on. 345 345 // 346 // Note that the dataLogFArgumentsForHeading are only evaluated when showDisassembly346 // Note that the dataLogFArgumentsForHeading are only evaluated when dumpDisassembly 347 347 // is true, so you can hide expensive disassembly-only computations inside there. 348 348 349 349 #define FINALIZE_CODE(linkBufferReference, dataLogFArgumentsForHeading) \ 350 FINALIZE_CODE_IF(JSC::Options::asyncDisassembly() || JSC::Options:: showDisassembly(), linkBufferReference, dataLogFArgumentsForHeading)350 FINALIZE_CODE_IF(JSC::Options::asyncDisassembly() || JSC::Options::dumpDisassembly(), linkBufferReference, dataLogFArgumentsForHeading) 351 351 352 352 #define FINALIZE_DFG_CODE(linkBufferReference, dataLogFArgumentsForHeading) \ 353 FINALIZE_CODE_IF(JSC::Options::asyncDisassembly() || JSC::Options:: showDisassembly() || Options::showDFGDisassembly(), linkBufferReference, dataLogFArgumentsForHeading)353 FINALIZE_CODE_IF(JSC::Options::asyncDisassembly() || JSC::Options::dumpDisassembly() || Options::dumpDFGDisassembly(), linkBufferReference, dataLogFArgumentsForHeading) 354 354 355 355 } // namespace JSC -
trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp
r191046 r191058 3143 3143 3144 3144 #if ENABLE(DFG_JIT) 3145 if (DFG::should ShowDisassembly()) {3145 if (DFG::shouldDumpDisassembly()) { 3146 3146 dataLog("Jettisoning ", *this); 3147 3147 if (mode == CountReoptimization) … … 3154 3154 3155 3155 if (reason == Profiler::JettisonDueToWeakReference) { 3156 if (DFG::should ShowDisassembly()) {3156 if (DFG::shouldDumpDisassembly()) { 3157 3157 dataLog(*this, " will be jettisoned because of the following dead references:\n"); 3158 3158 DFG::CommonData* dfgCommon = m_jitCode->dfgCommon(); … … 3196 3196 } 3197 3197 3198 if (DFG::should ShowDisassembly())3198 if (DFG::shouldDumpDisassembly()) 3199 3199 dataLog(" Did invalidate ", *this, "\n"); 3200 3200 … … 3204 3204 // https://bugs.webkit.org/show_bug.cgi?id=123677 3205 3205 baselineAlternative()->countReoptimization(); 3206 if (DFG::should ShowDisassembly())3206 if (DFG::shouldDumpDisassembly()) 3207 3207 dataLog(" Did count reoptimization for ", *this, "\n"); 3208 3208 } … … 3226 3226 3227 3227 #if ENABLE(DFG_JIT) 3228 if (DFG::should ShowDisassembly())3228 if (DFG::shouldDumpDisassembly()) 3229 3229 dataLog(" Did install baseline version of ", *this, "\n"); 3230 3230 #endif // ENABLE(DFG_JIT) -
trunk/Source/JavaScriptCore/bytecode/CodeBlockJettisoningWatchpoint.cpp
r187780 r191058 35 35 void CodeBlockJettisoningWatchpoint::fireInternal(const FireDetail& detail) 36 36 { 37 if (DFG::should ShowDisassembly())37 if (DFG::shouldDumpDisassembly()) 38 38 dataLog("Firing watchpoint ", RawPointer(this), " on ", *m_codeBlock, "\n"); 39 39 -
trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
r190108 r191058 199 199 // compatible with tail calls (we have no way of emitting op_did_call). 200 200 // https://bugs.webkit.org/show_bug.cgi?id=148819 201 , m_inTailPosition(Options:: enableTailCalls() && constructorKind() == ConstructorKind::None && isStrictMode() && !m_shouldEmitProfileHooks)201 , m_inTailPosition(Options::useTailCalls() && constructorKind() == ConstructorKind::None && isStrictMode() && !m_shouldEmitProfileHooks) 202 202 { 203 203 for (auto& constantRegister : m_linkTimeConstantRegisters) -
trunk/Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp
r190555 r191058 70 70 } 71 71 72 if (DFG::should ShowDisassembly()) {72 if (DFG::shouldDumpDisassembly()) { 73 73 dataLog( 74 74 "Firing watchpoint ", RawPointer(this), " (", m_key, ") on ", *m_codeBlock, "\n"); -
trunk/Source/JavaScriptCore/dfg/DFGAdaptiveStructureWatchpoint.cpp
r190555 r191058 58 58 } 59 59 60 if (DFG::should ShowDisassembly()) {60 if (DFG::shouldDumpDisassembly()) { 61 61 dataLog( 62 62 "Firing watchpoint ", RawPointer(this), " (", m_key, ") on ", *m_codeBlock, "\n"); -
trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
r190827 r191058 1764 1764 // we could improve that aspect of this by doing polymorphic inlining but having the profiling 1765 1765 // also. 1766 if (!isFTL(m_graph.m_plan.mode) || !Options:: enablePolymorphicCallInlining()1766 if (!isFTL(m_graph.m_plan.mode) || !Options::usePolymorphicCallInlining() 1767 1767 || InlineCallFrame::isVarargs(kind)) { 1768 1768 if (verbose) { … … 2744 2744 NodeType getById = getByIdStatus.makesCalls() ? GetByIdFlush : GetById; 2745 2745 2746 if (!getByIdStatus.isSimple() || !getByIdStatus.numVariants() || !Options:: enableAccessInlining()) {2746 if (!getByIdStatus.isSimple() || !getByIdStatus.numVariants() || !Options::useAccessInlining()) { 2747 2747 set(VirtualRegister(destinationOperand), 2748 2748 addToGraph(getById, OpInfo(identifierNumber), OpInfo(prediction), base)); … … 2752 2752 if (getByIdStatus.numVariants() > 1) { 2753 2753 if (getByIdStatus.makesCalls() || !isFTL(m_graph.m_plan.mode) 2754 || !Options:: enablePolymorphicAccessInlining()) {2754 || !Options::usePolymorphicAccessInlining()) { 2755 2755 set(VirtualRegister(destinationOperand), 2756 2756 addToGraph(getById, OpInfo(identifierNumber), OpInfo(prediction), base)); … … 2867 2867 const PutByIdStatus& putByIdStatus, bool isDirect) 2868 2868 { 2869 if (!putByIdStatus.isSimple() || !putByIdStatus.numVariants() || !Options:: enableAccessInlining()) {2869 if (!putByIdStatus.isSimple() || !putByIdStatus.numVariants() || !Options::useAccessInlining()) { 2870 2870 if (!putByIdStatus.isSet()) 2871 2871 addToGraph(ForceOSRExit); … … 2876 2876 if (putByIdStatus.numVariants() > 1) { 2877 2877 if (!isFTL(m_graph.m_plan.mode) || putByIdStatus.makesCalls() 2878 || !Options:: enablePolymorphicAccessInlining()) {2878 || !Options::usePolymorphicAccessInlining()) { 2879 2879 emitPutById(base, identifierNumber, value, putByIdStatus, isDirect); 2880 2880 return; … … 4831 4831 m_dfgCodeBlock = m_graph.m_plan.profiledDFGCodeBlock; 4832 4832 if (isFTL(m_graph.m_plan.mode) && m_dfgCodeBlock 4833 && Options:: enablePolyvariantDevirtualization()) {4834 if (Options:: enablePolyvariantCallInlining())4833 && Options::usePolyvariantDevirtualization()) { 4834 if (Options::usePolyvariantCallInlining()) 4835 4835 CallLinkStatus::computeDFGStatuses(m_dfgCodeBlock, m_callContextMap); 4836 if (Options:: enablePolyvariantByIdInlining())4836 if (Options::usePolyvariantByIdInlining()) 4837 4837 m_dfgCodeBlock->getStubInfoMap(m_dfgStubInfos); 4838 4838 } -
trunk/Source/JavaScriptCore/dfg/DFGCommon.h
r188850 r191058 367 367 368 368 // Unconditionally disable DFG disassembly support if the DFG is not compiled in. 369 inline bool should ShowDisassembly(CompilationMode mode = DFGMode)369 inline bool shouldDumpDisassembly(CompilationMode mode = DFGMode) 370 370 { 371 371 #if ENABLE(DFG_JIT) 372 return Options:: showDisassembly() || Options::showDFGDisassembly() || (isFTL(mode) && Options::showFTLDisassembly());372 return Options::dumpDisassembly() || Options::dumpDFGDisassembly() || (isFTL(mode) && Options::dumpFTLDisassembly()); 373 373 #else 374 374 UNUSED_PARAM(mode); -
trunk/Source/JavaScriptCore/dfg/DFGDriver.cpp
r190827 r191058 92 92 93 93 plan->callback = callback; 94 if (Options:: enableConcurrentJIT()) {94 if (Options::useConcurrentJIT()) { 95 95 Worklist* worklist = ensureGlobalWorklistFor(mode); 96 96 if (logCompilationChanges(mode)) -
trunk/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp
r190735 r191058 54 54 , m_blockHeads(dfg.numBlocks()) 55 55 { 56 if (should ShowDisassembly() || m_graph.m_vm.m_perBytecodeProfiler)56 if (shouldDumpDisassembly() || m_graph.m_vm.m_perBytecodeProfiler) 57 57 m_disassembler = std::make_unique<Disassembler>(dfg); 58 58 } … … 474 474 void JITCompiler::disassemble(LinkBuffer& linkBuffer) 475 475 { 476 if (should ShowDisassembly()) {476 if (shouldDumpDisassembly()) { 477 477 m_disassembler->dump(linkBuffer); 478 478 linkBuffer.didAlreadyDisassemble(); -
trunk/Source/JavaScriptCore/dfg/DFGJumpReplacement.cpp
r164229 r191058 37 37 void JumpReplacement::fire() 38 38 { 39 if (Options:: showDisassembly())39 if (Options::dumpDisassembly()) 40 40 dataLogF("Firing jump replacement watchpoint from %p, to %p.\n", m_source.dataLocation(), m_destination.dataLocation()); 41 41 MacroAssembler::replaceWithJump(m_source, m_destination); -
trunk/Source/JavaScriptCore/dfg/DFGOSREntry.cpp
r189575 r191058 99 99 ASSERT(!codeBlock->jitCodeMap()); 100 100 101 if (!Options:: enableOSREntryToDFG())101 if (!Options::useOSREntryToDFG()) 102 102 return 0; 103 103 -
trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler.cpp
r189995 r191058 164 164 LinkBuffer patchBuffer(*vm, jit, codeBlock); 165 165 exit.m_code = FINALIZE_CODE_IF( 166 should ShowDisassembly() || Options::verboseOSR(),166 shouldDumpDisassembly() || Options::verboseOSR(), 167 167 patchBuffer, 168 168 ("DFG OSR exit #%u (%s, %s) from %s, with operands = %s", -
trunk/Source/JavaScriptCore/dfg/DFGOSRExitFuzz.h
r186605 r191058 35 35 inline bool doOSRExitFuzzing() 36 36 { 37 if (!Options:: enableOSRExitFuzz())37 if (!Options::useOSRExitFuzz()) 38 38 return false; 39 39 -
trunk/Source/JavaScriptCore/dfg/DFGPlan.cpp
r190896 r191058 264 264 performLiveCatchVariablePreservationPhase(dfg); 265 265 266 if (Options:: enableMaximalFlushInsertionPhase())266 if (Options::useMaximalFlushInsertionPhase()) 267 267 performMaximalFlushInsertion(dfg); 268 268 … … 360 360 performCPSRethreading(dfg); 361 361 performDCE(dfg); 362 if (Options:: enableCopyBarrierOptimization())362 if (Options::useCopyBarrierOptimization()) 363 363 performCopyBarrierOptimization(dfg); 364 364 performPhantomInsertion(dfg); … … 407 407 changed = false; 408 408 changed |= performStrengthReduction(dfg); 409 if (Options:: enableObjectAllocationSinking()) {409 if (Options::useObjectAllocationSinking()) { 410 410 changed |= performCriticalEdgeBreaking(dfg); 411 411 changed |= performObjectAllocationSinking(dfg); … … 437 437 performCFA(dfg); 438 438 performGlobalStoreBarrierInsertion(dfg); 439 if (Options:: enableMovHintRemoval())439 if (Options::useMovHintRemoval()) 440 440 performMovHintRemoval(dfg); 441 441 performCleanUp(dfg); 442 442 performDCE(dfg); // We rely on this to kill dead code that won't be recognized as dead by LLVM. 443 if (Options:: enableCopyBarrierOptimization())443 if (Options::useCopyBarrierOptimization()) 444 444 performCopyBarrierOptimization(dfg); 445 445 performStackLayout(dfg); … … 453 453 } 454 454 455 dumpAndVerifyGraph(dfg, "Graph just before FTL lowering:", should ShowDisassembly(mode));455 dumpAndVerifyGraph(dfg, "Graph just before FTL lowering:", shouldDumpDisassembly(mode)); 456 456 457 457 bool haveLLVM; -
trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
r190896 r191058 3735 3735 FPRReg op1FPR = op1.fpr(); 3736 3736 3737 if (!MacroAssembler::supportsFloatingPointSqrt() || !Options:: enableArchitectureSpecificOptimizations()) {3737 if (!MacroAssembler::supportsFloatingPointSqrt() || !Options::useArchitectureSpecificOptimizations()) { 3738 3738 flushRegisters(); 3739 3739 FPRResult result(this); -
trunk/Source/JavaScriptCore/dfg/DFGTierUpCheckInjectionPhase.cpp
r190370 r191058 62 62 return false; 63 63 64 if (!Options:: enableOSREntryToFTL())64 if (!Options::useOSREntryToFTL()) 65 65 level = FTL::CanCompile; 66 66 -
trunk/Source/JavaScriptCore/ftl/FTLCompile.cpp
r190885 r191058 845 845 } 846 846 847 if (should ShowDisassembly() || verboseCompilationEnabled())847 if (shouldDumpDisassembly() || verboseCompilationEnabled()) 848 848 state.dumpState(module, "after optimization"); 849 849 … … 864 864 return; 865 865 866 if (should ShowDisassembly()) {866 if (shouldDumpDisassembly()) { 867 867 for (unsigned i = 0; i < state.jitCode->handles().size(); ++i) { 868 868 ExecutableMemoryHandle* handle = state.jitCode->handles()[i].get(); … … 889 889 state.unwindDataSection, state.unwindDataSectionSize, 890 890 state.generatedFunction); 891 if (should ShowDisassembly()) {891 if (shouldDumpDisassembly()) { 892 892 dataLog("Unwind info for ", CodeBlockWithJITType(state.graph.m_codeBlock, JITCode::FTLJIT), ":\n"); 893 893 dataLog(" ", *registerOffsets, "\n"); … … 896 896 897 897 if (state.stackmapsSection && state.stackmapsSection->size()) { 898 if (should ShowDisassembly()) {898 if (shouldDumpDisassembly()) { 899 899 dataLog( 900 900 "Generated LLVM stackmaps section for ", … … 908 908 state.jitCode->stackmaps.parse(stackmapsData.get()); 909 909 910 if (should ShowDisassembly()) {910 if (shouldDumpDisassembly()) { 911 911 dataLog(" Structured data:\n"); 912 912 state.jitCode->stackmaps.dumpMultiline(WTF::dataFile(), " "); … … 920 920 return; 921 921 922 if (should ShowDisassembly() || Options::asyncDisassembly()) {922 if (shouldDumpDisassembly() || Options::asyncDisassembly()) { 923 923 for (unsigned i = 0; i < state.jitCode->handles().size(); ++i) { 924 924 if (state.codeSectionNames[i] != SECTION_NAME("text")) -
trunk/Source/JavaScriptCore/ftl/FTLJITCode.cpp
r190735 r191058 40 40 JITCode::~JITCode() 41 41 { 42 if (FTL::should ShowDisassembly()) {42 if (FTL::shouldDumpDisassembly()) { 43 43 dataLog("Destroying FTL JIT code at "); 44 44 CommaPrinter comma; -
trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp
r190916 r191058 8624 8624 void callCheck() 8625 8625 { 8626 if (Options:: enableExceptionFuzz())8626 if (Options::useExceptionFuzz()) 8627 8627 m_out.call(m_out.operation(operationExceptionFuzz), m_callFrame); 8628 8628 -
trunk/Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp
r190258 r191058 493 493 LinkBuffer patchBuffer(*vm, jit, codeBlock); 494 494 exit.m_code = FINALIZE_CODE_IF( 495 should ShowDisassembly() || Options::verboseOSR() || Options::verboseFTLOSRExit(),495 shouldDumpDisassembly() || Options::verboseOSR() || Options::verboseFTLOSRExit(), 496 496 patchBuffer, 497 497 ("FTL OSR exit #%u (%s, %s) from %s, with operands = %s, and record = %s", … … 506 506 SamplingRegion samplingRegion("FTL OSR Exit Compilation"); 507 507 508 if (should ShowDisassembly() || Options::verboseOSR() || Options::verboseFTLOSRExit())508 if (shouldDumpDisassembly() || Options::verboseOSR() || Options::verboseFTLOSRExit()) 509 509 dataLog("Compiling OSR exit with exitID = ", exitID, "\n"); 510 510 … … 523 523 OSRExit& exit = jitCode->osrExit[exitID]; 524 524 525 if (should ShowDisassembly() || Options::verboseOSR() || Options::verboseFTLOSRExit()) {525 if (shouldDumpDisassembly() || Options::verboseOSR() || Options::verboseFTLOSRExit()) { 526 526 dataLog(" Owning block: ", pointerDump(codeBlock), "\n"); 527 527 dataLog(" Origin: ", exit.m_codeOrigin, "\n"); -
trunk/Source/JavaScriptCore/ftl/FTLState.h
r190860 r191058 50 50 } 51 51 52 inline bool should ShowDisassembly()52 inline bool shouldDumpDisassembly() 53 53 { 54 return DFG::should ShowDisassembly(DFG::FTLMode);54 return DFG::shouldDumpDisassembly(DFG::FTLMode); 55 55 } 56 56 -
trunk/Source/JavaScriptCore/heap/Heap.cpp
r190896 r191058 990 990 { 991 991 ASSERT(cell); 992 ASSERT(!Options:: enableConcurrentJIT() || !isCompilationThread());992 ASSERT(!Options::useConcurrentJIT() || !isCompilationThread()); 993 993 ASSERT(cell->cellState() == CellState::OldBlack); 994 994 // Indicate that this object is grey and that it's one of the following: … … 1318 1318 zombifyDeadObjects(); 1319 1319 1320 if (Options:: objectsAreImmortal())1320 if (Options::useImmortalObjects()) 1321 1321 markDeadObjects(); 1322 1322 1323 if (Options:: showObjectStatistics())1324 HeapStatistics:: showObjectStatistics(this);1323 if (Options::dumpObjectStatistics()) 1324 HeapStatistics::dumpObjectStatistics(this); 1325 1325 1326 1326 if (Options::logGC() == GCLogging::Verbose) … … 1480 1480 bool Heap::shouldDoFullCollection(HeapOperation requestedCollectionType) const 1481 1481 { 1482 if ( Options::alwaysDoFullCollection())1482 if (!Options::useGenerationalGC()) 1483 1483 return true; 1484 1484 -
trunk/Source/JavaScriptCore/heap/Heap.h
r190896 r191058 222 222 void addReference(JSCell*, ArrayBuffer*); 223 223 224 bool isDeferred() const { return !!m_deferralDepth || Options::disableGC(); }224 bool isDeferred() const { return !!m_deferralDepth || !Options::useGC(); } 225 225 226 226 StructureIDTable& structureIDTable() { return m_structureIDTable; } -
trunk/Source/JavaScriptCore/heap/HeapStatistics.cpp
r190739 r191058 217 217 } 218 218 219 void HeapStatistics:: showObjectStatistics(Heap* heap)219 void HeapStatistics::dumpObjectStatistics(Heap* heap) 220 220 { 221 221 dataLogF("\n=== Heap Statistics: ===\n"); -
trunk/Source/JavaScriptCore/heap/HeapStatistics.h
r190739 r191058 42 42 static void recordGCPauseTime(double start, double end); 43 43 44 static void showObjectStatistics(Heap*);44 static void dumpObjectStatistics(Heap*); 45 45 46 46 private: -
trunk/Source/JavaScriptCore/interpreter/StackVisitor.cpp
r190827 r191058 284 284 ClonedArguments* arguments; 285 285 ArgumentsMode mode; 286 if (Options:: enableFunctionDotArguments())286 if (Options::useFunctionDotArguments()) 287 287 mode = ArgumentsMode::Cloned; 288 288 else -
trunk/Source/JavaScriptCore/jit/AssemblyHelpers.cpp
r190916 r191058 289 289 void AssemblyHelpers::callExceptionFuzz() 290 290 { 291 if (!Options:: enableExceptionFuzz())291 if (!Options::useExceptionFuzz()) 292 292 return; 293 293 -
trunk/Source/JavaScriptCore/jit/ExecutableAllocationFuzz.cpp
r181990 r191058 41 41 ExecutableAllocationFuzzResult doExecutableAllocationFuzzing() 42 42 { 43 ASSERT(Options:: enableExecutableAllocationFuzz());43 ASSERT(Options::useExecutableAllocationFuzz()); 44 44 45 45 unsigned oldValue; -
trunk/Source/JavaScriptCore/jit/ExecutableAllocationFuzz.h
r181990 r191058 40 40 inline ExecutableAllocationFuzzResult doExecutableAllocationFuzzingIfEnabled() 41 41 { 42 if (LIKELY(!Options:: enableExecutableAllocationFuzz()))42 if (LIKELY(!Options::useExecutableAllocationFuzz())) 43 43 return AllowNormalExecutableAllocation; 44 44 -
trunk/Source/JavaScriptCore/jit/JIT.cpp
r190896 r191058 501 501 m_vm->typeProfilerLog()->processLogEntries(ASCIILiteral("Preparing for JIT compilation.")); 502 502 503 if (Options:: showDisassembly() || m_vm->m_perBytecodeProfiler)503 if (Options::dumpDisassembly() || m_vm->m_perBytecodeProfiler) 504 504 m_disassembler = std::make_unique<JITDisassembler>(m_codeBlock); 505 505 if (m_vm->m_perBytecodeProfiler) { … … 692 692 withArityCheck = patchBuffer.locationOf(arityCheck); 693 693 694 if (Options:: showDisassembly()) {694 if (Options::dumpDisassembly()) { 695 695 m_disassembler->dump(patchBuffer); 696 696 patchBuffer.didAlreadyDisassemble(); -
trunk/Source/JavaScriptCore/jit/JITCode.cpp
r190741 r191058 119 119 JITCodeWithCodeRef::~JITCodeWithCodeRef() 120 120 { 121 if ((Options:: showDisassembly() || (isOptimizingJIT(jitType()) && Options::showDFGDisassembly()))121 if ((Options::dumpDisassembly() || (isOptimizingJIT(jitType()) && Options::dumpDFGDisassembly())) 122 122 && m_ref.executableMemory()) 123 123 dataLog("Destroying JIT code at ", pointerDump(m_ref.executableMemory()), "\n"); -
trunk/Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp
r189288 r191058 45 45 { 46 46 if (m_callLinkInfo) { 47 if (Options:: showDisassembly())47 if (Options::dumpDisassembly()) 48 48 dataLog("Unlinking polymorphic call at ", m_callLinkInfo->callReturnLocation(), ", ", m_callLinkInfo->codeOrigin(), "\n"); 49 49 … … 57 57 void PolymorphicCallNode::clearCallLinkInfo() 58 58 { 59 if (Options:: showDisassembly())59 if (Options::dumpDisassembly()) 60 60 dataLog("Clearing call link info for polymorphic call at ", m_callLinkInfo->callReturnLocation(), ", ", m_callLinkInfo->codeOrigin(), "\n"); 61 61 … … 77 77 for (PolymorphicCallCase callCase : cases) { 78 78 m_variants.append(WriteBarrier<JSCell>(vm, owner, callCase.variant().rawCalleeCell())); 79 if (should ShowDisassemblyFor(callerFrame->codeBlock()))79 if (shouldDumpDisassemblyFor(callerFrame->codeBlock())) 80 80 dataLog("Linking polymorphic call in ", *callerFrame->codeBlock(), " at ", callerFrame->codeOrigin(), " to ", callCase.variant(), ", codeBlock = ", pointerDump(callCase.codeBlock()), "\n"); 81 81 if (CodeBlock* codeBlock = callCase.codeBlock()) -
trunk/Source/JavaScriptCore/jit/Repatch.cpp
r190888 r191058 551 551 callLinkInfo.setCallee(exec->callerFrame()->vm(), callLinkInfo.hotPathBegin(), callerCodeBlock, callee); 552 552 callLinkInfo.setLastSeenCallee(exec->callerFrame()->vm(), callerCodeBlock, callee); 553 if (should ShowDisassemblyFor(callerCodeBlock))553 if (shouldDumpDisassemblyFor(callerCodeBlock)) 554 554 dataLog("Linking call in ", *callerCodeBlock, " at ", callLinkInfo.codeOrigin(), " to ", pointerDump(calleeCodeBlock), ", entrypoint at ", codePtr, "\n"); 555 555 MacroAssembler::repatchNearCall(callLinkInfo.hotPathOther(), CodeLocationLabel(codePtr)); … … 591 591 void unlinkFor(VM& vm, CallLinkInfo& callLinkInfo) 592 592 { 593 if (Options:: showDisassembly())593 if (Options::dumpDisassembly()) 594 594 dataLog("Unlinking call from ", callLinkInfo.callReturnLocation(), "\n"); 595 595 … … 603 603 VM* vm = callerCodeBlock->vm(); 604 604 605 if (should ShowDisassemblyFor(callerCodeBlock))605 if (shouldDumpDisassemblyFor(callerCodeBlock)) 606 606 dataLog("Linking virtual call at ", *callerCodeBlock, " ", exec->callerFrame()->codeOrigin(), "\n"); 607 607 -
trunk/Source/JavaScriptCore/jsc.cpp
r190735 r191058 1490 1490 EncodedJSValue JSC_HOST_CALL functionEnableExceptionFuzz(ExecState*) 1491 1491 { 1492 Options:: enableExceptionFuzz() = true;1492 Options::useExceptionFuzz() = true; 1493 1493 return JSValue::encode(jsUndefined()); 1494 1494 } … … 1963 1963 1964 1964 #if ENABLE(JIT) 1965 if (Options:: enableExceptionFuzz())1965 if (Options::useExceptionFuzz()) 1966 1966 printf("JSC EXCEPTION FUZZ: encountered %u checks.\n", numberOfExceptionFuzzChecks()); 1967 1967 bool fireAtEnabled = 1968 1968 Options::fireExecutableAllocationFuzzAt() || Options::fireExecutableAllocationFuzzAtOrAfter(); 1969 if (Options:: enableExecutableAllocationFuzz() && (!fireAtEnabled || Options::verboseExecutableAllocationFuzz()))1969 if (Options::useExecutableAllocationFuzz() && (!fireAtEnabled || Options::verboseExecutableAllocationFuzz())) 1970 1970 printf("JSC EXECUTABLE ALLOCATION FUZZ: encountered %u checks.\n", numberOfExecutableAllocationFuzzChecks()); 1971 if (Options:: enableOSRExitFuzz()) {1971 if (Options::useOSRExitFuzz()) { 1972 1972 printf("JSC OSR EXIT FUZZ: encountered %u static checks.\n", numberOfStaticOSRExitFuzzChecks()); 1973 1973 printf("JSC OSR EXIT FUZZ: encountered %u dynamic checks.\n", numberOfOSRExitFuzzChecks()); -
trunk/Source/JavaScriptCore/llvm/InitializeLLVM.cpp
r182483 r191058 42 42 const bool verbose = 43 43 Options::verboseFTLCompilation() 44 || Options:: showFTLDisassembly()44 || Options::dumpFTLDisassembly() 45 45 || Options::verboseFTLFailure() 46 46 || Options::verboseCompilation() 47 || Options:: showDFGDisassembly()48 || Options:: showDisassembly();47 || Options::dumpDFGDisassembly() 48 || Options::dumpDisassembly(); 49 49 50 50 LLVMInitializerFunction initializer = getLLVMInitializerFunction(verbose); … … 52 52 return; 53 53 54 bool enableFastISel = Options:: enableLLVMFastISel();54 bool enableFastISel = Options::useLLVMFastISel(); 55 55 llvm = initializer(WTFLogAlwaysAndCrash, &enableFastISel); 56 56 if (!llvm) { … … 58 58 dataLog("LLVM initilization failed.\n"); 59 59 } 60 if (Options:: enableLLVMFastISel() && !enableFastISel) {60 if (Options::useLLVMFastISel() && !enableFastISel) { 61 61 if (verbose) 62 62 dataLog("Fast ISel requested but LLVM not new enough.\n"); -
trunk/Source/JavaScriptCore/runtime/ExceptionFuzz.cpp
r182495 r191058 39 39 void doExceptionFuzzing(ExecState* exec, const char* where, void* returnPC) 40 40 { 41 ASSERT(Options:: enableExceptionFuzz());41 ASSERT(Options::useExceptionFuzz()); 42 42 43 43 DeferGCForAWhile deferGC(exec->vm().heap); -
trunk/Source/JavaScriptCore/runtime/ExceptionFuzz.h
r171350 r191058 39 39 ALWAYS_INLINE void doExceptionFuzzingIfEnabled(ExecState* exec, const char* where, void* returnPC) 40 40 { 41 if (LIKELY(!Options:: enableExceptionFuzz()))41 if (LIKELY(!Options::useExceptionFuzz())) 42 42 return; 43 43 doExceptionFuzzing(exec, where, returnPC); -
trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp
r190429 r191058 553 553 putDirectWithoutTransition(vm, Identifier::fromString(exec, "console"), consoleObject, DontEnum); 554 554 555 if (UNLIKELY(Options:: enableDollarVM())) {555 if (UNLIKELY(Options::useDollarVM())) { 556 556 JSDollarVMPrototype* dollarVMPrototype = JSDollarVMPrototype::create(vm, this, JSDollarVMPrototype::createStructure(vm, this, m_objectPrototype.get())); 557 557 m_dollarVMStructure.set(vm, this, JSDollarVM::createStructure(vm, this, dollarVMPrototype)); -
trunk/Source/JavaScriptCore/runtime/Options.cpp
r190739 r191058 263 263 #endif 264 264 #if !ENABLE(CONCURRENT_JIT) 265 Options:: enableConcurrentJIT() = false;265 Options::useConcurrentJIT() = false; 266 266 #endif 267 267 #if !ENABLE(DFG_JIT) … … 277 277 Options::useJIT() = false; 278 278 #endif 279 if (Options:: showDisassembly()280 || Options:: showDFGDisassembly()281 || Options:: showFTLDisassembly()279 if (Options::dumpDisassembly() 280 || Options::dumpDFGDisassembly() 281 || Options::dumpFTLDisassembly() 282 282 || Options::dumpBytecodeAtDFGTime() 283 283 || Options::dumpGraphAtEachPhase() … … 307 307 Options::thresholdForFTLOptimizeSoon() = 20; 308 308 Options::maximumEvalCacheableSourceLength() = 150000; 309 Options:: enableConcurrentJIT() = false;310 } 311 if (Options:: enableMaximalFlushInsertionPhase()) {312 Options:: enableOSREntryToDFG() = false;313 Options:: enableOSREntryToFTL() = false;309 Options::useConcurrentJIT() = false; 310 } 311 if (Options::useMaximalFlushInsertionPhase()) { 312 Options::useOSREntryToDFG() = false; 313 Options::useOSREntryToFTL() = false; 314 314 } 315 315 … … 343 343 // It *probably* makes sense for other platforms to enable this. 344 344 #if PLATFORM(IOS) && CPU(ARM64) 345 enableLLVMFastISel() = true;345 useLLVMFastISel() = true; 346 346 #endif 347 347 … … 397 397 void Options::dumpOptionsIfNeeded() 398 398 { 399 if (Options:: showOptions()) {400 DumpLevel level = static_cast<DumpLevel>(Options:: showOptions());399 if (Options::dumpOptions()) { 400 DumpLevel level = static_cast<DumpLevel>(Options::dumpOptions()); 401 401 if (level > DumpLevel::Verbose) 402 402 level = DumpLevel::Verbose; … … 418 418 419 419 StringBuilder builder; 420 dumpAllOptions(builder, level, title, nullptr, " ", "\n", ShowDefaults);420 dumpAllOptions(builder, level, title, nullptr, " ", "\n", DumpDefaults); 421 421 dataLog(builder.toString()); 422 422 } … … 529 529 530 530 void Options::dumpAllOptions(StringBuilder& builder, DumpLevel level, const char* title, 531 const char* separator, const char* optionHeader, const char* optionFooter, ShowDefaultsOption showDefaultsOption)531 const char* separator, const char* optionHeader, const char* optionFooter, DumpDefaultsOption dumpDefaultsOption) 532 532 { 533 533 if (title) { … … 539 539 if (separator && id) 540 540 builder.append(separator); 541 dumpOption(builder, level, static_cast<OptionID>(id), optionHeader, optionFooter, showDefaultsOption);541 dumpOption(builder, level, static_cast<OptionID>(id), optionHeader, optionFooter, dumpDefaultsOption); 542 542 } 543 543 } … … 545 545 void Options::dumpAllOptionsInALine(StringBuilder& builder) 546 546 { 547 dumpAllOptions(builder, DumpLevel::All, nullptr, " ", nullptr, nullptr, Dont ShowDefaults);547 dumpAllOptions(builder, DumpLevel::All, nullptr, " ", nullptr, nullptr, DontDumpDefaults); 548 548 } 549 549 … … 551 551 { 552 552 StringBuilder builder; 553 dumpAllOptions(builder, level, title, nullptr, " ", "\n", ShowDefaults);553 dumpAllOptions(builder, level, title, nullptr, " ", "\n", DumpDefaults); 554 554 fprintf(stream, "%s", builder.toString().ascii().data()); 555 555 } 556 556 557 557 void Options::dumpOption(StringBuilder& builder, DumpLevel level, OptionID id, 558 const char* header, const char* footer, ShowDefaultsOption showDefaultsOption)558 const char* header, const char* footer, DumpDefaultsOption dumpDefaultsOption) 559 559 { 560 560 if (id >= numberOfOptions) … … 574 574 option.dump(builder); 575 575 576 if (wasOverridden && ( showDefaultsOption == ShowDefaults)) {576 if (wasOverridden && (dumpDefaultsOption == DumpDefaults)) { 577 577 builder.append(" (default: "); 578 578 option.defaultOption().dump(builder); -
trunk/Source/JavaScriptCore/runtime/Options.h
r190896 r191058 103 103 104 104 #define JSC_OPTIONS(v) \ 105 v(unsigned, showOptions, 0, "shows JSC options (0 = None, 1 = Overridden only, 2 = All, 3 = Verbose)") \105 v(unsigned, dumpOptions, 0, "dumps JSC options (0 = None, 1 = Overridden only, 2 = All, 3 = Verbose)") \ 106 106 \ 107 107 v(bool, useLLInt, true, "allows the LLINT to be used if true") \ … … 131 131 v(bool, forceProfilerBytecodeGeneration, false, nullptr) \ 132 132 \ 133 v(bool, enableFunctionDotArguments, true, nullptr) \134 v(bool, enableTailCalls, false, nullptr) \135 \ 136 /* showDisassembly implies showDFGDisassembly. */ \137 v(bool, showDisassembly, false, "dumps disassembly of all JIT compiled code upon compilation") \133 v(bool, useFunctionDotArguments, true, nullptr) \ 134 v(bool, useTailCalls, false, nullptr) \ 135 \ 136 /* dumpDisassembly implies dumpDFGDisassembly. */ \ 137 v(bool, dumpDisassembly, false, "dumps disassembly of all JIT compiled code upon compilation") \ 138 138 v(bool, asyncDisassembly, false, nullptr) \ 139 v(bool, showDFGDisassembly, false, "dumps disassembly of DFG function upon compilation") \140 v(bool, showFTLDisassembly, false, "dumps disassembly of FTL function upon compilation") \141 v(bool, showAllDFGNodes, false, nullptr) \139 v(bool, dumpDFGDisassembly, false, "dumps disassembly of DFG function upon compilation") \ 140 v(bool, dumpFTLDisassembly, false, "dumps disassembly of FTL function upon compilation") \ 141 v(bool, dumpAllDFGNodes, false, nullptr) \ 142 142 v(optionRange, bytecodeRangeToDFGCompile, 0, "bytecode size range to allow DFG compilation on, e.g. 1:100") \ 143 143 v(optionString, dfgWhitelist, nullptr, "file with list of function signatures to allow DFG compilation on") \ … … 167 167 v(bool, testTheFTL, false, nullptr) \ 168 168 v(bool, verboseSanitizeStack, false, nullptr) \ 169 v(bool, alwaysDoFullCollection, false, nullptr) \169 v(bool, useGenerationalGC, true, nullptr) \ 170 170 v(bool, eagerlyUpdateTopCallFrame, false, nullptr) \ 171 171 \ 172 v(bool, enableOSREntryToDFG, true, nullptr) \173 v(bool, enableOSREntryToFTL, true, nullptr) \172 v(bool, useOSREntryToDFG, true, nullptr) \ 173 v(bool, useOSREntryToFTL, true, nullptr) \ 174 174 \ 175 175 v(bool, useFTLJIT, true, "allows the FTL JIT to be used if true") \ 176 176 v(bool, useFTLTBAA, true, nullptr) \ 177 v(bool, enableLLVMFastISel, false, nullptr) \177 v(bool, useLLVMFastISel, false, nullptr) \ 178 178 v(bool, useLLVMSmallCodeModel, false, nullptr) \ 179 179 v(bool, dumpLLVMIR, false, nullptr) \ … … 191 191 v(bool, clobberAllRegsInFTLICSlowPath, !ASSERT_DISABLED, nullptr) \ 192 192 v(bool, assumeAllRegsInFTLICAreLive, false, nullptr) \ 193 v(bool, enableAccessInlining, true, nullptr) \193 v(bool, useAccessInlining, true, nullptr) \ 194 194 v(unsigned, maxAccessVariantListSize, 8, nullptr) \ 195 v(bool, enablePolyvariantDevirtualization, true, nullptr) \196 v(bool, enablePolymorphicAccessInlining, true, nullptr) \197 v(bool, enablePolymorphicCallInlining, true, nullptr) \195 v(bool, usePolyvariantDevirtualization, true, nullptr) \ 196 v(bool, usePolymorphicAccessInlining, true, nullptr) \ 197 v(bool, usePolymorphicCallInlining, true, nullptr) \ 198 198 v(unsigned, maxPolymorphicCallVariantListSize, 15, nullptr) \ 199 199 v(unsigned, maxPolymorphicCallVariantListSizeForTopTier, 5, nullptr) \ … … 202 202 v(double, minimumCallToKnownRate, 0.51, nullptr) \ 203 203 v(bool, createPreHeaders, true, nullptr) \ 204 v(bool, enableMovHintRemoval, true, nullptr) \205 v(bool, enableObjectAllocationSinking, true, nullptr) \206 v(bool, enableCopyBarrierOptimization, true, nullptr) \207 \ 208 v(bool, enableConcurrentJIT, true, "allows the DFG / FTL compilation in threads other than the executing JS thread") \204 v(bool, useMovHintRemoval, true, nullptr) \ 205 v(bool, useObjectAllocationSinking, true, nullptr) \ 206 v(bool, useCopyBarrierOptimization, true, nullptr) \ 207 \ 208 v(bool, useConcurrentJIT, true, "allows the DFG / FTL compilation in threads other than the executing JS thread") \ 209 209 v(unsigned, numberOfDFGCompilerThreads, computeNumberOfWorkerThreads(2, 2) - 1, nullptr) \ 210 210 v(unsigned, numberOfFTLCompilerThreads, computeNumberOfWorkerThreads(8, 2) - 1, nullptr) \ … … 212 212 v(int32, priorityDeltaOfFTLCompilerThreads, computePriorityDeltaOfWorkerThreads(-2, 0), nullptr) \ 213 213 \ 214 v(bool, enableProfiler, false, nullptr) \214 v(bool, useProfiler, false, nullptr) \ 215 215 \ 216 216 v(bool, forceUDis86Disassembler, false, nullptr) \ 217 217 v(bool, forceLLVMDisassembler, false, nullptr) \ 218 218 \ 219 v(bool, enableArchitectureSpecificOptimizations, true, nullptr) \219 v(bool, useArchitectureSpecificOptimizations, true, nullptr) \ 220 220 \ 221 221 v(bool, breakOnThrow, false, nullptr) \ … … 241 241 v(unsigned, maximumVarargsForInlining, 100, nullptr) \ 242 242 \ 243 v(bool, enablePolyvariantCallInlining, true, nullptr) \244 v(bool, enablePolyvariantByIdInlining, true, nullptr) \245 \ 246 v(bool, enableMaximalFlushInsertionPhase, false, "Setting to true enables the DFG's MaximalFlushInsertionPhase to run.") \243 v(bool, usePolyvariantCallInlining, true, nullptr) \ 244 v(bool, usePolyvariantByIdInlining, true, nullptr) \ 245 \ 246 v(bool, useMaximalFlushInsertionPhase, false, "Setting to true allows the DFG's MaximalFlushInsertionPhase to run.") \ 247 247 \ 248 248 v(unsigned, maximumBinaryStringSwitchCaseLength, 50, nullptr) \ … … 307 307 \ 308 308 v(bool, useZombieMode, false, "debugging option to scribble over dead objects with 0xdeadbeef") \ 309 v(bool, objectsAreImmortal, false, "debugging option to keep all objects alive forever") \310 v(bool, showObjectStatistics, false, nullptr) \309 v(bool, useImmortalObjects, false, "debugging option to keep all objects alive forever") \ 310 v(bool, dumpObjectStatistics, false, nullptr) \ 311 311 \ 312 312 v(gcLogLevel, logGC, GCLogging::None, "debugging option to log GC activity (0 = None, 1 = Basic, 2 = Verbose)") \ 313 v(bool, disableGC, false, nullptr) \313 v(bool, useGC, true, nullptr) \ 314 314 v(unsigned, gcMaxHeapSize, 0, nullptr) \ 315 315 v(unsigned, forceRAMSize, 0, nullptr) \ 316 316 v(bool, recordGCPauseTimes, false, nullptr) \ 317 317 v(bool, logHeapStatisticsAtExit, false, nullptr) \ 318 v(bool, enableTypeProfiler, false, nullptr) \319 v(bool, enableControlFlowProfiler, false, nullptr) \318 v(bool, useTypeProfiler, false, nullptr) \ 319 v(bool, useControlFlowProfiler, false, nullptr) \ 320 320 \ 321 321 v(bool, verifyHeap, false, nullptr) \ 322 322 v(unsigned, numberOfGCCyclesToRecordForVerification, 3, nullptr) \ 323 323 \ 324 v(bool, enableExceptionFuzz, false, nullptr) \324 v(bool, useExceptionFuzz, false, nullptr) \ 325 325 v(unsigned, fireExceptionFuzzAt, 0, nullptr) \ 326 326 \ 327 v(bool, enableExecutableAllocationFuzz, false, nullptr) \327 v(bool, useExecutableAllocationFuzz, false, nullptr) \ 328 328 v(unsigned, fireExecutableAllocationFuzzAt, 0, nullptr) \ 329 329 v(unsigned, fireExecutableAllocationFuzzAtOrAfter, 0, nullptr) \ 330 330 v(bool, verboseExecutableAllocationFuzz, false, nullptr) \ 331 331 \ 332 v(bool, enableOSRExitFuzz, false, nullptr) \332 v(bool, useOSRExitFuzz, false, nullptr) \ 333 333 v(unsigned, fireOSRExitFuzzAtStatic, 0, nullptr) \ 334 334 v(unsigned, fireOSRExitFuzzAt, 0, nullptr) \ 335 335 v(unsigned, fireOSRExitFuzzAtOrAfter, 0, nullptr) \ 336 336 \ 337 v(bool, enableDollarVM, false, "installs the $vm debugging tool in global objects") \337 v(bool, useDollarVM, false, "installs the $vm debugging tool in global objects") \ 338 338 v(optionString, functionOverrides, nullptr, "file with debugging overrides for function bodies") \ 339 339 \ … … 420 420 Options(); 421 421 422 enum ShowDefaultsOption {423 Dont ShowDefaults,424 ShowDefaults422 enum DumpDefaultsOption { 423 DontDumpDefaults, 424 DumpDefaults 425 425 }; 426 426 static void dumpOptionsIfNeeded(); 427 427 static void dumpAllOptions(StringBuilder&, DumpLevel, const char* title, 428 const char* separator, const char* optionHeader, const char* optionFooter, ShowDefaultsOption);428 const char* separator, const char* optionHeader, const char* optionFooter, DumpDefaultsOption); 429 429 static void dumpOption(StringBuilder&, DumpLevel, OptionID, 430 const char* optionHeader, const char* optionFooter, ShowDefaultsOption);430 const char* optionHeader, const char* optionFooter, DumpDefaultsOption); 431 431 432 432 // Declare the singleton instance of the options store: -
trunk/Source/JavaScriptCore/runtime/VM.cpp
r190827 r191058 282 282 LLInt::Data::performAssertions(*this); 283 283 284 if (Options:: enableProfiler()) {284 if (Options::useProfiler()) { 285 285 m_perBytecodeProfiler = std::make_unique<Profiler::Database>(*this); 286 286 … … 304 304 m_typedArrayController = adoptRef(new SimpleTypedArrayController()); 305 305 306 if (Options:: enableTypeProfiler())306 if (Options::useTypeProfiler()) 307 307 enableTypeProfiler(); 308 if (Options:: enableControlFlowProfiler())308 if (Options::useControlFlowProfiler()) 309 309 enableControlFlowProfiler(); 310 310 -
trunk/Source/JavaScriptCore/runtime/VM.h
r190888 r191058 494 494 EncodedJSValue* exceptionFuzzingBuffer(size_t size) 495 495 { 496 ASSERT(Options:: enableExceptionFuzz());496 ASSERT(Options::useExceptionFuzz()); 497 497 if (!m_exceptionFuzzBuffer) 498 498 m_exceptionFuzzBuffer = MallocPtr<EncodedJSValue>::malloc(size); -
trunk/Source/JavaScriptCore/runtime/WriteBarrierInlines.h
r163576 r191058 36 36 { 37 37 ASSERT(value); 38 ASSERT(!Options:: enableConcurrentJIT() || !isCompilationThread());38 ASSERT(!Options::useConcurrentJIT() || !isCompilationThread()); 39 39 validateCell(value); 40 40 setEarlyValue(vm, owner, value); … … 58 58 inline void WriteBarrierBase<Unknown>::set(VM& vm, const JSCell* owner, JSValue value) 59 59 { 60 ASSERT(!Options:: enableConcurrentJIT() || !isCompilationThread());60 ASSERT(!Options::useConcurrentJIT() || !isCompilationThread()); 61 61 m_value = JSValue::encode(value); 62 62 vm.heap.writeBarrier(owner, value); -
trunk/Source/JavaScriptCore/tests/executableAllocationFuzz.yaml
r181990 r191058 28 28 else 29 29 runExecutableAllocationFuzz("default") 30 runExecutableAllocationFuzz("no-cjit", "-- enableConcurrentJIT=false")30 runExecutableAllocationFuzz("no-cjit", "--useConcurrentJIT=false") 31 31 end -
trunk/Source/JavaScriptCore/tests/stress/arrowfunction-typeof.js
r188545 r191058 16 16 17 17 //Fixme: Some bug in inlining typeof with following run parameters ftl-no-cjit-no-inline-validate 18 // --useFTLJIT\=true -- enableFunctionDotArguments\=true --enableConcurrentJIT=false --thresholdForJITAfterWarmUp=100 --validateGraph=true --maximumInliningDepth=118 // --useFTLJIT\=true --useFunctionDotArguments\=true --useConcurrentJIT=false --thresholdForJITAfterWarmUp=100 --validateGraph=true --maximumInliningDepth=1 19 19 // 20 20 // for (var i = 0; i < 10000; ++i) { -
trunk/Source/JavaScriptCore/tests/stress/disable-function-dot-arguments.js
r174036 r191058 1 //@ run("function-dot-arguments", "-- enableFunctionDotArguments=false")1 //@ run("function-dot-arguments", "--useFunctionDotArguments=false") 2 2 3 3 function foo() { -
trunk/Source/JavaScriptCore/tests/stress/math-sqrt-basics-disable-architecture-specific-optimizations.js
r180085 r191058 1 //@ run("no-architecture-specific-optimizations", "-- enableArchitectureSpecificOptimizations=false", *NO_CJIT_OPTIONS)2 //@ run("no-architecture-specific-optimizations-ftl", "-- enableArchitectureSpecificOptimizations=false", *FTL_OPTIONS)1 //@ run("no-architecture-specific-optimizations", "--useArchitectureSpecificOptimizations=false", *NO_CJIT_OPTIONS) 2 //@ run("no-architecture-specific-optimizations-ftl", "--useArchitectureSpecificOptimizations=false", *FTL_OPTIONS) 3 3 4 4 // Basic cases of Math.sqrt(). -
trunk/Source/JavaScriptCore/tests/stress/regress-148564.js
r189120 r191058 6 6 // 1. A put operation must not being optimized by the DFG into a PutByOffset. 7 7 // It needs to be a PutById node instead so that it will use the inline cache. 8 // This is satisfied by using the -- enableAccessInlining=false option above.8 // This is satisfied by using the --useAccessInlining=false option above. 9 9 // 10 10 // 2. The PutById's execution must go through its transition stub. -
trunk/Tools/ChangeLog
r191047 r191058 1 2015-10-14 Mark Lam <mark.lam@apple.com> 2 3 Rename some JSC option names to be more uniform. 4 https://bugs.webkit.org/show_bug.cgi?id=150127 5 6 Reviewed by Geoffrey Garen. 7 8 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: 9 * Scripts/run-jsc-stress-tests: 10 1 11 2015-10-14 Anders Carlsson <andersca@apple.com> 2 12 -
trunk/Tools/Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz
r181990 r191058 70 70 } 71 71 72 open (my $testInput, "$commandString -- enableExecutableAllocationFuzz=true |") or fail("Cannot execute initial command when getting check count");72 open (my $testInput, "$commandString --useExecutableAllocationFuzz=true |") or fail("Cannot execute initial command when getting check count"); 73 73 while (my $inputLine = <$testInput>) { 74 74 chomp($inputLine); … … 102 102 print "iteration($iteration) target($target) one-shot: Running.\n"; 103 103 } 104 my $result = system("$commandString -- enableExecutableAllocationFuzz=true --fireExecutableAllocationFuzzAt=$target");104 my $result = system("$commandString --useExecutableAllocationFuzz=true --fireExecutableAllocationFuzzAt=$target"); 105 105 if ($result != 0) { 106 106 fail("Cannot execute command on iteration $iteration, status $? for target $target"); … … 116 116 print "iteration($iteration) target($target) at-or-after: Running.\n"; 117 117 } 118 my $result = system("$commandString -- enableExecutableAllocationFuzz=true --fireExecutableAllocationFuzzAtOrAfter=$target");118 my $result = system("$commandString --useExecutableAllocationFuzz=true --fireExecutableAllocationFuzzAtOrAfter=$target"); 119 119 if ($result != 0) { 120 120 fail("Cannot execute command on iteration $iteration, status $? for target $target"); -
trunk/Tools/Scripts/run-jsc-stress-tests
r190630 r191058 362 362 $numFailures = 0 363 363 364 BASE_OPTIONS = ["--useFTLJIT=false", "-- enableFunctionDotArguments=true"]364 BASE_OPTIONS = ["--useFTLJIT=false", "--useFunctionDotArguments=true"] 365 365 EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20", "--maximumEvalCacheableSourceLength=150000"] 366 NO_CJIT_OPTIONS = ["-- enableConcurrentJIT=false", "--thresholdForJITAfterWarmUp=100"]366 NO_CJIT_OPTIONS = ["--useConcurrentJIT=false", "--thresholdForJITAfterWarmUp=100"] 367 367 FTL_OPTIONS = ["--useFTLJIT=true", "--ftlCrashesIfCantInitializeLLVM=true"] 368 368 … … 780 780 781 781 def runNoCJITNoASO 782 run("no-cjit-no-aso", "-- enableArchitectureSpecificOptimizations=false", *NO_CJIT_OPTIONS)782 run("no-cjit-no-aso", "--useArchitectureSpecificOptimizations=false", *NO_CJIT_OPTIONS) 783 783 end 784 784 … … 788 788 789 789 def runNoCJITNoAccessInlining 790 run("no-cjit-no-access-inlining", "-- enableAccessInlining=false", *NO_CJIT_OPTIONS)790 run("no-cjit-no-access-inlining", "--useAccessInlining=false", *NO_CJIT_OPTIONS) 791 791 end 792 792 793 793 def runFTLNoCJITNoAccessInlining 794 run("ftl-no-cjit-no-access-inlining", "-- enableAccessInlining=false", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL794 run("ftl-no-cjit-no-access-inlining", "--useAccessInlining=false", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) if $enableFTL 795 795 end 796 796 … … 808 808 809 809 def runDFGMaximalFlushPhase 810 run("dfg-maximal-flush-validate-no-cjit", "--validateGraph=true", "-- enableMaximalFlushInsertionPhase=true", *NO_CJIT_OPTIONS)810 run("dfg-maximal-flush-validate-no-cjit", "--validateGraph=true", "--useMaximalFlushInsertionPhase=true", *NO_CJIT_OPTIONS) 811 811 end 812 812 … … 904 904 905 905 if $enableFTL 906 run("ftl-no-cjit-type-profiler", "-- enableTypeProfiler=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS))907 else 908 run("no-cjit-type-profiler", "-- enableTypeProfiler=true", *NO_CJIT_OPTIONS)906 run("ftl-no-cjit-type-profiler", "--useTypeProfiler=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) 907 else 908 run("no-cjit-type-profiler", "--useTypeProfiler=true", *NO_CJIT_OPTIONS) 909 909 end 910 910 end … … 916 916 917 917 if $enableFTL 918 run("ftl-no-cjit-type-profiler", "-- enableControlFlowProfiler=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS))919 else 920 run("no-cjit-type-profiler", "-- enableControlFlowProfiler=true", *NO_CJIT_OPTIONS)918 run("ftl-no-cjit-type-profiler", "--useControlFlowProfiler=true", *(FTL_OPTIONS + NO_CJIT_OPTIONS)) 919 else 920 run("no-cjit-type-profiler", "--useControlFlowProfiler=true", *NO_CJIT_OPTIONS) 921 921 end 922 922 end
Note:
See TracChangeset
for help on using the changeset viewer.