Changeset 192663 in webkit

Timestamp:

Nov 19, 2015 3:14:55 PM (8 years ago)

Author:

mark.lam@apple.com

Message:

js/regress/script-tests/ftl-object-sub.js needs more iterations for benchmarking.
​https://bugs.webkit.org/show_bug.cgi?id=151411

Reviewed by Filip Pizlo.

Previously, in r192392, I reduced the test iteration count to make the layout
test happy and not time out. Unfortunately, this defeats the use of this test
for benchmarking. I've changed it to now use different iteration counts
depending on who is running it. run-jsc-stress-tests is fine with the higher
iteration count.

Since this test is slow and only meant to test the FTL, I also changed the run
configuration to be runFTLNoCJIT to minimize the slowness hit when running jsc
stress tests.

• js/regress/script-tests/ftl-object-sub.js:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• js/regress/script-tests/ftl-object-sub.js (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-11-19  Mark Lam  <mark.lam@apple.com>
+
+        js/regress/script-tests/ftl-object-sub.js needs more iterations for benchmarking.
+        https://bugs.webkit.org/show_bug.cgi?id=151411
+
+        Reviewed by Filip Pizlo.
+
+        Previously, in r192392, I reduced the test iteration count to make the layout
+        test happy and not time out.  Unfortunately, this defeats the use of this test
+        for benchmarking.  I've changed it to now use different iteration counts
+        depending on who is running it.  run-jsc-stress-tests is fine with the higher
+        iteration count.
+
+        Since this test is slow and only meant to test the FTL, I also changed the run
+        configuration to be runFTLNoCJIT to minimize the slowness hit when running jsc
+        stress tests.
+
+        * js/regress/script-tests/ftl-object-sub.js:
+
 2015-11-19  Zalan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/js/regress/script-tests/ftl-object-sub.js

@@ -1 @@
-//@ runDefault
+//@ runFTLNoCJIT
 var o1 = {
     i: 0,
@@ -22 +22 @@
 noInline(foo);
 
-for (var i = 0; i <= 10000; i++) {
+var iterations;
+var expectedResult;
+if (this.window) {
+    // The layout test doesn't like too many iterations and may time out.
+    iterations = 10000;
+    expectedResult = 200020;
+} else {
+    iterations = 100000;
+    expectedResult = 2000020;
+}
+
+
+for (var i = 0; i <= iterations; i++) {
     o1.i = i + 2;
     o2.i = i;
@@ -28 +40 @@
 }
 
-if (result != 200020)
+if (result != expectedResult)
     throw "Bad result: " + result;