Changeset 192795 in webkit

Timestamp:

Nov 30, 2015, 8:56:27 AM (9 years ago)

Author:

mark.lam@apple.com

Message:

[ARM64] stress/op_div.js is failing on some divide by 0 cases.
​https://bugs.webkit.org/show_bug.cgi?id=151515

Reviewed by Saam Barati.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithDiv):

• Added a check for the divide by zero case.
• tests/stress/op_div.js:
• Un-skipped the test.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT.cpp (modified) (1 diff)
• tests/stress/op_div.js (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog ¶

@@ +1 @@
+2015-11-26  Mark Lam  <mark.lam@apple.com>
+
+        [ARM64] stress/op_div.js is failing on some divide by 0 cases.
+        https://bugs.webkit.org/show_bug.cgi?id=151515
+
+        Reviewed by Saam Barati.
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::compileArithDiv):
+        - Added a check for the divide by zero case.
+        * tests/stress/op_div.js:
+        - Un-skipped the test.
+
 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp ¶

@@ -3556 +3556 @@
             numeratorNonZero.link(&m_jit);
         }
+
+        if (shouldCheckOverflow(node->arithMode()))
+            speculationCheck(Overflow, JSValueRegs(), nullptr, m_jit.branchTest32(MacroAssembler::Zero, op2GPR));
 
         m_jit.assembler().sdiv<32>(quotient.gpr(), op1GPR, op2GPR);

trunk/Source/JavaScriptCore/tests/stress/op_div.js ¶

@@ -1 @@
-//@ skip
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=151515
+//@ runFTLNoCJIT
 
 // If all goes well, this test module will terminate silently. If not, it will print